From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Jonas Gorski" <jonas.gorski@gmail.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] mtd: parsers: bcm63xx: Do not make it modular
Date: Tue, 29 Sep 2020 10:27:21 -0700 [thread overview]
Message-ID: <20200929172726.30469-1-f.fainelli@gmail.com> (raw)
In-Reply-To: <20200928161617.2a1b2244@xps13>
With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE
detection"), we generate a reference to fw_arg3 which is the fourth
firmware/command line argument on MIPS platforms. That symbol is not
exported and would cause a linking failure.
The parser is typically necessary to boot a BCM63xx-based system anyway
so having it be part of the kernel image makes sense, therefore make it
'bool' instead of 'tristate'.
Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/mtd/parsers/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
index f98363c9b363..e72354322f62 100644
--- a/drivers/mtd/parsers/Kconfig
+++ b/drivers/mtd/parsers/Kconfig
@@ -12,7 +12,7 @@ config MTD_BCM47XX_PARTS
boards.
config MTD_BCM63XX_PARTS
- tristate "BCM63XX CFE partitioning parser"
+ bool "BCM63XX CFE partitioning parser"
depends on BCM63XX || BMIPS_GENERIC || COMPILE_TEST
select CRC32
select MTD_PARSER_IMAGETAG
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Richard Weinberger" <richard@nod.at>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"open list" <linux-kernel@vger.kernel.org>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Jonas Gorski" <jonas.gorski@gmail.com>
Subject: [PATCH] mtd: parsers: bcm63xx: Do not make it modular
Date: Tue, 29 Sep 2020 10:27:21 -0700 [thread overview]
Message-ID: <20200929172726.30469-1-f.fainelli@gmail.com> (raw)
In-Reply-To: <20200928161617.2a1b2244@xps13>
With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE
detection"), we generate a reference to fw_arg3 which is the fourth
firmware/command line argument on MIPS platforms. That symbol is not
exported and would cause a linking failure.
The parser is typically necessary to boot a BCM63xx-based system anyway
so having it be part of the kernel image makes sense, therefore make it
'bool' instead of 'tristate'.
Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/mtd/parsers/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig
index f98363c9b363..e72354322f62 100644
--- a/drivers/mtd/parsers/Kconfig
+++ b/drivers/mtd/parsers/Kconfig
@@ -12,7 +12,7 @@ config MTD_BCM47XX_PARTS
boards.
config MTD_BCM63XX_PARTS
- tristate "BCM63XX CFE partitioning parser"
+ bool "BCM63XX CFE partitioning parser"
depends on BCM63XX || BMIPS_GENERIC || COMPILE_TEST
select CRC32
select MTD_PARSER_IMAGETAG
--
2.25.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-09-29 17:28 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:40 [PATCH 0/2] mtd: parsers: bcm63xx: simplify CFE detection Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` [PATCH 1/2] MIPS: BCM63xx: add helper function to detect CFE Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` [PATCH 2/2] mtd: parsers: bcm63xx: simplify CFE detection Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 12:59 ` kernel test robot
2020-06-08 16:06 ` [PATCH v2] " Álvaro Fernández Rojas
2020-06-08 16:06 ` Álvaro Fernández Rojas
2020-06-08 16:06 ` Álvaro Fernández Rojas
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:35 ` [PATCH v3] " Álvaro Fernández Rojas
2020-06-12 7:35 ` Álvaro Fernández Rojas
2020-06-12 7:35 ` Álvaro Fernández Rojas
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 9:17 ` [PATCH v4] " Álvaro Fernández Rojas
2020-06-15 9:17 ` Álvaro Fernández Rojas
2020-06-15 9:17 ` Álvaro Fernández Rojas
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 17:38 ` Miquel Raynal
2020-06-15 17:38 ` Miquel Raynal
2020-06-15 17:38 ` Miquel Raynal
2020-08-14 8:56 ` Guenter Roeck
2020-08-14 8:56 ` Guenter Roeck
2020-08-14 8:56 ` Guenter Roeck
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:26 ` Guenter Roeck
2020-09-22 3:26 ` Guenter Roeck
2020-09-22 3:26 ` Guenter Roeck
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 19:35 ` Florian Fainelli
2020-09-28 19:35 ` Florian Fainelli
2020-09-28 19:35 ` Florian Fainelli
2020-09-29 17:27 ` Florian Fainelli [this message]
2020-09-29 17:27 ` [PATCH] mtd: parsers: bcm63xx: Do not make it modular Florian Fainelli
2020-10-02 7:15 ` Miquel Raynal
2020-10-02 7:15 ` Miquel Raynal
2020-10-11 14:14 ` Guenter Roeck
2020-10-11 14:14 ` Guenter Roeck
2020-10-12 7:04 ` Miquel Raynal
2020-10-12 7:04 ` Miquel Raynal
2020-10-12 13:24 ` Guenter Roeck
2020-10-12 13:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929172726.30469-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=noltari@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.