From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
linux-mtd@lists.infradead.org,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
"Jonas Gorski" <jonas.gorski@gmail.com>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: parsers: bcm63xx: Do not make it modular
Date: Mon, 12 Oct 2020 09:04:20 +0200 [thread overview]
Message-ID: <20201012090420.6a07599c@xps13> (raw)
In-Reply-To: <20201011141447.GA9215@roeck-us.net>
Hi Guenter,
Guenter Roeck <linux@roeck-us.net> wrote on Sun, 11 Oct 2020 07:14:47
-0700:
> On Tue, Sep 29, 2020 at 10:27:21AM -0700, Florian Fainelli wrote:
> > With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE
> > detection"), we generate a reference to fw_arg3 which is the fourth
> > firmware/command line argument on MIPS platforms. That symbol is not
> > exported and would cause a linking failure.
> >
> > The parser is typically necessary to boot a BCM63xx-based system anyway
> > so having it be part of the kernel image makes sense, therefore make it
> > 'bool' instead of 'tristate'.
> >
> > Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection")
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> What happened with this patch ? The build failure is still seen in mainline
> and in next-20201009.
It has been applied on mtd/next:
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd/next
(I don't remember when though)
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Richard Weinberger" <richard@nod.at>,
"open list" <linux-kernel@vger.kernel.org>,
"Álvaro Fernández Rojas" <noltari@gmail.com>,
linux-mtd@lists.infradead.org,
"Jonas Gorski" <jonas.gorski@gmail.com>
Subject: Re: [PATCH] mtd: parsers: bcm63xx: Do not make it modular
Date: Mon, 12 Oct 2020 09:04:20 +0200 [thread overview]
Message-ID: <20201012090420.6a07599c@xps13> (raw)
In-Reply-To: <20201011141447.GA9215@roeck-us.net>
Hi Guenter,
Guenter Roeck <linux@roeck-us.net> wrote on Sun, 11 Oct 2020 07:14:47
-0700:
> On Tue, Sep 29, 2020 at 10:27:21AM -0700, Florian Fainelli wrote:
> > With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE
> > detection"), we generate a reference to fw_arg3 which is the fourth
> > firmware/command line argument on MIPS platforms. That symbol is not
> > exported and would cause a linking failure.
> >
> > The parser is typically necessary to boot a BCM63xx-based system anyway
> > so having it be part of the kernel image makes sense, therefore make it
> > 'bool' instead of 'tristate'.
> >
> > Fixes: 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE detection")
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> What happened with this patch ? The build failure is still seen in mainline
> and in next-20201009.
It has been applied on mtd/next:
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/log/?h=mtd/next
(I don't remember when though)
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-12 7:04 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 9:40 [PATCH 0/2] mtd: parsers: bcm63xx: simplify CFE detection Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` [PATCH 1/2] MIPS: BCM63xx: add helper function to detect CFE Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` [PATCH 2/2] mtd: parsers: bcm63xx: simplify CFE detection Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 9:40 ` Álvaro Fernández Rojas
2020-06-08 12:59 ` kernel test robot
2020-06-08 16:06 ` [PATCH v2] " Álvaro Fernández Rojas
2020-06-08 16:06 ` Álvaro Fernández Rojas
2020-06-08 16:06 ` Álvaro Fernández Rojas
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 7:55 ` Miquel Raynal
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:16 ` Álvaro Fernández Rojas
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:42 ` Florian Fainelli
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 15:46 ` Miquel Raynal
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-11 16:14 ` Álvaro Fernández Rojas
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:02 ` Miquel Raynal
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:30 ` Álvaro Fernández Rojas
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:33 ` Miquel Raynal
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:37 ` Álvaro Fernández Rojas
2020-06-12 7:35 ` [PATCH v3] " Álvaro Fernández Rojas
2020-06-12 7:35 ` Álvaro Fernández Rojas
2020-06-12 7:35 ` Álvaro Fernández Rojas
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 8:54 ` Miquel Raynal
2020-06-15 9:17 ` [PATCH v4] " Álvaro Fernández Rojas
2020-06-15 9:17 ` Álvaro Fernández Rojas
2020-06-15 9:17 ` Álvaro Fernández Rojas
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 16:30 ` Florian Fainelli
2020-06-15 17:38 ` Miquel Raynal
2020-06-15 17:38 ` Miquel Raynal
2020-06-15 17:38 ` Miquel Raynal
2020-08-14 8:56 ` Guenter Roeck
2020-08-14 8:56 ` Guenter Roeck
2020-08-14 8:56 ` Guenter Roeck
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:18 ` Naresh Kamboju
2020-09-22 3:26 ` Guenter Roeck
2020-09-22 3:26 ` Guenter Roeck
2020-09-22 3:26 ` Guenter Roeck
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 14:16 ` Miquel Raynal
2020-09-28 19:35 ` Florian Fainelli
2020-09-28 19:35 ` Florian Fainelli
2020-09-28 19:35 ` Florian Fainelli
2020-09-29 17:27 ` [PATCH] mtd: parsers: bcm63xx: Do not make it modular Florian Fainelli
2020-09-29 17:27 ` Florian Fainelli
2020-10-02 7:15 ` Miquel Raynal
2020-10-02 7:15 ` Miquel Raynal
2020-10-11 14:14 ` Guenter Roeck
2020-10-11 14:14 ` Guenter Roeck
2020-10-12 7:04 ` Miquel Raynal [this message]
2020-10-12 7:04 ` Miquel Raynal
2020-10-12 13:24 ` Guenter Roeck
2020-10-12 13:24 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012090420.6a07599c@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=noltari@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.