From: Wolfram Sang <wsa@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Nicolas Belin <nbelin@baylibre.com>,
linux-i2c@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c: meson: fixup rate calculation with filter delay
Date: Thu, 8 Oct 2020 12:00:34 +0200 [thread overview]
Message-ID: <20201008100034.GE76290@ninjato> (raw)
In-Reply-To: <20201007080751.1259442-4-jbrunet@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
On Wed, Oct 07, 2020 at 10:07:51AM +0200, Jerome Brunet wrote:
> From: Nicolas Belin <nbelin@baylibre.com>
>
> Apparently, 15 cycles of the peripheral clock are used by the controller
> for sampling and filtering. Because this was not known before, the rate
> calculation is slightly off.
>
> Clean up and fix the calculation taking this filtering delay into account.
>
> Fixes: 30021e3707a7 ("i2c: add support for Amlogic Meson I2C controller")
> Signed-off-by: Nicolas Belin <nbelin@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Nicolas Belin <nbelin@baylibre.com>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 3/3] i2c: meson: fixup rate calculation with filter delay
Date: Thu, 8 Oct 2020 12:00:34 +0200 [thread overview]
Message-ID: <20201008100034.GE76290@ninjato> (raw)
In-Reply-To: <20201007080751.1259442-4-jbrunet@baylibre.com>
[-- Attachment #1.1: Type: text/plain, Size: 605 bytes --]
On Wed, Oct 07, 2020 at 10:07:51AM +0200, Jerome Brunet wrote:
> From: Nicolas Belin <nbelin@baylibre.com>
>
> Apparently, 15 cycles of the peripheral clock are used by the controller
> for sampling and filtering. Because this was not known before, the rate
> calculation is slightly off.
>
> Clean up and fix the calculation taking this filtering delay into account.
>
> Fixes: 30021e3707a7 ("i2c: add support for Amlogic Meson I2C controller")
> Signed-off-by: Nicolas Belin <nbelin@baylibre.com>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-10-08 10:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 8:07 [PATCH 0/3] i2c: meson: scl rate fixups Jerome Brunet
2020-10-07 8:07 ` Jerome Brunet
2020-10-07 8:07 ` [PATCH 1/3] i2c: meson: fix clock setting overwrite Jerome Brunet
2020-10-07 8:07 ` Jerome Brunet
2020-10-08 9:59 ` Wolfram Sang
2020-10-08 9:59 ` Wolfram Sang
2020-10-07 8:07 ` [PATCH 2/3] i2c: meson: keep peripheral clock enabled Jerome Brunet
2020-10-07 8:07 ` Jerome Brunet
2020-10-08 10:00 ` Wolfram Sang
2020-10-08 10:00 ` Wolfram Sang
2020-10-07 8:07 ` [PATCH 3/3] i2c: meson: fixup rate calculation with filter delay Jerome Brunet
2020-10-07 8:07 ` Jerome Brunet
2020-10-08 10:00 ` Wolfram Sang [this message]
2020-10-08 10:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008100034.GE76290@ninjato \
--to=wsa@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbelin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.