From: Sudeep Holla <sudeep.holla@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lukasz.luba@arm.com,
james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com,
etienne.carriere@linaro.org, Sudeep Holla <sudeep.holla@arm.com>,
thara.gopinath@linaro.org, vincent.guittot@linaro.org,
souvik.chakravarty@arm.com
Subject: Re: [PATCH 01/11] firmware: arm_scmi: review protocol registration interface
Date: Wed, 14 Oct 2020 21:20:00 +0100 [thread overview]
Message-ID: <20201014202000.3f57rx73d2vele47@bogus> (raw)
In-Reply-To: <1b461304-2c25-3206-5799-b561ac6e0bd2@gmail.com>
On Wed, Oct 14, 2020 at 12:03:45PM -0700, Florian Fainelli wrote:
> On 10/14/20 8:05 AM, Cristian Marussi wrote:
> > Extend common protocol registration routines and provide some new generic
> > protocols' init/deinit helpers that tracks protocols' users and automatically
> > perform the proper initialization/de-initialization on demand.
> >
> > Convert all protocols to use new registration schema while modifying only Base
> > protocol to use also the new initialization helpers.
> >
> > All other standard protocols' initialization is still umodified and bound to
> > SCMI devices probing.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
>
[...]
>
> > + struct scmi_protocol_instance *protocols[SCMI_MAX_PROTO];
>
> Humm that would be 2048 bytes on a 64-bit platform and 1024 bytes on a
> 32-bit platform, this is not so bad, but it is a bit wasteful given that
> 6-7 standard protocols are typically found, and most often no
> proprietary protocols are registered. Not necessarily to be addressed
> right now.
>
Thanks for looking at these patches so quickly, much appreciated.
I haven't looked at this series in detail yet. But this is something that
caught my attention too when I glanced at these patches. I mentioned the
same to Cristian. Indeed we can address that separately, we have even this
for notification, we need to see if we can put all such info in a container
structure and then use hashtable or idr.
--
Regards,
Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, thara.gopinath@linaro.org,
lukasz.luba@arm.com, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, souvik.chakravarty@arm.com,
vincent.guittot@linaro.org, etienne.carriere@linaro.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/11] firmware: arm_scmi: review protocol registration interface
Date: Wed, 14 Oct 2020 21:20:00 +0100 [thread overview]
Message-ID: <20201014202000.3f57rx73d2vele47@bogus> (raw)
In-Reply-To: <1b461304-2c25-3206-5799-b561ac6e0bd2@gmail.com>
On Wed, Oct 14, 2020 at 12:03:45PM -0700, Florian Fainelli wrote:
> On 10/14/20 8:05 AM, Cristian Marussi wrote:
> > Extend common protocol registration routines and provide some new generic
> > protocols' init/deinit helpers that tracks protocols' users and automatically
> > perform the proper initialization/de-initialization on demand.
> >
> > Convert all protocols to use new registration schema while modifying only Base
> > protocol to use also the new initialization helpers.
> >
> > All other standard protocols' initialization is still umodified and bound to
> > SCMI devices probing.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > ---
>
[...]
>
> > + struct scmi_protocol_instance *protocols[SCMI_MAX_PROTO];
>
> Humm that would be 2048 bytes on a 64-bit platform and 1024 bytes on a
> 32-bit platform, this is not so bad, but it is a bit wasteful given that
> 6-7 standard protocols are typically found, and most often no
> proprietary protocols are registered. Not necessarily to be addressed
> right now.
>
Thanks for looking at these patches so quickly, much appreciated.
I haven't looked at this series in detail yet. But this is something that
caught my attention too when I glanced at these patches. I mentioned the
same to Cristian. Indeed we can address that separately, we have even this
for notification, we need to see if we can put all such info in a container
structure and then use hashtable or idr.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-14 20:20 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 15:05 [PATCH 00/11] SCMI vendor protocols and modularization Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 01/11] firmware: arm_scmi: review protocol registration interface Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 19:03 ` Florian Fainelli
2020-10-14 19:03 ` Florian Fainelli
2020-10-14 20:20 ` Sudeep Holla [this message]
2020-10-14 20:20 ` Sudeep Holla
2020-10-15 8:42 ` Cristian Marussi
2020-10-15 8:42 ` Cristian Marussi
2020-10-15 9:41 ` Vincent Guittot
2020-10-15 9:41 ` Vincent Guittot
2020-10-15 9:58 ` Cristian Marussi
2020-10-15 9:58 ` Cristian Marussi
2020-10-21 2:46 ` Thara Gopinath
2020-10-21 2:46 ` Thara Gopinath
2020-10-21 10:08 ` Cristian Marussi
2020-10-21 10:08 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 02/11] firmware: arm_scmi: hide protocols' private data Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 19:19 ` Florian Fainelli
2020-10-14 19:19 ` Florian Fainelli
2020-10-15 8:52 ` Cristian Marussi
2020-10-15 8:52 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 03/11] firmware: arm_scmi: introduce common protocol interface Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-21 2:47 ` Thara Gopinath
2020-10-21 2:47 ` Thara Gopinath
2020-10-21 10:27 ` Cristian Marussi
2020-10-21 10:27 ` Cristian Marussi
2020-10-26 13:07 ` Thara Gopinath
2020-10-26 13:07 ` Thara Gopinath
2020-10-28 21:04 ` Cristian Marussi
2020-10-28 21:04 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 04/11] firmware: arm_scmi: refactor events registration Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 05/11] firmware: arm_scmi: make notify_priv really private Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 06/11] firmware: arm_scmi: add support for protocol modularization Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-21 2:47 ` Thara Gopinath
2020-10-21 2:47 ` Thara Gopinath
2020-10-21 10:30 ` Cristian Marussi
2020-10-21 10:30 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 07/11] [DEBUG] firmware: arm_scmi: add example custom protocol Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 08/11] [DEBUG] arm64: dts: juno: add example custom protocol support Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 09/11] [DEBUG] firmware: arm_scmi: add example SCMI driver for custom protocol Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-14 15:55 ` Randy Dunlap
2020-10-14 15:55 ` Randy Dunlap
2020-10-14 16:44 ` Cristian Marussi
2020-10-14 16:44 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 10/11] [DEBUG] firmware: arm_scmi: add custom_dummy SCMI devname Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
2020-10-21 2:49 ` Thara Gopinath
2020-10-21 2:49 ` Thara Gopinath
2020-10-21 11:35 ` Cristian Marussi
2020-10-21 11:35 ` Cristian Marussi
2020-10-26 12:37 ` Thara Gopinath
2020-10-26 12:37 ` Thara Gopinath
2020-10-28 21:28 ` Cristian Marussi
2020-10-28 21:28 ` Cristian Marussi
2020-10-14 15:05 ` [PATCH 11/11] [DEBUG][HACK] firmware: arm_scmi: force implemented protocol 0x99 Cristian Marussi
2020-10-14 15:05 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014202000.3f57rx73d2vele47@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=cristian.marussi@arm.com \
--cc=etienne.carriere@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=souvik.chakravarty@arm.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.