From: David Gibson <david@gibson.dropbear.id.au> To: Halil Pasic <pasic@linux.ibm.com> Cc: Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cohuck@redhat.com>, pair@us.ibm.com, brijesh.singh@amd.com, frankja@linux.ibm.com, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Marcelo Tosatti <mtosatti@redhat.com>, david@redhat.com, dgilbert@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com, thuth@redhat.com, pbonzini@redhat.com, rth@twiddle.net, mdroth@linux.vnet.ibm.com Subject: Re: [for-6.0 v5 12/13] securable guest memory: Alter virtio default properties for protected guests Date: Tue, 8 Dec 2020 12:54:03 +1100 [thread overview] Message-ID: <20201208015403.GB2555@yekko.fritz.box> (raw) In-Reply-To: <20201204154310.158b410e.pasic@linux.ibm.com> [-- Attachment #1: Type: text/plain, Size: 3394 bytes --] On Fri, Dec 04, 2020 at 03:43:10PM +0100, Halil Pasic wrote: > On Fri, 4 Dec 2020 09:29:59 +0100 > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > On 04.12.20 09:17, Cornelia Huck wrote: > > > On Fri, 4 Dec 2020 09:10:36 +0100 > > > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > > > >> On 04.12.20 06:44, David Gibson wrote: > > >>> The default behaviour for virtio devices is not to use the platforms normal > > >>> DMA paths, but instead to use the fact that it's running in a hypervisor > > >>> to directly access guest memory. That doesn't work if the guest's memory > > >>> is protected from hypervisor access, such as with AMD's SEV or POWER's PEF. > > >>> > > >>> So, if a securable guest memory mechanism is enabled, then apply the > > >>> iommu_platform=on option so it will go through normal DMA mechanisms. > > >>> Those will presumably have some way of marking memory as shared with > > >>> the hypervisor or hardware so that DMA will work. > > >>> > > >>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > > >>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > >>> --- > > >>> hw/core/machine.c | 13 +++++++++++++ > > >>> 1 file changed, 13 insertions(+) > > >>> > > >>> diff --git a/hw/core/machine.c b/hw/core/machine.c > > >>> index a67a27d03c..d16273d75d 100644 > > >>> --- a/hw/core/machine.c > > >>> +++ b/hw/core/machine.c > > >>> @@ -28,6 +28,8 @@ > > >>> #include "hw/mem/nvdimm.h" > > >>> #include "migration/vmstate.h" > > >>> #include "exec/securable-guest-memory.h" > > >>> +#include "hw/virtio/virtio.h" > > >>> +#include "hw/virtio/virtio-pci.h" > > >>> > > >>> GlobalProperty hw_compat_5_1[] = { > > >>> { "vhost-scsi", "num_queues", "1"}, > > >>> @@ -1169,6 +1171,17 @@ void machine_run_board_init(MachineState *machine) > > >>> * areas. > > >>> */ > > >>> machine_set_mem_merge(OBJECT(machine), false, &error_abort); > > >>> + > > >>> + /* > > >>> + * Virtio devices can't count on directly accessing guest > > >>> + * memory, so they need iommu_platform=on to use normal DMA > > >>> + * mechanisms. That requires also disabling legacy virtio > > >>> + * support for those virtio pci devices which allow it. > > >>> + */ > > >>> + object_register_sugar_prop(TYPE_VIRTIO_PCI, "disable-legacy", > > >>> + "on", true); > > >>> + object_register_sugar_prop(TYPE_VIRTIO_DEVICE, "iommu_platform", > > >>> + "on", false); > > >> > > >> I have not followed all the history (sorry). Should we also set iommu_platform > > >> for virtio-ccw? Halil? > > >> > > > > > > That line should add iommu_platform for all virtio devices, shouldn't > > > it? > > > > Yes, sorry. Was misreading that with the line above. > > > > I believe this is the best we can get. In a sense it is still a > pessimization, I'm not really clear on what you're getting at here. > but it is a big usability improvement compared to having > to set iommu_platform manually. > > Regards, > Halil > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au> To: Halil Pasic <pasic@linux.ibm.com> Cc: pair@us.ibm.com, Marcelo Tosatti <mtosatti@redhat.com>, brijesh.singh@amd.com, frankja@linux.ibm.com, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, dgilbert@redhat.com, qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, thuth@redhat.com, berrange@redhat.com, david@redhat.com, rth@twiddle.net, mdroth@linux.vnet.ibm.com, Eduardo Habkost <ehabkost@redhat.com> Subject: Re: [for-6.0 v5 12/13] securable guest memory: Alter virtio default properties for protected guests Date: Tue, 8 Dec 2020 12:54:03 +1100 [thread overview] Message-ID: <20201208015403.GB2555@yekko.fritz.box> (raw) In-Reply-To: <20201204154310.158b410e.pasic@linux.ibm.com> [-- Attachment #1: Type: text/plain, Size: 3394 bytes --] On Fri, Dec 04, 2020 at 03:43:10PM +0100, Halil Pasic wrote: > On Fri, 4 Dec 2020 09:29:59 +0100 > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > On 04.12.20 09:17, Cornelia Huck wrote: > > > On Fri, 4 Dec 2020 09:10:36 +0100 > > > Christian Borntraeger <borntraeger@de.ibm.com> wrote: > > > > > >> On 04.12.20 06:44, David Gibson wrote: > > >>> The default behaviour for virtio devices is not to use the platforms normal > > >>> DMA paths, but instead to use the fact that it's running in a hypervisor > > >>> to directly access guest memory. That doesn't work if the guest's memory > > >>> is protected from hypervisor access, such as with AMD's SEV or POWER's PEF. > > >>> > > >>> So, if a securable guest memory mechanism is enabled, then apply the > > >>> iommu_platform=on option so it will go through normal DMA mechanisms. > > >>> Those will presumably have some way of marking memory as shared with > > >>> the hypervisor or hardware so that DMA will work. > > >>> > > >>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> > > >>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> > > >>> --- > > >>> hw/core/machine.c | 13 +++++++++++++ > > >>> 1 file changed, 13 insertions(+) > > >>> > > >>> diff --git a/hw/core/machine.c b/hw/core/machine.c > > >>> index a67a27d03c..d16273d75d 100644 > > >>> --- a/hw/core/machine.c > > >>> +++ b/hw/core/machine.c > > >>> @@ -28,6 +28,8 @@ > > >>> #include "hw/mem/nvdimm.h" > > >>> #include "migration/vmstate.h" > > >>> #include "exec/securable-guest-memory.h" > > >>> +#include "hw/virtio/virtio.h" > > >>> +#include "hw/virtio/virtio-pci.h" > > >>> > > >>> GlobalProperty hw_compat_5_1[] = { > > >>> { "vhost-scsi", "num_queues", "1"}, > > >>> @@ -1169,6 +1171,17 @@ void machine_run_board_init(MachineState *machine) > > >>> * areas. > > >>> */ > > >>> machine_set_mem_merge(OBJECT(machine), false, &error_abort); > > >>> + > > >>> + /* > > >>> + * Virtio devices can't count on directly accessing guest > > >>> + * memory, so they need iommu_platform=on to use normal DMA > > >>> + * mechanisms. That requires also disabling legacy virtio > > >>> + * support for those virtio pci devices which allow it. > > >>> + */ > > >>> + object_register_sugar_prop(TYPE_VIRTIO_PCI, "disable-legacy", > > >>> + "on", true); > > >>> + object_register_sugar_prop(TYPE_VIRTIO_DEVICE, "iommu_platform", > > >>> + "on", false); > > >> > > >> I have not followed all the history (sorry). Should we also set iommu_platform > > >> for virtio-ccw? Halil? > > >> > > > > > > That line should add iommu_platform for all virtio devices, shouldn't > > > it? > > > > Yes, sorry. Was misreading that with the line above. > > > > I believe this is the best we can get. In a sense it is still a > pessimization, I'm not really clear on what you're getting at here. > but it is a big usability improvement compared to having > to set iommu_platform manually. > > Regards, > Halil > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-08 1:54 UTC|newest] Thread overview: 186+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-04 5:44 [for-6.0 v5 00/13] Generalize memory encryption models David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 01/13] qom: Allow optional sugar props David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 12:57 ` Cornelia Huck 2020-12-04 12:57 ` Cornelia Huck 2020-12-14 21:25 ` Eduardo Habkost 2020-12-14 21:25 ` Eduardo Habkost 2021-01-11 18:04 ` Philippe Mathieu-Daudé 2021-01-11 18:04 ` Philippe Mathieu-Daudé 2020-12-04 5:44 ` [for-6.0 v5 02/13] securable guest memory: Introduce new securable guest memory base class David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 03/13] securable guest memory: Handle memory encryption via interface David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 13:10 ` Cornelia Huck 2020-12-04 13:10 ` Cornelia Huck 2021-01-08 4:03 ` David Gibson 2021-01-08 4:03 ` David Gibson 2021-01-12 3:49 ` David Gibson 2021-01-12 3:49 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 04/13] securable guest memory: Move side effect out of machine_set_memory_encryption() David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 05/13] securable guest memory: Rework the "memory-encryption" property David Gibson 2020-12-04 5:44 ` David Gibson 2021-01-11 18:09 ` Philippe Mathieu-Daudé 2021-01-11 18:09 ` Philippe Mathieu-Daudé 2020-12-04 5:44 ` [for-6.0 v5 06/13] securable guest memory: Decouple kvm_memcrypt_*() helpers from KVM David Gibson 2020-12-04 5:44 ` David Gibson 2021-01-11 18:13 ` Philippe Mathieu-Daudé 2021-01-11 18:13 ` Philippe Mathieu-Daudé 2021-01-12 3:03 ` David Gibson 2021-01-12 3:03 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 07/13] sev: Add Error ** to sev_kvm_init() David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-14 16:50 ` Cornelia Huck 2020-12-14 16:50 ` Cornelia Huck 2020-12-04 5:44 ` [for-6.0 v5 08/13] securable guest memory: Introduce sgm "ready" flag David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-14 17:00 ` Cornelia Huck 2020-12-14 17:00 ` Cornelia Huck 2020-12-17 5:38 ` David Gibson 2020-12-17 5:38 ` David Gibson 2020-12-17 11:24 ` Cornelia Huck 2020-12-17 11:24 ` Cornelia Huck 2020-12-04 5:44 ` [for-6.0 v5 09/13] securable guest memory: Move SEV initialization into arch specific code David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 10/13] spapr: Add PEF based securable guest memory David Gibson 2020-12-04 5:44 ` David Gibson 2021-01-05 23:34 ` Ram Pai 2021-01-05 23:34 ` Ram Pai 2021-01-08 0:34 ` David Gibson 2021-01-08 0:34 ` David Gibson 2020-12-04 5:44 ` [for-6.0 v5 11/13] spapr: PEF: prevent migration David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-14 17:22 ` Cornelia Huck 2020-12-14 17:22 ` Cornelia Huck 2020-12-17 5:47 ` David Gibson 2020-12-17 5:47 ` David Gibson 2020-12-17 11:38 ` Cornelia Huck 2020-12-17 11:38 ` Cornelia Huck 2020-12-17 14:15 ` Greg Kurz 2020-12-17 14:15 ` Greg Kurz 2020-12-18 11:41 ` Cornelia Huck 2020-12-18 11:41 ` Cornelia Huck 2020-12-18 12:08 ` Dr. David Alan Gilbert 2020-12-18 12:08 ` Dr. David Alan Gilbert 2021-01-04 7:15 ` Ram Pai 2021-01-04 7:15 ` Ram Pai 2021-01-04 12:46 ` [EXTERNAL] " Halil Pasic 2021-01-04 12:46 ` Halil Pasic 2021-01-04 18:40 ` Ram Pai 2021-01-04 18:40 ` Ram Pai 2021-01-05 10:56 ` [EXTERNAL] " Halil Pasic 2021-01-05 10:56 ` Halil Pasic 2021-01-05 20:41 ` Ram Pai 2021-01-05 20:41 ` Ram Pai 2021-01-11 16:59 ` Cornelia Huck 2021-01-11 16:59 ` Cornelia Huck 2021-01-11 19:58 ` Ram Pai 2021-01-11 19:58 ` Ram Pai 2021-01-12 8:19 ` Cornelia Huck 2021-01-12 8:19 ` Cornelia Huck 2021-01-12 18:55 ` Ram Pai 2021-01-12 18:55 ` Ram Pai 2021-01-13 8:06 ` Cornelia Huck 2021-01-13 8:06 ` Cornelia Huck 2021-01-15 18:55 ` Ram Pai 2021-01-15 18:55 ` Ram Pai 2021-01-19 8:19 ` Cornelia Huck 2021-01-19 8:19 ` Cornelia Huck 2021-01-19 9:59 ` Daniel P. Berrangé 2021-01-19 9:59 ` Daniel P. Berrangé 2021-01-14 11:23 ` Daniel P. Berrangé 2021-01-14 11:23 ` Daniel P. Berrangé 2021-01-13 12:42 ` Dr. David Alan Gilbert 2021-01-13 12:42 ` Dr. David Alan Gilbert 2021-01-14 10:28 ` Christian Borntraeger 2021-01-14 10:28 ` Christian Borntraeger 2021-01-14 10:36 ` Dr. David Alan Gilbert 2021-01-14 10:36 ` Dr. David Alan Gilbert 2021-01-14 10:52 ` Christian Borntraeger 2021-01-14 10:52 ` Christian Borntraeger 2021-01-14 11:05 ` Cornelia Huck 2021-01-14 11:05 ` Cornelia Huck 2021-01-14 11:45 ` Dr. David Alan Gilbert 2021-01-14 11:45 ` Dr. David Alan Gilbert 2021-01-14 11:50 ` Christian Borntraeger 2021-01-14 11:50 ` Christian Borntraeger 2021-01-14 12:20 ` Daniel P. Berrangé 2021-01-14 12:20 ` Daniel P. Berrangé 2021-01-14 14:04 ` Cornelia Huck 2021-01-14 14:04 ` Cornelia Huck 2021-01-14 14:09 ` Christian Borntraeger 2021-01-14 14:09 ` Christian Borntraeger 2021-01-14 14:15 ` Daniel P. Berrangé 2021-01-14 14:15 ` Daniel P. Berrangé 2021-01-14 15:25 ` Christian Borntraeger 2021-01-14 15:25 ` Christian Borntraeger 2021-01-14 15:33 ` Daniel P. Berrangé 2021-01-14 15:33 ` Daniel P. Berrangé 2021-01-15 18:24 ` Ram Pai 2021-01-15 18:24 ` Ram Pai 2021-01-14 11:25 ` Daniel P. Berrangé 2021-01-14 11:25 ` Daniel P. Berrangé 2021-01-14 23:51 ` David Gibson 2021-01-14 23:51 ` David Gibson 2021-01-18 17:39 ` Dr. David Alan Gilbert 2021-01-18 17:39 ` Dr. David Alan Gilbert 2021-01-19 8:28 ` Christian Borntraeger 2021-01-19 8:28 ` Christian Borntraeger 2021-01-19 8:34 ` Cornelia Huck 2021-01-19 8:34 ` Cornelia Huck 2020-12-04 5:44 ` [for-6.0 v5 12/13] securable guest memory: Alter virtio default properties for protected guests David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-04 8:10 ` Christian Borntraeger 2020-12-04 8:10 ` Christian Borntraeger 2020-12-04 8:17 ` Cornelia Huck 2020-12-04 8:17 ` Cornelia Huck 2020-12-04 8:29 ` Christian Borntraeger 2020-12-04 8:29 ` Christian Borntraeger 2020-12-04 14:43 ` Halil Pasic 2020-12-04 14:43 ` Halil Pasic 2020-12-08 1:54 ` David Gibson [this message] 2020-12-08 1:54 ` David Gibson 2020-12-08 8:16 ` Christian Borntraeger 2020-12-08 8:16 ` Christian Borntraeger 2020-12-08 10:28 ` Halil Pasic 2020-12-08 10:28 ` Halil Pasic 2020-12-08 12:50 ` Cornelia Huck 2020-12-08 12:50 ` Cornelia Huck 2020-12-17 5:53 ` David Gibson 2020-12-17 5:53 ` David Gibson 2020-12-04 17:04 ` Cornelia Huck 2020-12-04 17:04 ` Cornelia Huck 2020-12-04 5:44 ` [for-6.0 v5 13/13] s390: Recognize securable-guest-memory option David Gibson 2020-12-04 5:44 ` David Gibson 2020-12-15 11:45 ` Cornelia Huck 2020-12-15 11:45 ` Cornelia Huck 2020-12-17 5:54 ` David Gibson 2020-12-17 5:54 ` David Gibson 2020-12-04 8:06 ` [for-6.0 v5 00/13] Generalize memory encryption models Christian Borntraeger 2020-12-04 8:06 ` Christian Borntraeger 2020-12-04 13:02 ` Cornelia Huck 2020-12-04 13:02 ` Cornelia Huck 2020-12-04 13:07 ` Dr. David Alan Gilbert 2020-12-04 13:07 ` Dr. David Alan Gilbert 2020-12-04 13:12 ` Cornelia Huck 2020-12-04 13:12 ` Cornelia Huck 2020-12-08 2:57 ` David Gibson 2020-12-08 2:57 ` David Gibson 2020-12-08 12:43 ` Cornelia Huck 2020-12-08 12:43 ` Cornelia Huck 2020-12-17 6:21 ` David Gibson 2020-12-17 6:21 ` David Gibson 2020-12-17 11:43 ` Cornelia Huck 2020-12-17 11:43 ` Cornelia Huck 2020-12-04 13:25 ` Daniel P. Berrangé 2020-12-04 13:25 ` Daniel P. Berrangé 2020-12-04 13:51 ` Halil Pasic 2020-12-04 13:51 ` Halil Pasic 2020-12-08 2:54 ` David Gibson 2020-12-08 2:54 ` David Gibson 2020-12-04 9:50 ` Daniel P. Berrangé 2020-12-04 9:50 ` Daniel P. Berrangé 2021-01-12 3:02 ` David Gibson 2021-01-12 3:02 ` David Gibson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201208015403.GB2555@yekko.fritz.box \ --to=david@gibson.dropbear.id.au \ --cc=berrange@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=brijesh.singh@amd.com \ --cc=cohuck@redhat.com \ --cc=david@redhat.com \ --cc=dgilbert@redhat.com \ --cc=ehabkost@redhat.com \ --cc=frankja@linux.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=mdroth@linux.vnet.ibm.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pair@us.ibm.com \ --cc=pasic@linux.ibm.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=qemu-s390x@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=rth@twiddle.net \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.