From: Jacopo Mondi <jacopo@jmondi.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 2/9] drm: rcar-du: Release vsp device reference in all error paths
Date: Mon, 14 Dec 2020 11:03:15 +0100 [thread overview]
Message-ID: <20201214100315.jxcfeq6lilpugt2v@uno.localdomain> (raw)
In-Reply-To: <20201204220139.15272-3-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On Sat, Dec 05, 2020 at 12:01:32AM +0200, Laurent Pinchart wrote:
> Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure
> the vsp device reference is released in case the function call fails.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Just in case... better safe than sorry
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> index f6a69aa116e6..4dcb1bfbe201 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> @@ -364,7 +364,7 @@ int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np,
>
> vsp->vsp = &pdev->dev;
>
> - ret = drmm_add_action(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
> + ret = drmm_add_action_or_reset(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
> if (ret < 0)
> return ret;
>
> --
> Regards,
>
> Laurent Pinchart
>
WARNING: multiple messages have this Message-ID (diff)
From: Jacopo Mondi <jacopo@jmondi.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/9] drm: rcar-du: Release vsp device reference in all error paths
Date: Mon, 14 Dec 2020 11:03:15 +0100 [thread overview]
Message-ID: <20201214100315.jxcfeq6lilpugt2v@uno.localdomain> (raw)
In-Reply-To: <20201204220139.15272-3-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
On Sat, Dec 05, 2020 at 12:01:32AM +0200, Laurent Pinchart wrote:
> Use drmm_add_action_or_reset() instead of drmm_add_action() to ensure
> the vsp device reference is released in case the function call fails.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Just in case... better safe than sorry
Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> index f6a69aa116e6..4dcb1bfbe201 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> @@ -364,7 +364,7 @@ int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np,
>
> vsp->vsp = &pdev->dev;
>
> - ret = drmm_add_action(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
> + ret = drmm_add_action_or_reset(rcdu->ddev, rcar_du_vsp_cleanup, vsp);
> if (ret < 0)
> return ret;
>
> --
> Regards,
>
> Laurent Pinchart
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-14 10:04 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 22:01 [PATCH 0/9] drm: rcar-du: Fix LVDS-related crash Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-04 22:01 ` [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-07 8:15 ` Geert Uytterhoeven
2020-12-07 8:15 ` Geert Uytterhoeven
2020-12-08 0:42 ` Laurent Pinchart
2020-12-08 0:42 ` Laurent Pinchart
2020-12-14 9:43 ` Jacopo Mondi
2020-12-14 9:43 ` Jacopo Mondi
2020-12-14 15:36 ` Kieran Bingham
2020-12-14 15:36 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 2/9] drm: rcar-du: Release vsp device reference in all error paths Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:03 ` Jacopo Mondi [this message]
2020-12-14 10:03 ` Jacopo Mondi
2020-12-14 15:42 ` Kieran Bingham
2020-12-14 15:42 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:11 ` Jacopo Mondi
2020-12-14 10:11 ` Jacopo Mondi
2020-12-14 13:19 ` Laurent Pinchart
2020-12-14 13:19 ` Laurent Pinchart
2020-12-14 15:59 ` Kieran Bingham
2020-12-14 15:59 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 16:20 ` Kieran Bingham
2020-12-14 16:20 ` Kieran Bingham
2020-12-14 16:26 ` Laurent Pinchart
2020-12-14 16:26 ` Laurent Pinchart
2020-12-15 15:42 ` Geert Uytterhoeven
2020-12-15 15:42 ` Geert Uytterhoeven
2020-12-04 22:01 ` [PATCH 5/9] drm: rcar-du: Use DRM-managed allocation for encoders Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:37 ` Jacopo Mondi
2020-12-14 10:37 ` Jacopo Mondi
2020-12-14 13:28 ` Laurent Pinchart
2020-12-14 13:28 ` Laurent Pinchart
2020-12-04 22:01 ` [PATCH 6/9] drm: rcar-du: Embed drm_device in rcar_du_device Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:55 ` Jacopo Mondi
2020-12-14 10:55 ` Jacopo Mondi
2020-12-14 17:02 ` Kieran Bingham
2020-12-14 17:02 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 7/9] drm: rcar-du: Replace dev_private with container_of Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:58 ` Jacopo Mondi
2020-12-14 10:58 ` Jacopo Mondi
2020-12-14 17:11 ` Kieran Bingham
2020-12-14 17:11 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 11:04 ` Jacopo Mondi
2020-12-14 11:04 ` Jacopo Mondi
2020-12-14 13:32 ` Laurent Pinchart
2020-12-14 13:32 ` Laurent Pinchart
2020-12-14 17:21 ` Kieran Bingham
2020-12-14 17:21 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 9/9] drm: rcar-du: Drop local encoder variable Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 11:05 ` Jacopo Mondi
2020-12-14 11:05 ` Jacopo Mondi
2020-12-14 17:16 ` Kieran Bingham
2020-12-14 17:16 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214100315.jxcfeq6lilpugt2v@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.