From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC
Date: Tue, 8 Dec 2020 02:42:57 +0200 [thread overview]
Message-ID: <X87MEVMhOgcFxKwj@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdXrEpnQNT=QZRrgQ-jzBvRumUHgqfBrgCHcELpxg7VnQA@mail.gmail.com>
Geert,
On Mon, Dec 07, 2020 at 09:15:11AM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 4, 2020 at 11:02 PM Laurent Pinchart wrote:
> > On D3 and E3 platforms, the LVDS encoder includes a PLL that can
> > generate a clock for the corresponding CRTC, used even when the CRTC
> > output to a non-LVDS port. This mechanism is supported by the driver,
> > but the implementation is broken in dual-link LVDS mode. In that case,
> > the LVDS1 drm_encoder is skipped, which causes a crash when trying to
> > access its bridge later on.
> >
> > Fix this by storing bridge pointers internally instead of retrieving
> > them from the encoder.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Thanks for your patch!
>
> I think this warrants a Fixes tag, to assist the stable team in backporting
> this fix.
I'll add one.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC
Date: Tue, 8 Dec 2020 02:42:57 +0200 [thread overview]
Message-ID: <X87MEVMhOgcFxKwj@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdXrEpnQNT=QZRrgQ-jzBvRumUHgqfBrgCHcELpxg7VnQA@mail.gmail.com>
Geert,
On Mon, Dec 07, 2020 at 09:15:11AM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 4, 2020 at 11:02 PM Laurent Pinchart wrote:
> > On D3 and E3 platforms, the LVDS encoder includes a PLL that can
> > generate a clock for the corresponding CRTC, used even when the CRTC
> > output to a non-LVDS port. This mechanism is supported by the driver,
> > but the implementation is broken in dual-link LVDS mode. In that case,
> > the LVDS1 drm_encoder is skipped, which causes a crash when trying to
> > access its bridge later on.
> >
> > Fix this by storing bridge pointers internally instead of retrieving
> > them from the encoder.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Thanks for your patch!
>
> I think this warrants a Fixes tag, to assist the stable team in backporting
> this fix.
I'll add one.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-08 0:44 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 22:01 [PATCH 0/9] drm: rcar-du: Fix LVDS-related crash Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-04 22:01 ` [PATCH 1/9] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-07 8:15 ` Geert Uytterhoeven
2020-12-07 8:15 ` Geert Uytterhoeven
2020-12-08 0:42 ` Laurent Pinchart [this message]
2020-12-08 0:42 ` Laurent Pinchart
2020-12-14 9:43 ` Jacopo Mondi
2020-12-14 9:43 ` Jacopo Mondi
2020-12-14 15:36 ` Kieran Bingham
2020-12-14 15:36 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 2/9] drm: rcar-du: Release vsp device reference in all error paths Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:03 ` Jacopo Mondi
2020-12-14 10:03 ` Jacopo Mondi
2020-12-14 15:42 ` Kieran Bingham
2020-12-14 15:42 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:11 ` Jacopo Mondi
2020-12-14 10:11 ` Jacopo Mondi
2020-12-14 13:19 ` Laurent Pinchart
2020-12-14 13:19 ` Laurent Pinchart
2020-12-14 15:59 ` Kieran Bingham
2020-12-14 15:59 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 4/9] drm: rcar-du: Use DRM-managed allocation for VSP planes Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 16:20 ` Kieran Bingham
2020-12-14 16:20 ` Kieran Bingham
2020-12-14 16:26 ` Laurent Pinchart
2020-12-14 16:26 ` Laurent Pinchart
2020-12-15 15:42 ` Geert Uytterhoeven
2020-12-15 15:42 ` Geert Uytterhoeven
2020-12-04 22:01 ` [PATCH 5/9] drm: rcar-du: Use DRM-managed allocation for encoders Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:37 ` Jacopo Mondi
2020-12-14 10:37 ` Jacopo Mondi
2020-12-14 13:28 ` Laurent Pinchart
2020-12-14 13:28 ` Laurent Pinchart
2020-12-04 22:01 ` [PATCH 6/9] drm: rcar-du: Embed drm_device in rcar_du_device Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:55 ` Jacopo Mondi
2020-12-14 10:55 ` Jacopo Mondi
2020-12-14 17:02 ` Kieran Bingham
2020-12-14 17:02 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 7/9] drm: rcar-du: Replace dev_private with container_of Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 10:58 ` Jacopo Mondi
2020-12-14 10:58 ` Jacopo Mondi
2020-12-14 17:11 ` Kieran Bingham
2020-12-14 17:11 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 8/9] drm: rcar-du: Skip encoder allocation for LVDS1 in dual-link mode Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 11:04 ` Jacopo Mondi
2020-12-14 11:04 ` Jacopo Mondi
2020-12-14 13:32 ` Laurent Pinchart
2020-12-14 13:32 ` Laurent Pinchart
2020-12-14 17:21 ` Kieran Bingham
2020-12-14 17:21 ` Kieran Bingham
2020-12-04 22:01 ` [PATCH 9/9] drm: rcar-du: Drop local encoder variable Laurent Pinchart
2020-12-04 22:01 ` Laurent Pinchart
2020-12-14 11:05 ` Jacopo Mondi
2020-12-14 11:05 ` Jacopo Mondi
2020-12-14 17:16 ` Kieran Bingham
2020-12-14 17:16 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X87MEVMhOgcFxKwj@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.