From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pau Oliva Fora <pof@eslack.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Hannes Reinecke <hare@suse.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Finn Thain <fthain@telegraphics.com.au>,
Michael Schmitz <schmitzmic@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
linux-media@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void
Date: Fri, 22 Jan 2021 08:34:31 +0100 [thread overview]
Message-ID: <20210122073431.a3igyqh3rucmiy5y@hardanger.blackshift.org> (raw)
In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Thu, Jan 21, 2021 at 09:48:12PM +0100, Uwe Kleine-König wrote:
> The driver core ignores the return value of the remove callback, so
> don't give isa drivers the chance to provide a value.
>
> Adapt all isa_drivers with a remove callbacks accordingly; they all
> return 0 unconditionally anyhow.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> drivers/net/can/sja1000/tscan1.c | 4 +---
For the can driver:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: alsa-devel@alsa-project.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-i2c@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-scsi@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Matthew Wilcox <willy@infradead.org>,
linux-input@vger.kernel.org, Pau Oliva Fora <pof@eslack.org>,
Jakub Kicinski <kuba@kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-media@vger.kernel.org, linux-watchdog@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
linux-can@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Finn Thain <fthain@telegraphics.com.au>,
Michael Schmitz <schmitzmic@gmail.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void
Date: Fri, 22 Jan 2021 08:34:31 +0100 [thread overview]
Message-ID: <20210122073431.a3igyqh3rucmiy5y@hardanger.blackshift.org> (raw)
In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Thu, Jan 21, 2021 at 09:48:12PM +0100, Uwe Kleine-König wrote:
> The driver core ignores the return value of the remove callback, so
> don't give isa drivers the chance to provide a value.
>
> Adapt all isa_drivers with a remove callbacks accordingly; they all
> return 0 unconditionally anyhow.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> drivers/net/can/sja1000/tscan1.c | 4 +---
For the can driver:
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-22 7:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 20:48 [PATCH v1 0/2] isa: Make the remove callback for isa drivers return void Uwe Kleine-König
2021-01-21 20:48 ` Uwe Kleine-König
2021-01-21 20:48 ` [PATCH v1 1/2] watchdog: pcwd: drop always-false if from remove callback Uwe Kleine-König
2021-01-21 23:08 ` Guenter Roeck
2021-01-21 20:48 ` [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void Uwe Kleine-König
2021-01-21 20:48 ` Uwe Kleine-König
2021-01-22 3:34 ` kernel test robot
2021-01-22 3:34 ` kernel test robot
2021-01-22 3:48 ` kernel test robot
2021-01-22 3:48 ` kernel test robot
2021-01-22 7:34 ` Marc Kleine-Budde [this message]
2021-01-22 7:34 ` Marc Kleine-Budde
2021-01-22 8:53 ` Wolfram Sang
2021-01-22 8:53 ` Wolfram Sang
2021-01-22 9:01 ` Takashi Iwai
2021-01-22 9:01 ` Takashi Iwai
2021-01-22 1:03 ` [PATCH v1 0/2] " William Breathitt Gray
2021-01-22 1:03 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122073431.a3igyqh3rucmiy5y@hardanger.blackshift.org \
--to=mkl@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=fthain@telegraphics.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=martin.petersen@oracle.com \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pof@eslack.org \
--cc=rafael@kernel.org \
--cc=schmitzmic@gmail.com \
--cc=tiwai@suse.com \
--cc=uwe@kleine-koenig.org \
--cc=vilhelm.gray@gmail.com \
--cc=wg@grandegger.com \
--cc=willy@infradead.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.