All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"William Breathitt Gray" <vilhelm.gray@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Pau Oliva Fora" <pof@eslack.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Wolfgang Grandegger" <wg@grandegger.com>
Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org
Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void
Date: Fri, 22 Jan 2021 11:48:09 +0800	[thread overview]
Message-ID: <202101221123.oU4nULp8-lkp@intel.com> (raw)
In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org>

[-- Attachment #1: Type: text/plain, Size: 3342 bytes --]

Hi "Uwe,

I love your patch! Yet something to improve:

[auto build test ERROR on 5a158981aafa7f29709034b17bd007b15cb29983]

url:    https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235
base:    5a158981aafa7f29709034b17bd007b15cb29983
config: nios2-randconfig-r023-20210121 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0c93d705d2694019f3139d838eb6b48696c4f6dd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235
        git checkout 0c93d705d2694019f3139d838eb6b48696c4f6dd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/radio/radio-terratec.c:143:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     143 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-terratec.c:143:14: note: (near initialization for 'terratec_driver.driver.remove')
   cc1: some warnings being treated as errors


vim +143 drivers/media/radio/radio-terratec.c

32c518364a03d336 Hans Verkuil   2012-01-16  138  
32c518364a03d336 Hans Verkuil   2012-01-16  139  static struct radio_isa_driver terratec_driver = {
32c518364a03d336 Hans Verkuil   2012-01-16  140  	.driver = {
32c518364a03d336 Hans Verkuil   2012-01-16  141  		.match		= radio_isa_match,
32c518364a03d336 Hans Verkuil   2012-01-16  142  		.probe		= radio_isa_probe,
32c518364a03d336 Hans Verkuil   2012-01-16 @143  		.remove		= radio_isa_remove,
32c518364a03d336 Hans Verkuil   2012-01-16  144  		.driver		= {
32c518364a03d336 Hans Verkuil   2012-01-16  145  			.name	= "radio-terratec",
32c518364a03d336 Hans Verkuil   2012-01-16  146  		},
32c518364a03d336 Hans Verkuil   2012-01-16  147  	},
32c518364a03d336 Hans Verkuil   2012-01-16  148  	.io_params = &io,
32c518364a03d336 Hans Verkuil   2012-01-16  149  	.radio_nr_params = &radio_nr,
32c518364a03d336 Hans Verkuil   2012-01-16  150  	.io_ports = terratec_ioports,
32c518364a03d336 Hans Verkuil   2012-01-16  151  	.num_of_io_ports = ARRAY_SIZE(terratec_ioports),
32c518364a03d336 Hans Verkuil   2012-01-16  152  	.region_size = 2,
32c518364a03d336 Hans Verkuil   2012-01-16  153  	.card = "TerraTec ActiveRadio",
32c518364a03d336 Hans Verkuil   2012-01-16  154  	.ops = &terratec_ops,
32c518364a03d336 Hans Verkuil   2012-01-16  155  	.has_stereo = true,
32c518364a03d336 Hans Verkuil   2012-01-16  156  	.max_volume = 10,
^1da177e4c3f4152 Linus Torvalds 2005-04-16  157  };
^1da177e4c3f4152 Linus Torvalds 2005-04-16  158  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25787 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void
Date: Fri, 22 Jan 2021 11:48:09 +0800	[thread overview]
Message-ID: <202101221123.oU4nULp8-lkp@intel.com> (raw)
In-Reply-To: <20210121204812.402589-3-uwe@kleine-koenig.org>

[-- Attachment #1: Type: text/plain, Size: 3403 bytes --]

Hi "Uwe,

I love your patch! Yet something to improve:

[auto build test ERROR on 5a158981aafa7f29709034b17bd007b15cb29983]

url:    https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235
base:    5a158981aafa7f29709034b17bd007b15cb29983
config: nios2-randconfig-r023-20210121 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0c93d705d2694019f3139d838eb6b48696c4f6dd
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Uwe-Kleine-K-nig/isa-Make-the-remove-callback-for-isa-drivers-return-void/20210122-051235
        git checkout 0c93d705d2694019f3139d838eb6b48696c4f6dd
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/radio/radio-terratec.c:143:14: error: initialization of 'void (*)(struct device *, unsigned int)' from incompatible pointer type 'int (*)(struct device *, unsigned int)' [-Werror=incompatible-pointer-types]
     143 |   .remove  = radio_isa_remove,
         |              ^~~~~~~~~~~~~~~~
   drivers/media/radio/radio-terratec.c:143:14: note: (near initialization for 'terratec_driver.driver.remove')
   cc1: some warnings being treated as errors


vim +143 drivers/media/radio/radio-terratec.c

32c518364a03d336 Hans Verkuil   2012-01-16  138  
32c518364a03d336 Hans Verkuil   2012-01-16  139  static struct radio_isa_driver terratec_driver = {
32c518364a03d336 Hans Verkuil   2012-01-16  140  	.driver = {
32c518364a03d336 Hans Verkuil   2012-01-16  141  		.match		= radio_isa_match,
32c518364a03d336 Hans Verkuil   2012-01-16  142  		.probe		= radio_isa_probe,
32c518364a03d336 Hans Verkuil   2012-01-16 @143  		.remove		= radio_isa_remove,
32c518364a03d336 Hans Verkuil   2012-01-16  144  		.driver		= {
32c518364a03d336 Hans Verkuil   2012-01-16  145  			.name	= "radio-terratec",
32c518364a03d336 Hans Verkuil   2012-01-16  146  		},
32c518364a03d336 Hans Verkuil   2012-01-16  147  	},
32c518364a03d336 Hans Verkuil   2012-01-16  148  	.io_params = &io,
32c518364a03d336 Hans Verkuil   2012-01-16  149  	.radio_nr_params = &radio_nr,
32c518364a03d336 Hans Verkuil   2012-01-16  150  	.io_ports = terratec_ioports,
32c518364a03d336 Hans Verkuil   2012-01-16  151  	.num_of_io_ports = ARRAY_SIZE(terratec_ioports),
32c518364a03d336 Hans Verkuil   2012-01-16  152  	.region_size = 2,
32c518364a03d336 Hans Verkuil   2012-01-16  153  	.card = "TerraTec ActiveRadio",
32c518364a03d336 Hans Verkuil   2012-01-16  154  	.ops = &terratec_ops,
32c518364a03d336 Hans Verkuil   2012-01-16  155  	.has_stereo = true,
32c518364a03d336 Hans Verkuil   2012-01-16  156  	.max_volume = 10,
^1da177e4c3f4152 Linus Torvalds 2005-04-16  157  };
^1da177e4c3f4152 Linus Torvalds 2005-04-16  158  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 25787 bytes --]

  parent reply	other threads:[~2021-01-22  3:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 20:48 [PATCH v1 0/2] isa: Make the remove callback for isa drivers return void Uwe Kleine-König
2021-01-21 20:48 ` Uwe Kleine-König
2021-01-21 20:48 ` [PATCH v1 1/2] watchdog: pcwd: drop always-false if from remove callback Uwe Kleine-König
2021-01-21 23:08   ` Guenter Roeck
2021-01-21 20:48 ` [PATCH v1 2/2] isa: Make the remove callback for isa drivers return void Uwe Kleine-König
2021-01-21 20:48   ` Uwe Kleine-König
2021-01-22  3:34   ` kernel test robot
2021-01-22  3:34     ` kernel test robot
2021-01-22  3:48   ` kernel test robot [this message]
2021-01-22  3:48     ` kernel test robot
2021-01-22  7:34   ` Marc Kleine-Budde
2021-01-22  7:34     ` Marc Kleine-Budde
2021-01-22  8:53   ` Wolfram Sang
2021-01-22  8:53     ` Wolfram Sang
2021-01-22  9:01   ` Takashi Iwai
2021-01-22  9:01     ` Takashi Iwai
2021-01-22  1:03 ` [PATCH v1 0/2] " William Breathitt Gray
2021-01-22  1:03   ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202101221123.oU4nULp8-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mchehab@kernel.org \
    --cc=pof@eslack.org \
    --cc=rafael@kernel.org \
    --cc=uwe@kleine-koenig.org \
    --cc=vilhelm.gray@gmail.com \
    --cc=wg@grandegger.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.