All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: yung-chuan.liao@linux.intel.com,
	pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 4/6] soundwire: qcom: start the clock during initialization
Date: Tue, 2 Feb 2021 10:16:38 +0530	[thread overview]
Message-ID: <20210202044638.GK2771@vkoul-mobl> (raw)
In-Reply-To: <bdedf84c-68fd-767d-8b3b-5a6ba03e03d8@linaro.org>

On 01-02-21, 15:50, Srinivas Kandagatla wrote:
> 
> 
> On 01/02/2021 14:21, Vinod Koul wrote:
> > On 29-01-21, 17:32, Srinivas Kandagatla wrote:
> > > Start the clock during initialization.
> > 
> > A detailed log please, which clock..? Also how do older controllers work
> > w/o this clk
> 
> By default this is ON, however depending on that is not really reliable!
> 
> Explicitly enabling this will make things clear when we add clk pause
> feature for this driver!

lets add this in the log please

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com,
	pierre-louis.bossart@linux.intel.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] soundwire: qcom: start the clock during initialization
Date: Tue, 2 Feb 2021 10:16:38 +0530	[thread overview]
Message-ID: <20210202044638.GK2771@vkoul-mobl> (raw)
In-Reply-To: <bdedf84c-68fd-767d-8b3b-5a6ba03e03d8@linaro.org>

On 01-02-21, 15:50, Srinivas Kandagatla wrote:
> 
> 
> On 01/02/2021 14:21, Vinod Koul wrote:
> > On 29-01-21, 17:32, Srinivas Kandagatla wrote:
> > > Start the clock during initialization.
> > 
> > A detailed log please, which clock..? Also how do older controllers work
> > w/o this clk
> 
> By default this is ON, however depending on that is not really reliable!
> 
> Explicitly enabling this will make things clear when we add clk pause
> feature for this driver!

lets add this in the log please

-- 
~Vinod

  reply	other threads:[~2021-02-02  4:47 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-29 17:32 [PATCH 0/6] soundwire: qcom: various improvements Srinivas Kandagatla
2021-01-29 17:32 ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 1/6] soundwire: qcom: add support to missing transport params Srinivas Kandagatla
2021-01-29 17:32   ` Srinivas Kandagatla
2021-01-29 19:20   ` Pierre-Louis Bossart
2021-01-29 19:20     ` Pierre-Louis Bossart
2021-02-01 15:50     ` Srinivas Kandagatla
2021-02-01 15:50       ` Srinivas Kandagatla
2021-02-01 16:33       ` Pierre-Louis Bossart
2021-02-01 16:33         ` Pierre-Louis Bossart
2021-02-01 14:13   ` Vinod Koul
2021-02-01 14:13     ` Vinod Koul
2021-02-01 15:50     ` Srinivas Kandagatla
2021-02-01 15:50       ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 2/6] soundwire: qcom: extract version field Srinivas Kandagatla
2021-01-29 17:32   ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla
2021-01-29 17:32   ` Srinivas Kandagatla
2021-01-29 19:21   ` Pierre-Louis Bossart
2021-01-29 19:21     ` Pierre-Louis Bossart
2021-02-01 14:16   ` Vinod Koul
2021-02-01 14:16     ` Vinod Koul
2021-02-01 15:50     ` Srinivas Kandagatla
2021-02-01 15:50       ` Srinivas Kandagatla
2021-02-02  4:46       ` Vinod Koul
2021-02-02  4:46         ` Vinod Koul
2021-01-29 17:32 ` [PATCH 4/6] soundwire: qcom: start the clock during initialization Srinivas Kandagatla
2021-01-29 17:32   ` Srinivas Kandagatla
2021-02-01 14:21   ` Vinod Koul
2021-02-01 14:21     ` Vinod Koul
2021-02-01 15:50     ` Srinivas Kandagatla
2021-02-01 15:50       ` Srinivas Kandagatla
2021-02-02  4:46       ` Vinod Koul [this message]
2021-02-02  4:46         ` Vinod Koul
2021-01-29 17:32 ` [PATCH 5/6] soundwire: qcom: update register read/write routine Srinivas Kandagatla
2021-01-29 17:32   ` Srinivas Kandagatla
2021-01-29 19:33   ` Pierre-Louis Bossart
2021-01-29 19:33     ` Pierre-Louis Bossart
2021-02-01 15:50     ` Srinivas Kandagatla
2021-02-01 15:50       ` Srinivas Kandagatla
2021-02-01 16:42       ` Pierre-Louis Bossart
2021-02-01 16:42         ` Pierre-Louis Bossart
2021-02-02 10:19         ` Srinivas Kandagatla
2021-02-02 10:19           ` Srinivas Kandagatla
2021-02-02 16:58           ` Pierre-Louis Bossart
2021-02-02 16:58             ` Pierre-Louis Bossart
2021-02-01 14:26   ` Vinod Koul
2021-02-01 14:26     ` Vinod Koul
2021-02-01 15:50     ` Srinivas Kandagatla
2021-02-01 15:50       ` Srinivas Kandagatla
2021-01-29 17:32 ` [PATCH 6/6] soundwire: qcom: add support to new interrupts Srinivas Kandagatla
2021-01-29 17:32   ` Srinivas Kandagatla
2021-01-29 19:38   ` Pierre-Louis Bossart
2021-01-29 19:38     ` Pierre-Louis Bossart
2021-02-01 15:51     ` Srinivas Kandagatla
2021-02-01 15:51       ` Srinivas Kandagatla
2021-02-01 14:31   ` Vinod Koul
2021-02-01 14:31     ` Vinod Koul
2021-02-01 15:51     ` Srinivas Kandagatla
2021-02-01 15:51       ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202044638.GK2771@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.