From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, vkoul@kernel.org Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com Subject: Re: [PATCH 6/6] soundwire: qcom: add support to new interrupts Date: Mon, 1 Feb 2021 15:51:18 +0000 [thread overview] Message-ID: <9707a9b9-1e10-e7bf-aea3-4da164c31ee1@linaro.org> (raw) In-Reply-To: <95d3b143-6ba7-e6eb-4f44-9a8bb05b7fb7@linux.intel.com> On 29/01/2021 19:38, Pierre-Louis Bossart wrote: > > > On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: >> Add support to new interrupts and update irq routine in a way >> to deal with multiple pending interrupts with in a single interrupt! > > I can't parse the wording after 'update irq routine'. > So, basically if we get an interrupt while processing previous one there is a chance that we might miss the new interrupt! This was a bug with existing code, which only showed up with recent Headset Button Tests! > >> + swrm->reg_write(swrm, SWRM_INTERRUPT_CLEAR, intr_sts); >> + swrm->reg_write(swrm, SWRM_INTERRUPT_CLEAR, 0x0); > > what does this second write 0x0 do? Usually interrupts are W1C, and you > didn't have this before. Digging it bit more seems to be an HW work around for one of the issues, recommended by HW team. Will remove it from this patch and add it as separate one with more details! --srini >
WARNING: multiple messages have this Message-ID (diff)
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, vkoul@kernel.org Cc: sanyog.r.kale@intel.com, alsa-devel@alsa-project.org, yung-chuan.liao@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] soundwire: qcom: add support to new interrupts Date: Mon, 1 Feb 2021 15:51:18 +0000 [thread overview] Message-ID: <9707a9b9-1e10-e7bf-aea3-4da164c31ee1@linaro.org> (raw) In-Reply-To: <95d3b143-6ba7-e6eb-4f44-9a8bb05b7fb7@linux.intel.com> On 29/01/2021 19:38, Pierre-Louis Bossart wrote: > > > On 1/29/21 11:32 AM, Srinivas Kandagatla wrote: >> Add support to new interrupts and update irq routine in a way >> to deal with multiple pending interrupts with in a single interrupt! > > I can't parse the wording after 'update irq routine'. > So, basically if we get an interrupt while processing previous one there is a chance that we might miss the new interrupt! This was a bug with existing code, which only showed up with recent Headset Button Tests! > >> + swrm->reg_write(swrm, SWRM_INTERRUPT_CLEAR, intr_sts); >> + swrm->reg_write(swrm, SWRM_INTERRUPT_CLEAR, 0x0); > > what does this second write 0x0 do? Usually interrupts are W1C, and you > didn't have this before. Digging it bit more seems to be an HW work around for one of the issues, recommended by HW team. Will remove it from this patch and add it as separate one with more details! --srini >
next prev parent reply other threads:[~2021-02-01 15:54 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-29 17:32 [PATCH 0/6] soundwire: qcom: various improvements Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-01-29 17:32 ` [PATCH 1/6] soundwire: qcom: add support to missing transport params Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-01-29 19:20 ` Pierre-Louis Bossart 2021-01-29 19:20 ` Pierre-Louis Bossart 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 16:33 ` Pierre-Louis Bossart 2021-02-01 16:33 ` Pierre-Louis Bossart 2021-02-01 14:13 ` Vinod Koul 2021-02-01 14:13 ` Vinod Koul 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 15:50 ` Srinivas Kandagatla 2021-01-29 17:32 ` [PATCH 2/6] soundwire: qcom: extract version field Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-01-29 17:32 ` [PATCH 3/6] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-01-29 19:21 ` Pierre-Louis Bossart 2021-01-29 19:21 ` Pierre-Louis Bossart 2021-02-01 14:16 ` Vinod Koul 2021-02-01 14:16 ` Vinod Koul 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-02 4:46 ` Vinod Koul 2021-02-02 4:46 ` Vinod Koul 2021-01-29 17:32 ` [PATCH 4/6] soundwire: qcom: start the clock during initialization Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-02-01 14:21 ` Vinod Koul 2021-02-01 14:21 ` Vinod Koul 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-02 4:46 ` Vinod Koul 2021-02-02 4:46 ` Vinod Koul 2021-01-29 17:32 ` [PATCH 5/6] soundwire: qcom: update register read/write routine Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-01-29 19:33 ` Pierre-Louis Bossart 2021-01-29 19:33 ` Pierre-Louis Bossart 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 16:42 ` Pierre-Louis Bossart 2021-02-01 16:42 ` Pierre-Louis Bossart 2021-02-02 10:19 ` Srinivas Kandagatla 2021-02-02 10:19 ` Srinivas Kandagatla 2021-02-02 16:58 ` Pierre-Louis Bossart 2021-02-02 16:58 ` Pierre-Louis Bossart 2021-02-01 14:26 ` Vinod Koul 2021-02-01 14:26 ` Vinod Koul 2021-02-01 15:50 ` Srinivas Kandagatla 2021-02-01 15:50 ` Srinivas Kandagatla 2021-01-29 17:32 ` [PATCH 6/6] soundwire: qcom: add support to new interrupts Srinivas Kandagatla 2021-01-29 17:32 ` Srinivas Kandagatla 2021-01-29 19:38 ` Pierre-Louis Bossart 2021-01-29 19:38 ` Pierre-Louis Bossart 2021-02-01 15:51 ` Srinivas Kandagatla [this message] 2021-02-01 15:51 ` Srinivas Kandagatla 2021-02-01 14:31 ` Vinod Koul 2021-02-01 14:31 ` Vinod Koul 2021-02-01 15:51 ` Srinivas Kandagatla 2021-02-01 15:51 ` Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9707a9b9-1e10-e7bf-aea3-4da164c31ee1@linaro.org \ --to=srinivas.kandagatla@linaro.org \ --cc=alsa-devel@alsa-project.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=sanyog.r.kale@intel.com \ --cc=vkoul@kernel.org \ --cc=yung-chuan.liao@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.