From: Keith Busch <kbusch@kernel.org>
To: Yuanyuan Zhong <yzhong@purestorage.com>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq()
Date: Sat, 17 Apr 2021 02:17:35 +0900 [thread overview]
Message-ID: <20210416171735.GA32082@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <CA+AMecG=8TTdsdYtaV=H+hKm2poKYhyh_Tvf0Tc0PZvbVXf_iA@mail.gmail.com>
On Fri, Apr 16, 2021 at 10:12:11AM -0700, Yuanyuan Zhong wrote:
> > if (poll)
> > nvme_execute_rq_polled(req->q, NULL, req, at_head);
> You may need to audit other completion handlers for blk_execute_rq_nowait().
Why? Those callers already provide their own callback that directly get
the error.
> How to get error ret from polled rq?
Please see nvme_end_sync_rq() for that driver's polled handler callback.
It already has the error.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org>
To: Yuanyuan Zhong <yzhong@purestorage.com>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq()
Date: Sat, 17 Apr 2021 02:17:35 +0900 [thread overview]
Message-ID: <20210416171735.GA32082@redsun51.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <CA+AMecG=8TTdsdYtaV=H+hKm2poKYhyh_Tvf0Tc0PZvbVXf_iA@mail.gmail.com>
On Fri, Apr 16, 2021 at 10:12:11AM -0700, Yuanyuan Zhong wrote:
> > if (poll)
> > nvme_execute_rq_polled(req->q, NULL, req, at_head);
> You may need to audit other completion handlers for blk_execute_rq_nowait().
Why? Those callers already provide their own callback that directly get
the error.
> How to get error ret from polled rq?
Please see nvme_end_sync_rq() for that driver's polled handler callback.
It already has the error.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-16 17:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 16:53 [PATCH 1/2] block: return errors from blk_execute_rq() Keith Busch
2021-04-16 16:53 ` Keith Busch
2021-04-16 16:53 ` [PATCH 2/2] nvme: use return value " Keith Busch
2021-04-16 16:53 ` Keith Busch
2021-04-16 17:12 ` Yuanyuan Zhong
2021-04-16 17:12 ` Yuanyuan Zhong
2021-04-16 17:17 ` Keith Busch [this message]
2021-04-16 17:17 ` Keith Busch
2021-04-19 7:16 ` Christoph Hellwig
2021-04-19 7:16 ` Christoph Hellwig
2021-04-19 15:14 ` Keith Busch
2021-04-19 15:14 ` Keith Busch
2021-04-19 17:27 ` Yuanyuan Zhong
2021-04-19 17:27 ` Yuanyuan Zhong
2021-04-19 17:48 ` Keith Busch
2021-04-19 17:48 ` Keith Busch
2021-04-19 18:20 ` Yuanyuan Zhong
2021-04-19 18:20 ` Yuanyuan Zhong
2021-04-18 4:17 ` Chaitanya Kulkarni
2021-04-18 4:17 ` Chaitanya Kulkarni
2021-04-18 4:13 ` [PATCH 1/2] block: return errors " Chaitanya Kulkarni
2021-04-18 4:13 ` Chaitanya Kulkarni
2021-04-17 2:04 [PATCH 2/2] nvme: use return value " Casey Chen
2021-04-17 2:39 ` Keith Busch
2021-04-17 2:39 ` Keith Busch
2021-04-23 21:57 [PATCH 1/2] block: return errors " Keith Busch
2021-04-23 21:58 ` [PATCH 2/2] nvme: use return value " Keith Busch
2021-04-23 21:58 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416171735.GA32082@redsun51.ssa.fujisawa.hgst.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=yzhong@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.