From: Keith Busch <kbusch@kernel.org> To: Yuanyuan Zhong <yzhong@purestorage.com> Cc: Christoph Hellwig <hch@lst.de>, linux-nvme@lists.infradead.org, sagi@grimberg.me, axboe@kernel.dk, linux-block@vger.kernel.org Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq() Date: Mon, 19 Apr 2021 10:48:00 -0700 [thread overview] Message-ID: <20210419174800.GA3130441@dhcp-10-100-145-180.wdc.com> (raw) In-Reply-To: <CA+AMecFXLCm3zsrfGdjT5hW4fvvgDxJxGEZvxOEA0bJT3X11wg@mail.gmail.com> On Mon, Apr 19, 2021 at 10:27:42AM -0700, Yuanyuan Zhong wrote: > On Mon, Apr 19, 2021 at 8:14 AM Keith Busch <kbusch@kernel.org> wrote: > > > > On Mon, Apr 19, 2021 at 09:16:05AM +0200, Christoph Hellwig wrote: > > > On Sat, Apr 17, 2021 at 02:17:35AM +0900, Keith Busch wrote: > > > > On Fri, Apr 16, 2021 at 10:12:11AM -0700, Yuanyuan Zhong wrote: > > > > > > if (poll) > > > > > > nvme_execute_rq_polled(req->q, NULL, req, at_head); > > > > > You may need to audit other completion handlers for blk_execute_rq_nowait(). > > > > > > > > Why? Those callers already provide their own callback that directly get > > > > the error. > > See below clarification. I was wondering whether the way you were going to > propose for nvme_end_sync_rq() would establish new convention for other > blk_execute_rq_nowait() completion handlers implementation. I'm not sure it can be turned into a common pattern. The callbacks are implementation specific. > > > > > > > > > How to get error ret from polled rq? > > > > > > > > Please see nvme_end_sync_rq() for that driver's polled handler callback. > > > > It already has the error. > > > > > > But it never looks at it.. > > > > The question was how to get ret. I didn't mean to imply the example was > > actually using it. :) > > The question was how to let nvme_end_sync_rq() propagate the blk_status_t > error to the ret for __nvme_submit_sync_cmd(). That's part of the problem > here: __nvme_submit_sync_cmd() may return success for a command that > failed submission. --- diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index b57157106cac..a0fb9ad132af 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -949,6 +949,9 @@ static void nvme_end_sync_rq(struct request *rq, blk_status_t error) struct completion *waiting = rq->end_io_data; rq->end_io_data = NULL; + if (error && !nvme_req(rq)->status) + nvme_req(rq)->status = blk_status_to_errno(error); complete(waiting); } --
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <kbusch@kernel.org> To: Yuanyuan Zhong <yzhong@purestorage.com> Cc: Christoph Hellwig <hch@lst.de>, linux-nvme@lists.infradead.org, sagi@grimberg.me, axboe@kernel.dk, linux-block@vger.kernel.org Subject: Re: [PATCH 2/2] nvme: use return value from blk_execute_rq() Date: Mon, 19 Apr 2021 10:48:00 -0700 [thread overview] Message-ID: <20210419174800.GA3130441@dhcp-10-100-145-180.wdc.com> (raw) In-Reply-To: <CA+AMecFXLCm3zsrfGdjT5hW4fvvgDxJxGEZvxOEA0bJT3X11wg@mail.gmail.com> On Mon, Apr 19, 2021 at 10:27:42AM -0700, Yuanyuan Zhong wrote: > On Mon, Apr 19, 2021 at 8:14 AM Keith Busch <kbusch@kernel.org> wrote: > > > > On Mon, Apr 19, 2021 at 09:16:05AM +0200, Christoph Hellwig wrote: > > > On Sat, Apr 17, 2021 at 02:17:35AM +0900, Keith Busch wrote: > > > > On Fri, Apr 16, 2021 at 10:12:11AM -0700, Yuanyuan Zhong wrote: > > > > > > if (poll) > > > > > > nvme_execute_rq_polled(req->q, NULL, req, at_head); > > > > > You may need to audit other completion handlers for blk_execute_rq_nowait(). > > > > > > > > Why? Those callers already provide their own callback that directly get > > > > the error. > > See below clarification. I was wondering whether the way you were going to > propose for nvme_end_sync_rq() would establish new convention for other > blk_execute_rq_nowait() completion handlers implementation. I'm not sure it can be turned into a common pattern. The callbacks are implementation specific. > > > > > > > > > How to get error ret from polled rq? > > > > > > > > Please see nvme_end_sync_rq() for that driver's polled handler callback. > > > > It already has the error. > > > > > > But it never looks at it.. > > > > The question was how to get ret. I didn't mean to imply the example was > > actually using it. :) > > The question was how to let nvme_end_sync_rq() propagate the blk_status_t > error to the ret for __nvme_submit_sync_cmd(). That's part of the problem > here: __nvme_submit_sync_cmd() may return success for a command that > failed submission. --- diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index b57157106cac..a0fb9ad132af 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -949,6 +949,9 @@ static void nvme_end_sync_rq(struct request *rq, blk_status_t error) struct completion *waiting = rq->end_io_data; rq->end_io_data = NULL; + if (error && !nvme_req(rq)->status) + nvme_req(rq)->status = blk_status_to_errno(error); complete(waiting); } -- _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-19 17:48 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-16 16:53 [PATCH 1/2] block: return errors from blk_execute_rq() Keith Busch 2021-04-16 16:53 ` Keith Busch 2021-04-16 16:53 ` [PATCH 2/2] nvme: use return value " Keith Busch 2021-04-16 16:53 ` Keith Busch 2021-04-16 17:12 ` Yuanyuan Zhong 2021-04-16 17:12 ` Yuanyuan Zhong 2021-04-16 17:17 ` Keith Busch 2021-04-16 17:17 ` Keith Busch 2021-04-19 7:16 ` Christoph Hellwig 2021-04-19 7:16 ` Christoph Hellwig 2021-04-19 15:14 ` Keith Busch 2021-04-19 15:14 ` Keith Busch 2021-04-19 17:27 ` Yuanyuan Zhong 2021-04-19 17:27 ` Yuanyuan Zhong 2021-04-19 17:48 ` Keith Busch [this message] 2021-04-19 17:48 ` Keith Busch 2021-04-19 18:20 ` Yuanyuan Zhong 2021-04-19 18:20 ` Yuanyuan Zhong 2021-04-18 4:17 ` Chaitanya Kulkarni 2021-04-18 4:17 ` Chaitanya Kulkarni 2021-04-18 4:13 ` [PATCH 1/2] block: return errors " Chaitanya Kulkarni 2021-04-18 4:13 ` Chaitanya Kulkarni 2021-04-17 2:04 [PATCH 2/2] nvme: use return value " Casey Chen 2021-04-17 2:39 ` Keith Busch 2021-04-17 2:39 ` Keith Busch 2021-04-23 21:57 [PATCH 1/2] block: return errors " Keith Busch 2021-04-23 21:58 ` [PATCH 2/2] nvme: use return value " Keith Busch 2021-04-23 21:58 ` Keith Busch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210419174800.GA3130441@dhcp-10-100-145-180.wdc.com \ --to=kbusch@kernel.org \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ --cc=yzhong@purestorage.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.