From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, kaleshsingh@google.com, npiggin@gmail.com, joel@joelfernandes.org, Christophe Leroy <christophe.leroy@csgroup.eu>, "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> Subject: [PATCH v5 2/9] selftest/mremap_test: Avoid crash with static build Date: Thu, 22 Apr 2021 11:13:16 +0530 [thread overview] Message-ID: <20210422054323.150993-3-aneesh.kumar@linux.ibm.com> (raw) In-Reply-To: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> With a large mmap map size, we can overlap with the text area and using MAP_FIXED results in unmapping that area. Switch to MAP_FIXED_NOREPLACE and handle the EEXIST error. Reviewed-by: Kalesh Singh <kaleshsingh@google.com> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- tools/testing/selftests/vm/mremap_test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c index c9a5461eb786..0624d1bd71b5 100644 --- a/tools/testing/selftests/vm/mremap_test.c +++ b/tools/testing/selftests/vm/mremap_test.c @@ -75,9 +75,10 @@ static void *get_source_mapping(struct config c) retry: addr += c.src_alignment; src_addr = mmap((void *) addr, c.region_size, PROT_READ | PROT_WRITE, - MAP_FIXED | MAP_ANONYMOUS | MAP_SHARED, -1, 0); + MAP_FIXED_NOREPLACE | MAP_ANONYMOUS | MAP_SHARED, + -1, 0); if (src_addr == MAP_FAILED) { - if (errno == EPERM) + if (errno == EPERM || errno == EEXIST) goto retry; goto error; } -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> To: linux-mm@kvack.org, akpm@linux-foundation.org Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>, npiggin@gmail.com, kaleshsingh@google.com, joel@joelfernandes.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v5 2/9] selftest/mremap_test: Avoid crash with static build Date: Thu, 22 Apr 2021 11:13:16 +0530 [thread overview] Message-ID: <20210422054323.150993-3-aneesh.kumar@linux.ibm.com> (raw) In-Reply-To: <20210422054323.150993-1-aneesh.kumar@linux.ibm.com> With a large mmap map size, we can overlap with the text area and using MAP_FIXED results in unmapping that area. Switch to MAP_FIXED_NOREPLACE and handle the EEXIST error. Reviewed-by: Kalesh Singh <kaleshsingh@google.com> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- tools/testing/selftests/vm/mremap_test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/mremap_test.c b/tools/testing/selftests/vm/mremap_test.c index c9a5461eb786..0624d1bd71b5 100644 --- a/tools/testing/selftests/vm/mremap_test.c +++ b/tools/testing/selftests/vm/mremap_test.c @@ -75,9 +75,10 @@ static void *get_source_mapping(struct config c) retry: addr += c.src_alignment; src_addr = mmap((void *) addr, c.region_size, PROT_READ | PROT_WRITE, - MAP_FIXED | MAP_ANONYMOUS | MAP_SHARED, -1, 0); + MAP_FIXED_NOREPLACE | MAP_ANONYMOUS | MAP_SHARED, + -1, 0); if (src_addr == MAP_FAILED) { - if (errno == EPERM) + if (errno == EPERM || errno == EEXIST) goto retry; goto error; } -- 2.30.2
next prev parent reply other threads:[~2021-04-22 5:43 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-22 5:43 [PATCH v5 0/9] Speedup mremap on ppc64 Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-04-22 5:43 ` [PATCH v5 1/9] selftest/mremap_test: Update the test to handle pagesize other than 4K Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V [this message] 2021-04-22 5:43 ` [PATCH v5 2/9] selftest/mremap_test: Avoid crash with static build Aneesh Kumar K.V 2021-04-22 5:43 ` [PATCH v5 3/9] mm/mremap: Use pmd/pud_poplulate to update page table entries Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-05-18 20:04 ` Nathan Chancellor 2021-05-18 20:04 ` Nathan Chancellor 2021-05-19 4:46 ` Aneesh Kumar K.V 2021-05-19 4:46 ` Aneesh Kumar K.V 2021-05-19 18:02 ` Nathan Chancellor 2021-05-19 18:02 ` Nathan Chancellor 2021-05-20 2:18 ` Peter Xu 2021-05-20 2:18 ` Peter Xu 2021-05-20 8:26 ` Aneesh Kumar K.V 2021-05-20 8:26 ` Aneesh Kumar K.V 2021-05-20 12:46 ` Peter Xu 2021-05-20 12:46 ` Peter Xu 2021-05-20 13:23 ` Aneesh Kumar K.V 2021-05-20 13:23 ` Aneesh Kumar K.V 2021-05-20 13:37 ` Aneesh Kumar K.V 2021-05-20 13:37 ` Aneesh Kumar K.V 2021-05-20 14:57 ` Peter Xu 2021-05-20 14:57 ` Peter Xu 2021-05-20 19:06 ` Zi Yan 2021-05-20 19:06 ` Zi Yan 2021-05-20 20:01 ` Peter Xu 2021-05-20 20:01 ` Peter Xu 2021-05-20 20:25 ` Kalesh Singh 2021-05-20 20:25 ` Kalesh Singh 2021-04-22 5:43 ` [PATCH v5 4/9] powerpc/mm/book3s64: Fix possible build error Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-04-22 5:43 ` [PATCH v5 5/9] powerpc/mm/book3s64: Update tlb flush routines to take a page walk cache flush argument Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-05-15 16:35 ` Guenter Roeck 2021-05-15 16:35 ` Guenter Roeck 2021-05-15 20:41 ` Andrew Morton 2021-05-15 20:41 ` Andrew Morton 2021-05-15 23:05 ` Guenter Roeck 2021-05-15 23:05 ` Guenter Roeck 2021-05-17 8:40 ` Aneesh Kumar K.V 2021-05-17 8:40 ` Aneesh Kumar K.V 2021-05-17 13:38 ` Guenter Roeck 2021-05-17 13:38 ` Guenter Roeck 2021-05-17 13:55 ` Aneesh Kumar K.V 2021-05-17 13:55 ` Aneesh Kumar K.V 2021-05-17 14:18 ` Guenter Roeck 2021-05-17 14:18 ` Guenter Roeck 2021-05-19 0:26 ` Michael Ellerman 2021-05-19 0:26 ` Michael Ellerman 2021-05-19 0:45 ` Segher Boessenkool 2021-05-19 0:45 ` Segher Boessenkool 2021-05-19 12:03 ` Segher Boessenkool 2021-05-19 13:37 ` Guenter Roeck 2021-05-19 14:20 ` Segher Boessenkool 2021-05-19 14:20 ` Segher Boessenkool 2021-05-19 15:28 ` Guenter Roeck 2021-05-19 15:28 ` Guenter Roeck 2021-05-20 7:37 ` Michael Ellerman 2021-05-20 12:17 ` Segher Boessenkool 2021-05-19 1:08 ` Guenter Roeck 2021-05-19 1:08 ` Guenter Roeck 2021-05-20 11:38 ` Michael Ellerman 2021-05-20 11:38 ` Michael Ellerman 2021-05-20 11:56 ` Guenter Roeck 2021-05-20 11:56 ` Guenter Roeck 2021-04-22 5:43 ` [PATCH v5 6/9] mm/mremap: Use range flush that does TLB and page walk cache flush Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-04-22 5:43 ` [PATCH v5 7/9] mm/mremap: Move TLB flush outside page table lock Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-05-20 15:26 ` Aneesh Kumar K.V 2021-05-20 15:26 ` Aneesh Kumar K.V 2021-05-20 16:57 ` Aneesh Kumar K.V 2021-05-20 16:57 ` Aneesh Kumar K.V 2021-05-21 2:40 ` Linus Torvalds 2021-05-21 2:40 ` Linus Torvalds 2021-05-21 3:03 ` Aneesh Kumar K.V 2021-05-21 3:03 ` Aneesh Kumar K.V 2021-05-21 3:28 ` Aneesh Kumar K.V 2021-05-21 3:28 ` Aneesh Kumar K.V 2021-05-21 6:13 ` Linus Torvalds 2021-05-21 6:13 ` Linus Torvalds 2021-05-21 12:50 ` Aneesh Kumar K.V 2021-05-21 12:50 ` Aneesh Kumar K.V 2021-05-21 13:03 ` Aneesh Kumar K.V 2021-05-21 13:03 ` Aneesh Kumar K.V 2021-05-21 16:03 ` Linus Torvalds 2021-05-21 16:03 ` Linus Torvalds 2021-05-21 16:29 ` Aneesh Kumar K.V 2021-05-21 16:29 ` Aneesh Kumar K.V 2021-05-24 14:24 ` Aneesh Kumar K.V 2021-05-24 14:24 ` Aneesh Kumar K.V 2021-05-21 15:24 ` Liam Howlett 2021-05-21 15:24 ` Liam Howlett 2021-05-21 16:02 ` Aneesh Kumar K.V 2021-05-21 16:02 ` Aneesh Kumar K.V 2021-05-21 16:05 ` Linus Torvalds 2021-05-21 16:05 ` Linus Torvalds 2021-04-22 5:43 ` [PATCH v5 8/9] mm/mremap: Allow arch runtime override Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-04-22 5:43 ` [PATCH v5 9/9] powerpc/mm: Enable move pmd/pud Aneesh Kumar K.V 2021-04-22 5:43 ` Aneesh Kumar K.V 2021-05-11 22:19 ` Andrew Morton 2021-05-11 22:19 ` Andrew Morton
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210422054323.150993-3-aneesh.kumar@linux.ibm.com \ --to=aneesh.kumar@linux.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=christophe.leroy@csgroup.eu \ --cc=joel@joelfernandes.org \ --cc=kaleshsingh@google.com \ --cc=linux-mm@kvack.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=npiggin@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.