[PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Jon Lin <jon.lin@rock-chips.com>
To: broonie@kernel.org
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@esmil.dk, Jon Lin <jon.lin@rock-chips.com>
Subject: [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Fri, 23 Apr 2021 16:47:48 +0800	[thread overview]
Message-ID: <20210423084750.18533-1-jon.lin@rock-chips.com> (raw)
In-Reply-To: <20210423084155.17439-1-jon.lin@rock-chips.com>

The error here is to calculate the width as 8 bits. In fact, 16 bits
should be considered.

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---
 drivers/spi/spi-rockchip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index cfcbfd6c1be5..c245af1692c7 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -547,8 +547,8 @@ static int rockchip_spi_config(struct rockchip_spi *rs,
 	 * interrupt exactly when the fifo is full doesn't seem to work,
 	 * so we need the strict inequality here
 	 */
-	if (xfer->len < rs->fifo_len)
-		writel_relaxed(xfer->len - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
+	if ((xfer->len / rs->n_bytes) < rs->fifo_len)
+		writel_relaxed(xfer->len / rs->n_bytes - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
 	else
 		writel_relaxed(rs->fifo_len / 2 - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
 
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)

From: Jon Lin <jon.lin@rock-chips.com>
To: broonie@kernel.org
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@esmil.dk, Jon Lin <jon.lin@rock-chips.com>
Subject: [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Fri, 23 Apr 2021 16:47:48 +0800	[thread overview]
Message-ID: <20210423084750.18533-1-jon.lin@rock-chips.com> (raw)
In-Reply-To: <20210423084155.17439-1-jon.lin@rock-chips.com>

The error here is to calculate the width as 8 bits. In fact, 16 bits
should be considered.

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---
 drivers/spi/spi-rockchip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index cfcbfd6c1be5..c245af1692c7 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -547,8 +547,8 @@ static int rockchip_spi_config(struct rockchip_spi *rs,
 	 * interrupt exactly when the fifo is full doesn't seem to work,
 	 * so we need the strict inequality here
 	 */
-	if (xfer->len < rs->fifo_len)
-		writel_relaxed(xfer->len - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
+	if ((xfer->len / rs->n_bytes) < rs->fifo_len)
+		writel_relaxed(xfer->len / rs->n_bytes - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
 	else
 		writel_relaxed(rs->fifo_len / 2 - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
 
-- 
2.17.1




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)

From: Jon Lin <jon.lin@rock-chips.com>
To: broonie@kernel.org
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel@esmil.dk, Jon Lin <jon.lin@rock-chips.com>
Subject: [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Fri, 23 Apr 2021 16:47:48 +0800	[thread overview]
Message-ID: <20210423084750.18533-1-jon.lin@rock-chips.com> (raw)
In-Reply-To: <20210423084155.17439-1-jon.lin@rock-chips.com>

The error here is to calculate the width as 8 bits. In fact, 16 bits
should be considered.

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---
 drivers/spi/spi-rockchip.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index cfcbfd6c1be5..c245af1692c7 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -547,8 +547,8 @@ static int rockchip_spi_config(struct rockchip_spi *rs,
 	 * interrupt exactly when the fifo is full doesn't seem to work,
 	 * so we need the strict inequality here
 	 */
-	if (xfer->len < rs->fifo_len)
-		writel_relaxed(xfer->len - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
+	if ((xfer->len / rs->n_bytes) < rs->fifo_len)
+		writel_relaxed(xfer->len / rs->n_bytes - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
 	else
 		writel_relaxed(rs->fifo_len / 2 - 1, rs->regs + ROCKCHIP_SPI_RXFTLR);
 
-- 
2.17.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2021-04-23  8:48 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  8:41 [PATCH v1 1/8] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-04-23  8:41 ` Jon Lin
2021-04-23  8:41 ` Jon Lin
2021-04-23  8:41 ` [PATCH v1 2/8] spi: rockchip: add compatible string " Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  9:00   ` Heiko Stübner
2021-04-23  9:00     ` Heiko Stübner
2021-04-23  9:00     ` Heiko Stübner
2021-04-23  8:41 ` [PATCH v1 3/8] spi: rockchip: Support cs-gpio Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:41 ` [PATCH v1 4/8] dt-bindings: spi: spi-rockchip: add description for rk3568 Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:41 ` [PATCH v1 5/8] spi: rockchip: Add compatible string " Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:41   ` Jon Lin
2021-04-23  8:47 ` Jon Lin [this message]
2021-04-23  8:47   ` [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-04-23  8:47   ` Jon Lin
2021-04-23  8:47   ` [PATCH v1 7/8] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
2021-04-23  8:47     ` Jon Lin
2021-04-23  8:47     ` Jon Lin
2021-04-23  8:47   ` [PATCH v1 8/8] spi: rockchip: Support SPI_CS_HIGH Jon Lin
2021-04-23  8:47     ` Jon Lin
2021-04-23  8:47     ` Jon Lin
2021-04-23 12:18   ` [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Mark Brown
2021-04-23 12:18     ` Mark Brown
2021-04-23 12:18     ` Mark Brown

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:cfcbfd6c1be dfblob:cfcbfd6c1be dfblob:cfcbfd6c1be
dfblob:c245af1692c dfblob:c245af1692c dfblob:c245af1692c
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423084750.18533-1-jon.lin@rock-chips.com \
    --to=jon.lin@rock-chips.com \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=kernel@esmil.dk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.