From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@esmil.dk
Subject: Re: [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Fri, 23 Apr 2021 13:18:57 +0100 [thread overview]
Message-ID: <20210423121857.GC5507@sirena.org.uk> (raw)
In-Reply-To: <20210423084750.18533-1-jon.lin@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
On Fri, Apr 23, 2021 at 04:47:48PM +0800, Jon Lin wrote:
> The error here is to calculate the width as 8 bits. In fact, 16 bits
> should be considered.
Bugfix patches like this should go at the start of a series so they can
be sent as fixes without any dependencies on earlier patches.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@esmil.dk
Subject: Re: [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Fri, 23 Apr 2021 13:18:57 +0100 [thread overview]
Message-ID: <20210423121857.GC5507@sirena.org.uk> (raw)
In-Reply-To: <20210423084750.18533-1-jon.lin@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 287 bytes --]
On Fri, Apr 23, 2021 at 04:47:48PM +0800, Jon Lin wrote:
> The error here is to calculate the width as 8 bits. In fact, 16 bits
> should be considered.
Bugfix patches like this should go at the start of a series so they can
be sent as fixes without any dependencies on earlier patches.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: heiko@sntech.de, linux-spi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@esmil.dk
Subject: Re: [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item
Date: Fri, 23 Apr 2021 13:18:57 +0100 [thread overview]
Message-ID: <20210423121857.GC5507@sirena.org.uk> (raw)
In-Reply-To: <20210423084750.18533-1-jon.lin@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 287 bytes --]
On Fri, Apr 23, 2021 at 04:47:48PM +0800, Jon Lin wrote:
> The error here is to calculate the width as 8 bits. In fact, 16 bits
> should be considered.
Bugfix patches like this should go at the start of a series so they can
be sent as fixes without any dependencies on earlier patches.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-23 12:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 8:41 [PATCH v1 1/8] dt-bindings: spi: spi-rockchip: add description for rv1126 Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` [PATCH v1 2/8] spi: rockchip: add compatible string " Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 9:00 ` Heiko Stübner
2021-04-23 9:00 ` Heiko Stübner
2021-04-23 9:00 ` Heiko Stübner
2021-04-23 8:41 ` [PATCH v1 3/8] spi: rockchip: Support cs-gpio Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` [PATCH v1 4/8] dt-bindings: spi: spi-rockchip: add description for rk3568 Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` [PATCH v1 5/8] spi: rockchip: Add compatible string " Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:41 ` Jon Lin
2021-04-23 8:47 ` [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Jon Lin
2021-04-23 8:47 ` Jon Lin
2021-04-23 8:47 ` Jon Lin
2021-04-23 8:47 ` [PATCH v1 7/8] spi: rockchip: Wait for STB status in slave mode tx_xfer Jon Lin
2021-04-23 8:47 ` Jon Lin
2021-04-23 8:47 ` Jon Lin
2021-04-23 8:47 ` [PATCH v1 8/8] spi: rockchip: Support SPI_CS_HIGH Jon Lin
2021-04-23 8:47 ` Jon Lin
2021-04-23 8:47 ` Jon Lin
2021-04-23 12:18 ` Mark Brown [this message]
2021-04-23 12:18 ` [PATCH v1 6/8] spi: rockchip: Set rx_fifo interrupt waterline base on transfer item Mark Brown
2021-04-23 12:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423121857.GC5507@sirena.org.uk \
--to=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.