All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc()
Date: Wed, 19 May 2021 10:48:45 +0100	[thread overview]
Message-ID: <20210519094845.GB21501@arm.com> (raw)
In-Reply-To: <97b515ea-3daa-5252-ca6b-1acacb0e5ade@arm.com>

On Friday 14 May 2021 at 18:17:00 (+0200), Dietmar Eggemann wrote:
> On 14/05/2021 11:53, Ionela Voinescu wrote:
> 
> [...]
> 
> > +#ifdef CONFIG_ACPI_CPPC_LIB
> > +#define arch_init_invariance_cppc init_cpu_capacity_cppc
> > +#endif
> 
> The prefix `topology_` was meant to indicate that those functions come
> from drivers/base/arch_topology.c. You probably refrained from it since
> 
> topology_init_cpu_capacity_cppc()
> 
> is a pretty long function name ... Still more consistent though.
> 

I'll rename it, thanks!

Ionela.

> [...]
> 

WARNING: multiple messages have this Message-ID (diff)
From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Giovanni Gherdovich <ggherdovich@suse.cz>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Valentin Schneider <valentin.schneider@arm.com>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc()
Date: Wed, 19 May 2021 10:48:45 +0100	[thread overview]
Message-ID: <20210519094845.GB21501@arm.com> (raw)
In-Reply-To: <97b515ea-3daa-5252-ca6b-1acacb0e5ade@arm.com>

On Friday 14 May 2021 at 18:17:00 (+0200), Dietmar Eggemann wrote:
> On 14/05/2021 11:53, Ionela Voinescu wrote:
> 
> [...]
> 
> > +#ifdef CONFIG_ACPI_CPPC_LIB
> > +#define arch_init_invariance_cppc init_cpu_capacity_cppc
> > +#endif
> 
> The prefix `topology_` was meant to indicate that those functions come
> from drivers/base/arch_topology.c. You probably refrained from it since
> 
> topology_init_cpu_capacity_cppc()
> 
> is a pretty long function name ... Still more consistent though.
> 

I'll rename it, thanks!

Ionela.

> [...]
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-19  9:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14  9:53 [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Ionela Voinescu
2021-05-14  9:53 ` Ionela Voinescu
2021-05-14  9:53 ` [PATCH 1/3] x86, ACPI: rename init_freq_invariance_cppc to arch_init_invariance_cppc Ionela Voinescu
2021-05-14  9:53   ` Ionela Voinescu
2021-05-14  9:53 ` [PATCH 2/3] arch_topology: obtain cpu capacity using information from CPPC Ionela Voinescu
2021-05-14  9:53   ` Ionela Voinescu
2021-05-14 16:16   ` Dietmar Eggemann
2021-05-14 16:16     ` Dietmar Eggemann
2021-05-19  9:46     ` Ionela Voinescu
2021-05-19  9:46       ` Ionela Voinescu
2021-05-18 13:12   ` Valentin Schneider
2021-05-18 13:12     ` Valentin Schneider
2021-05-14  9:53 ` [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc() Ionela Voinescu
2021-05-14  9:53   ` Ionela Voinescu
2021-05-14 10:35   ` Catalin Marinas
2021-05-14 10:35     ` Catalin Marinas
2021-05-14 16:17   ` Dietmar Eggemann
2021-05-14 16:17     ` Dietmar Eggemann
2021-05-19  9:48     ` Ionela Voinescu [this message]
2021-05-19  9:48       ` Ionela Voinescu
2021-05-18 13:12 ` [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Valentin Schneider
2021-05-18 13:12   ` Valentin Schneider
2021-05-19  9:51   ` Ionela Voinescu
2021-05-19  9:51     ` Ionela Voinescu
2021-06-28 13:58 ` [tip: sched/core] sched/debug: Don't update sched_domain debug directories before sched_debug_init() tip-bot2 for Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519094845.GB21501@arm.com \
    --to=ionela.voinescu@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=ggherdovich@suse.cz \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=valentin.schneider@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.