From: Dietmar Eggemann <dietmar.eggemann@arm.com> To: Ionela Voinescu <ionela.voinescu@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Giovanni Gherdovich <ggherdovich@suse.cz>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Valentin Schneider <valentin.schneider@arm.com> Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] arch_topology: obtain cpu capacity using information from CPPC Date: Fri, 14 May 2021 18:16:50 +0200 [thread overview] Message-ID: <3c3f6d32-3560-2c54-beae-36f53d2572e7@arm.com> (raw) In-Reply-To: <20210514095339.12979-3-ionela.voinescu@arm.com> On 14/05/2021 11:53, Ionela Voinescu wrote: [...] > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index c1179edc0f3b..f710d64f125b 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -291,6 +291,45 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) > return !ret; > } > > +#ifdef CONFIG_ACPI_CPPC_LIB > +#include <acpi/cppc_acpi.h> init_cpu_capacity_cppc() shares a lot of functionality with the existing DT/CPUfreq-based approach (topology_parse_cpu_capacity(), register_cpufreq_notifier(), init_cpu_capacity_callback()). It looks like that the different ways of invocation (two steps per cpu vs. one step for all cpus) makes it hard to restructure the code to create more common bits. > +void init_cpu_capacity_cppc(void) > +{ > + struct cppc_perf_caps perf_caps; > + int cpu; > + > + if (likely(acpi_disabled || !acpi_cpc_valid())) likely(acpi_disabled) ? > + return; > + > + raw_capacity = kcalloc(num_possible_cpus(), sizeof(*raw_capacity), > + GFP_KERNEL); > + if (!raw_capacity) > + return; > + > + for_each_possible_cpu(cpu) { > + if (!cppc_get_perf_caps(cpu, &perf_caps)) { > + raw_capacity[cpu] = perf_caps.highest_perf; > + pr_debug("%s: CPU%d cpu_capacity=%u (raw).\n", > + __func__, cpu, raw_capacity[cpu]); There is quite a variety in the layout of the pr_xxx() log messages in this file. Originally the 'cpu_capacity:' was used to indicate that this log is from drivers/base/arch_topology.c. Now the GCC __func__ identifier is used. Maybe this can be aligned better? Especially since the functionality used in the existing DT-driven and now in the new CPPC-driven functionality is quite similar. Debugging is so much easier with consistent log strings. > + } else { > + pr_err("%s: CPU%d missing highest performance.\n", > + __func__, cpu); > + pr_err("%s: fallback to 1024 for all CPUs\n", > + __func__); > + goto exit; > + } > + } > + > + topology_normalize_cpu_scale(); > + schedule_work(&update_topology_flags_work); > + pr_debug("%s: cpu_capacity initialization done\n", __func__); > + > +exit: > + free_raw_capacity(); > +} > +#endif In case a system has CONFIG_ACPI_CPPC_LIB what does this mean for the DT-based approach via `register_cpufreq_notifier()`? Looks like we rely on: 376 static int __init register_cpufreq_notifier(void) ... 385 if (!acpi_disabled || ...) 386 return -EINVAL; to disable the CPUfreq part of the DT/CPUfreq-based approach on an ACPI system. [...]
WARNING: multiple messages have this Message-ID (diff)
From: Dietmar Eggemann <dietmar.eggemann@arm.com> To: Ionela Voinescu <ionela.voinescu@arm.com>, Sudeep Holla <sudeep.holla@arm.com>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Giovanni Gherdovich <ggherdovich@suse.cz>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Valentin Schneider <valentin.schneider@arm.com> Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] arch_topology: obtain cpu capacity using information from CPPC Date: Fri, 14 May 2021 18:16:50 +0200 [thread overview] Message-ID: <3c3f6d32-3560-2c54-beae-36f53d2572e7@arm.com> (raw) In-Reply-To: <20210514095339.12979-3-ionela.voinescu@arm.com> On 14/05/2021 11:53, Ionela Voinescu wrote: [...] > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index c1179edc0f3b..f710d64f125b 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -291,6 +291,45 @@ bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) > return !ret; > } > > +#ifdef CONFIG_ACPI_CPPC_LIB > +#include <acpi/cppc_acpi.h> init_cpu_capacity_cppc() shares a lot of functionality with the existing DT/CPUfreq-based approach (topology_parse_cpu_capacity(), register_cpufreq_notifier(), init_cpu_capacity_callback()). It looks like that the different ways of invocation (two steps per cpu vs. one step for all cpus) makes it hard to restructure the code to create more common bits. > +void init_cpu_capacity_cppc(void) > +{ > + struct cppc_perf_caps perf_caps; > + int cpu; > + > + if (likely(acpi_disabled || !acpi_cpc_valid())) likely(acpi_disabled) ? > + return; > + > + raw_capacity = kcalloc(num_possible_cpus(), sizeof(*raw_capacity), > + GFP_KERNEL); > + if (!raw_capacity) > + return; > + > + for_each_possible_cpu(cpu) { > + if (!cppc_get_perf_caps(cpu, &perf_caps)) { > + raw_capacity[cpu] = perf_caps.highest_perf; > + pr_debug("%s: CPU%d cpu_capacity=%u (raw).\n", > + __func__, cpu, raw_capacity[cpu]); There is quite a variety in the layout of the pr_xxx() log messages in this file. Originally the 'cpu_capacity:' was used to indicate that this log is from drivers/base/arch_topology.c. Now the GCC __func__ identifier is used. Maybe this can be aligned better? Especially since the functionality used in the existing DT-driven and now in the new CPPC-driven functionality is quite similar. Debugging is so much easier with consistent log strings. > + } else { > + pr_err("%s: CPU%d missing highest performance.\n", > + __func__, cpu); > + pr_err("%s: fallback to 1024 for all CPUs\n", > + __func__); > + goto exit; > + } > + } > + > + topology_normalize_cpu_scale(); > + schedule_work(&update_topology_flags_work); > + pr_debug("%s: cpu_capacity initialization done\n", __func__); > + > +exit: > + free_raw_capacity(); > +} > +#endif In case a system has CONFIG_ACPI_CPPC_LIB what does this mean for the DT-based approach via `register_cpufreq_notifier()`? Looks like we rely on: 376 static int __init register_cpufreq_notifier(void) ... 385 if (!acpi_disabled || ...) 386 return -EINVAL; to disable the CPUfreq part of the DT/CPUfreq-based approach on an ACPI system. [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-14 16:17 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-14 9:53 [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Ionela Voinescu 2021-05-14 9:53 ` Ionela Voinescu 2021-05-14 9:53 ` [PATCH 1/3] x86, ACPI: rename init_freq_invariance_cppc to arch_init_invariance_cppc Ionela Voinescu 2021-05-14 9:53 ` Ionela Voinescu 2021-05-14 9:53 ` [PATCH 2/3] arch_topology: obtain cpu capacity using information from CPPC Ionela Voinescu 2021-05-14 9:53 ` Ionela Voinescu 2021-05-14 16:16 ` Dietmar Eggemann [this message] 2021-05-14 16:16 ` Dietmar Eggemann 2021-05-19 9:46 ` Ionela Voinescu 2021-05-19 9:46 ` Ionela Voinescu 2021-05-18 13:12 ` Valentin Schneider 2021-05-18 13:12 ` Valentin Schneider 2021-05-14 9:53 ` [PATCH 3/3] arm64, topology: enable use of init_cpu_capacity_cppc() Ionela Voinescu 2021-05-14 9:53 ` Ionela Voinescu 2021-05-14 10:35 ` Catalin Marinas 2021-05-14 10:35 ` Catalin Marinas 2021-05-14 16:17 ` Dietmar Eggemann 2021-05-14 16:17 ` Dietmar Eggemann 2021-05-19 9:48 ` Ionela Voinescu 2021-05-19 9:48 ` Ionela Voinescu 2021-05-18 13:12 ` [PATCH 0/3] arch_topology, ACPI: populate cpu capacity from CPPC Valentin Schneider 2021-05-18 13:12 ` Valentin Schneider 2021-05-19 9:51 ` Ionela Voinescu 2021-05-19 9:51 ` Ionela Voinescu 2021-06-28 13:58 ` [tip: sched/core] sched/debug: Don't update sched_domain debug directories before sched_debug_init() tip-bot2 for Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c3f6d32-3560-2c54-beae-36f53d2572e7@arm.com \ --to=dietmar.eggemann@arm.com \ --cc=catalin.marinas@arm.com \ --cc=ggherdovich@suse.cz \ --cc=ionela.voinescu@arm.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=rjw@rjwysocki.net \ --cc=sudeep.holla@arm.com \ --cc=tglx@linutronix.de \ --cc=valentin.schneider@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.