From: kernel test robot <lkp@intel.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>, amir73il@gmail.com
Cc: kbuild-all@lists.01.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel@collabora.com, "Darrick J . Wong" <djwong@kernel.org>,
Theodore Ts'o <tytso@mit.edu>, Dave Chinner <david@fromorbit.com>,
jack@suse.com, dhowells@redhat.com, khazhy@google.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 07/11] fsnotify: Introduce helpers to send error_events
Date: Sun, 23 May 2021 01:51:30 +0800 [thread overview]
Message-ID: <202105230108.4cRGIqbV-lkp@intel.com> (raw)
In-Reply-To: <20210521024134.1032503-8-krisman@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2075 bytes --]
Hi Gabriel,
I love your patch! Yet something to improve:
[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on linus/master v5.13-rc2]
[cannot apply to ext4/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210522-235132
base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d7ce253b768fa74413424edfa86c7d05de148aac
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210522-235132
git checkout d7ce253b768fa74413424edfa86c7d05de148aac
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from fs/open.c:12:
include/linux/fsnotify.h: In function 'fsnotify_error_event':
>> include/linux/fsnotify.h:323:8: error: 'struct super_block' has no member named 's_fsnotify_marks'
323 | if (sb->s_fsnotify_marks) {
| ^~
vim +323 include/linux/fsnotify.h
319
320 static inline void fsnotify_error_event(struct super_block *sb, struct inode *inode,
321 int error)
322 {
> 323 if (sb->s_fsnotify_marks) {
324 struct fs_error_report report = {
325 .error = error,
326 .inode = inode,
327 };
328 fsnotify(FS_ERROR, &report, FSNOTIFY_EVENT_ERROR, NULL, NULL,
329 sb->s_root->d_inode, 0);
330 }
331 }
332
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7353 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 07/11] fsnotify: Introduce helpers to send error_events
Date: Sun, 23 May 2021 01:51:30 +0800 [thread overview]
Message-ID: <202105230108.4cRGIqbV-lkp@intel.com> (raw)
In-Reply-To: <20210521024134.1032503-8-krisman@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2132 bytes --]
Hi Gabriel,
I love your patch! Yet something to improve:
[auto build test ERROR on ext3/fsnotify]
[also build test ERROR on linus/master v5.13-rc2]
[cannot apply to ext4/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210522-235132
base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d7ce253b768fa74413424edfa86c7d05de148aac
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Gabriel-Krisman-Bertazi/File-system-wide-monitoring/20210522-235132
git checkout d7ce253b768fa74413424edfa86c7d05de148aac
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from fs/open.c:12:
include/linux/fsnotify.h: In function 'fsnotify_error_event':
>> include/linux/fsnotify.h:323:8: error: 'struct super_block' has no member named 's_fsnotify_marks'
323 | if (sb->s_fsnotify_marks) {
| ^~
vim +323 include/linux/fsnotify.h
319
320 static inline void fsnotify_error_event(struct super_block *sb, struct inode *inode,
321 int error)
322 {
> 323 if (sb->s_fsnotify_marks) {
324 struct fs_error_report report = {
325 .error = error,
326 .inode = inode,
327 };
328 fsnotify(FS_ERROR, &report, FSNOTIFY_EVENT_ERROR, NULL, NULL,
329 sb->s_root->d_inode, 0);
330 }
331 }
332
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 7353 bytes --]
next prev parent reply other threads:[~2021-05-22 17:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 2:41 [PATCH 00/11] File system wide monitoring Gabriel Krisman Bertazi
2021-05-21 2:41 ` [PATCH 01/11] fanotify: Fold event size calculation to its own function Gabriel Krisman Bertazi
2021-05-21 2:41 ` [PATCH 02/11] fanotify: Split fsid check from other fid mode checks Gabriel Krisman Bertazi
2021-05-21 8:33 ` Amir Goldstein
2021-05-21 2:41 ` [PATCH 03/11] fanotify: Simplify directory sanity check in DFID_NAME mode Gabriel Krisman Bertazi
2021-05-21 8:37 ` Amir Goldstein
2021-05-21 2:41 ` [PATCH 04/11] fanotify: Expose fanotify_mark Gabriel Krisman Bertazi
2021-05-21 9:06 ` Amir Goldstein
2021-05-21 2:41 ` [PATCH 05/11] inotify: Don't force FS_IN_IGNORED Gabriel Krisman Bertazi
2021-05-21 9:07 ` Amir Goldstein
2021-05-21 2:41 ` [PATCH 06/11] fsnotify: Support FS_ERROR event type Gabriel Krisman Bertazi
2021-05-21 9:13 ` Amir Goldstein
2021-05-21 2:41 ` [PATCH 07/11] fsnotify: Introduce helpers to send error_events Gabriel Krisman Bertazi
2021-05-21 9:32 ` Amir Goldstein
2021-05-22 17:51 ` kernel test robot [this message]
2021-05-22 17:51 ` kernel test robot
2021-05-21 2:41 ` [PATCH 08/11] fanotify: Introduce FAN_ERROR event Gabriel Krisman Bertazi
2021-05-21 11:02 ` Amir Goldstein
2021-05-21 15:02 ` Darrick J. Wong
2021-05-21 2:41 ` [PATCH 09/11] ext4: Send notifications on error Gabriel Krisman Bertazi
2021-05-21 9:44 ` Amir Goldstein
2021-05-21 2:41 ` [PATCH 10/11] samples: Add fs error monitoring example Gabriel Krisman Bertazi
2021-05-21 9:48 ` Amir Goldstein
2021-05-26 23:37 ` Gabriel Krisman Bertazi
2021-05-22 20:21 ` kernel test robot
2021-05-22 20:21 ` kernel test robot
2021-05-21 2:41 ` [PATCH 11/11] Documentation: Document the FAN_ERROR event Gabriel Krisman Bertazi
2021-05-21 9:54 ` Amir Goldstein
2021-05-21 8:31 ` [PATCH 00/11] File system wide monitoring Amir Goldstein
2021-05-22 23:25 ` Theodore Y. Ts'o
2021-05-24 15:19 ` Gabriel Krisman Bertazi
2021-05-24 3:06 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105230108.4cRGIqbV-lkp@intel.com \
--to=lkp@intel.com \
--cc=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=jack@suse.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@collabora.com \
--cc=khazhy@google.com \
--cc=krisman@collabora.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.