Re: [PATCH v2 8/8] perf record: Directly bail out for compat case

From: Leo Yan <leo.yan@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>,
	Andi Kleen <ak@linux.intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 8/8] perf record: Directly bail out for compat case
Date: Wed, 2 Jun 2021 20:38:47 +0800	[thread overview]
Message-ID: <20210602123847.GE10272@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <c321e998-6fd2-86e9-7876-7250a9b23c25@intel.com>

Hi Adrain,

On Wed, Jun 02, 2021 at 02:18:47PM +0300, Adrian Hunter wrote:
> On 2/06/21 1:30 pm, Leo Yan wrote:
> > Since the 64-bit atomicity is not promised in 32-bit perf, directly
> > report the error and bail out for this case.
> > 
> > Now only applies on x86_64 and Arm64 platforms.
> > 
> > Suggested-by: Adrian Hunter <adrian.hunter@intel.com>
> 
> Maybe we can do better for the compat case.
> 
> We can assume the upper 32-bits change very seldom,
> and always increase. So for the 'read' case:
> 
> 	u64 first, second, last;
> 	u64 mask = (u64)((u32)-1) << 32;
> 
> 	do {
> 		first = READ_ONCE(pc->aux_head);
> 		rmb();
> 		second = READ_ONCE(pc->aux_head);
> 		rmb();
> 		last = READ_ONCE(pc->aux_head);
> 	} while ((first & mask) != (last & mask));
> 	return second;
> 
> For the write case, we can cause a fatal error only if the new
> tail has non-zero upper 32-bits.  That gives up to 4GiB of data
> before aborting:
> 
> 	if (tail & mask)
> 		return -1;
> 	smp_mb();
> 	WRITE_ONCE(pc->aux_tail, tail);

Seems to me, it's pointless to only support aux_head for 64-bit and
support aux_tail for 32-bit.  I understand this can be helpful for the
snapshot mode which only uses aux_head, but it still fails to support
the normal case for AUX ring buffer using 64-bit head/tail.

Thanks,
Leo