From: Adrian Hunter <adrian.hunter@intel.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Andi Kleen <ak@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/8] perf auxtrace: Drop legacy __sync functions
Date: Wed, 2 Jun 2021 14:21:05 +0300 [thread overview]
Message-ID: <d179137e-4bbc-0026-3273-622f6dedb002@intel.com> (raw)
In-Reply-To: <20210602111620.GD10272@leoy-ThinkPad-X240s>
On 2/06/21 2:16 pm, Leo Yan wrote:
> Hi Adrian,
>
> On Wed, Jun 02, 2021 at 01:47:42PM +0300, Adrian Hunter wrote:
>
> [...]
>
>>> @@ -451,11 +445,7 @@ static inline u64 auxtrace_mmap__read_snapshot_head(struct auxtrace_mmap *mm)
>>> static inline u64 auxtrace_mmap__read_head(struct auxtrace_mmap *mm)
>>> {
>>> struct perf_event_mmap_page *pc = mm->userpg;
>>> -#if BITS_PER_LONG == 64 || !defined(HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT)
>>
>> The test and setup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT is not needed anymore either.
>
> Yes, I think there have two files should be cleaned:
>
> Makefile.config
> util/auxtrace.c
>
> If still miss anything, please let me know (I remembered there have a
> test case for __sync_xxx_compare_and_swap, but I cannot find it now,
> so this is why I am concern if I miss anything not).
tools/build/feature/test-sync-compare-and-swap.c
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Hunter <adrian.hunter@intel.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
Andi Kleen <ak@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 6/8] perf auxtrace: Drop legacy __sync functions
Date: Wed, 2 Jun 2021 14:21:05 +0300 [thread overview]
Message-ID: <d179137e-4bbc-0026-3273-622f6dedb002@intel.com> (raw)
In-Reply-To: <20210602111620.GD10272@leoy-ThinkPad-X240s>
On 2/06/21 2:16 pm, Leo Yan wrote:
> Hi Adrian,
>
> On Wed, Jun 02, 2021 at 01:47:42PM +0300, Adrian Hunter wrote:
>
> [...]
>
>>> @@ -451,11 +445,7 @@ static inline u64 auxtrace_mmap__read_snapshot_head(struct auxtrace_mmap *mm)
>>> static inline u64 auxtrace_mmap__read_head(struct auxtrace_mmap *mm)
>>> {
>>> struct perf_event_mmap_page *pc = mm->userpg;
>>> -#if BITS_PER_LONG == 64 || !defined(HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT)
>>
>> The test and setup for HAVE_SYNC_COMPARE_AND_SWAP_SUPPORT is not needed anymore either.
>
> Yes, I think there have two files should be cleaned:
>
> Makefile.config
> util/auxtrace.c
>
> If still miss anything, please let me know (I remembered there have a
> test case for __sync_xxx_compare_and_swap, but I cannot find it now,
> so this is why I am concern if I miss anything not).
tools/build/feature/test-sync-compare-and-swap.c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-02 11:20 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 10:29 [PATCH v2 0/8] perf: Refine barriers for AUX ring buffer Leo Yan
2021-06-02 10:29 ` Leo Yan
2021-06-02 10:30 ` [PATCH v2 1/8] perf/ring_buffer: Add comment for barriers on " Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-07 15:27 ` Peter Zijlstra
2021-06-07 15:27 ` Peter Zijlstra
2021-06-02 10:30 ` [PATCH v2 2/8] coresight: tmc-etr: Add barrier after updating " Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-02 10:30 ` [PATCH v2 3/8] coresight: tmc-etf: Add comment for store ordering Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-02 10:30 ` [PATCH v2 4/8] perf/x86: Add barrier after updating bts Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-07 15:29 ` Peter Zijlstra
2021-06-07 15:29 ` Peter Zijlstra
2021-06-02 10:30 ` [PATCH v2 5/8] perf auxtrace: Change to use SMP memory barriers Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-07 10:02 ` Adrian Hunter
2021-06-07 10:02 ` Adrian Hunter
2021-06-07 15:29 ` Peter Zijlstra
2021-06-07 15:29 ` Peter Zijlstra
2021-06-08 16:45 ` Arnaldo Carvalho de Melo
2021-06-08 16:45 ` Arnaldo Carvalho de Melo
2021-06-02 10:30 ` [PATCH v2 6/8] perf auxtrace: Drop legacy __sync functions Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-02 10:47 ` Adrian Hunter
2021-06-02 10:47 ` Adrian Hunter
2021-06-02 11:16 ` Leo Yan
2021-06-02 11:16 ` Leo Yan
2021-06-02 11:21 ` Adrian Hunter [this message]
2021-06-02 11:21 ` Adrian Hunter
2021-06-02 13:01 ` Leo Yan
2021-06-02 13:01 ` Leo Yan
2021-06-02 10:30 ` [PATCH v2 7/8] perf auxtrace: Use WRITE_ONCE() for updating aux_tail Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-07 10:03 ` Adrian Hunter
2021-06-07 10:03 ` Adrian Hunter
2021-06-07 15:31 ` Peter Zijlstra
2021-06-07 15:31 ` Peter Zijlstra
2021-06-08 17:04 ` Arnaldo Carvalho de Melo
2021-06-08 17:04 ` Arnaldo Carvalho de Melo
2021-06-09 0:21 ` Leo Yan
2021-06-09 0:21 ` Leo Yan
2021-06-02 10:30 ` [PATCH v2 8/8] perf record: Directly bail out for compat case Leo Yan
2021-06-02 10:30 ` Leo Yan
2021-06-02 11:18 ` Adrian Hunter
2021-06-02 11:18 ` Adrian Hunter
2021-06-02 12:38 ` Leo Yan
2021-06-02 12:38 ` Leo Yan
2021-06-07 10:23 ` Adrian Hunter
2021-06-07 10:23 ` Adrian Hunter
2021-06-07 15:09 ` Leo Yan
2021-06-07 15:09 ` Leo Yan
2021-06-09 8:23 ` Adrian Hunter
2021-06-09 8:23 ` Adrian Hunter
2021-06-09 8:57 ` Leo Yan
2021-06-09 8:57 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d179137e-4bbc-0026-3273-622f6dedb002@intel.com \
--to=adrian.hunter@intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.