Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
	linux-can@vger.kernel.org, Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb
Date: Sun, 25 Jul 2021 18:27:20 +0200	[thread overview]
Message-ID: <20210725162720.74fu6qny6dqdc625@pengutronix.de> (raw)
In-Reply-To: <CAELBRWJQ+QN6+D0M-61Fz818fm7Q-pP4LW=-KUe+nsyFFSXXPg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

On 25.07.2021 19:44:43, Yasushi SHOJI wrote:
> Hi Pavel,
> 
> On Sun, Jul 25, 2021 at 5:12 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
> > Can You try the following patch?
> >
> > diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
> > index a45865bd7254..a1a154c08b7f 100644
> > --- a/drivers/net/can/usb/mcba_usb.c
> > +++ b/drivers/net/can/usb/mcba_usb.c
> > @@ -653,6 +653,8 @@ static int mcba_usb_start(struct mcba_priv *priv)
> >                         break;
> >                 }
> >
> > +               urb->transfer_dma = buf_dma;
> > +
> >                 usb_fill_bulk_urb(urb, priv->udev,
> >                                   usb_rcvbulkpipe(priv->udev, MCBA_USB_EP_IN),
> >                                   buf, MCBA_USB_RX_BUFF_SIZE,
> 
> Yup, this patch fixed it.  I've tested on top of v5.10.52.
> 
> Tested-by: Yasushi SHOJI <yashi@spacecubics.com>
> 
> > I am sorry for breaking your device :(
> 
> No problem.  It'd be nice if we'd test with real hardware before
> merging into the stable tree, though.

Yes absolutely - but I don't have access to that hardware. Since you're
interested in that hardware, what about adding you as a reviewer to the
kernel. Then for every change on this driver, you'll be added on Cc and
can test it. What do you think?

> Anyway, thank you for your quick fix!

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]