Re: [PATCH] net: can: add missing urb->transfer_dma initialization - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
	wg@grandegger.com, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH] net: can: add missing urb->transfer_dma initialization
Date: Sun, 25 Jul 2021 18:30:39 +0200	[thread overview]
Message-ID: <20210725163039.kyugkdmyn5p3o5r2@pengutronix.de> (raw)
In-Reply-To: <CAELBRWKfyOBanMBteO=LpL9R1QMp97zTYtKY689jeR2gDOa_Gw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

On 25.07.2021 22:27:37, Yasushi SHOJI wrote:
> Hi Pavel,
> 
> I've tested this patch on top of v5.14-rc2.  All good.
> 
> Tested-by: Yasushi SHOJI <yashi@spacecubics.com>
> 
> Some nitpicks.
> 
> On Sun, Jul 25, 2021 at 7:36 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
> >
> > Yasushi reported, that his Microchip CAN Analyzer stopped working since
> > commit 91c02557174b ("can: mcba_usb: fix memory leak in mcba_usb").
> > The problem was in missing urb->transfer_dma initialization.
> >
> > In my previous patch to this driver I refactored mcba_usb_start() code to
> > avoid leaking usb coherent buffers. To achive it, I passed local stack
> 
> achieve
> 
> > variable to usb_alloc_coherent() and then saved it to private array to
> > correctly free all coherent buffers on ->close() call. But I forgot to
> > inialize urb->transfer_dma with variable passed to usb_alloc_coherent().
> 
> initialize

Fixed while applying.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]