Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb

From: Yasushi SHOJI <yasushi.shoji@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: linux-can@vger.kernel.org, mkl@pengutronix.de,
	Yasushi SHOJI <yashi@spacecubics.com>
Subject: Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb
Date: Sun, 25 Jul 2021 19:44:43 +0900	[thread overview]
Message-ID: <CAELBRWJQ+QN6+D0M-61Fz818fm7Q-pP4LW=-KUe+nsyFFSXXPg@mail.gmail.com> (raw)
In-Reply-To: <20210725111242.2d9a819f@gmail.com>

Hi Pavel,

On Sun, Jul 25, 2021 at 5:12 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
> Can You try the following patch?
>
> diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
> index a45865bd7254..a1a154c08b7f 100644
> --- a/drivers/net/can/usb/mcba_usb.c
> +++ b/drivers/net/can/usb/mcba_usb.c
> @@ -653,6 +653,8 @@ static int mcba_usb_start(struct mcba_priv *priv)
>                         break;
>                 }
>
> +               urb->transfer_dma = buf_dma;
> +
>                 usb_fill_bulk_urb(urb, priv->udev,
>                                   usb_rcvbulkpipe(priv->udev, MCBA_USB_EP_IN),
>                                   buf, MCBA_USB_RX_BUFF_SIZE,

Yup, this patch fixed it.  I've tested on top of v5.10.52.

Tested-by: Yasushi SHOJI <yashi@spacecubics.com>

> I am sorry for breaking your device :(

No problem.  It'd be nice if we'd test with real hardware before
merging into the stable tree, though.
Anyway, thank you for your quick fix!

Best regards,
--
               yashi