Re: [PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema

From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Jiri Kosina <trivial@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema
Date: Thu, 23 Sep 2021 18:52:28 -0700	[thread overview]
Message-ID: <20210924015228.GA3030756@roeck-us.net> (raw)
In-Reply-To: <20210921102832.143352-1-krzysztof.kozlowski@canonical.com>

On Tue, Sep 21, 2021 at 12:28:27PM +0200, Krzysztof Kozlowski wrote:
> Convert the TI TMP108 temperature sensor bindings to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ti,tmp108.yaml  | 50 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/tmp108.txt      | 18 -------
>  2 files changed, 50 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/tmp108.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> new file mode 100644
> index 000000000000..eda55bbc172d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ti,tmp108.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TMP108 temperature sensor
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tmp108
> +
> +  interrupts:
> +    items:
> +      - description: alert interrupt
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@48 {
> +            compatible = "ti,tmp108";
> +            reg = <0x48>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&tmp_alrt>;
> +            #thermal-sensor-cells = <0>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> deleted file mode 100644
> index 54d4beed4ee5..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -TMP108 temperature sensor
> --------------------------
> -
> -This device supports I2C only.
> -
> -Requires node properties:
> -- compatible : "ti,tmp108"
> -- reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
> -
> -Optional properties:
> -- interrupts: Reference to the TMP108 alert interrupt.
> -- #thermal-sensor-cells: should be set to 0.
> -
> -Example:
> -	tmp108@48 {
> -		compatible = "ti,tmp108";
> -		reg = <0x48>;
> -	};