Re: [PATCH 5/6] dt-bindings: hwmon: microchip,mcp3021: convert to dtschema

From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jean Delvare <jdelvare@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Jiri Kosina <trivial@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: hwmon: microchip,mcp3021: convert to dtschema
Date: Thu, 23 Sep 2021 18:56:30 -0700	[thread overview]
Message-ID: <20210924015630.GA3031174@roeck-us.net> (raw)
In-Reply-To: <20210921102832.143352-5-krzysztof.kozlowski@canonical.com>

On Tue, Sep 21, 2021 at 12:28:31PM +0200, Krzysztof Kozlowski wrote:
> Convert the Microchip MCP3021 ADC bindings to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/mcp3021.txt     | 21 ---------
>  .../bindings/hwmon/microchip,mcp3021.yaml     | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/mcp3021.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/mcp3021.txt b/Documentation/devicetree/bindings/hwmon/mcp3021.txt
> deleted file mode 100644
> index 294318ba6914..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/mcp3021.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -mcp3021 properties
> -
> -Required properties:
> -- compatible: Must be one of the following:
> -	- "microchip,mcp3021" for mcp3021
> -	- "microchip,mcp3221" for mcp3221
> -- reg: I2C address
> -
> -Optional properties:
> -
> -- reference-voltage-microvolt
> -	Reference voltage in microvolt (uV)
> -
> -Example:
> -
> -mcp3021@4d {
> -	compatible = "microchip,mcp3021";
> -	reg = <0x4d>;
> -
> -	reference-voltage-microvolt = <4500000>; /* 4.5 V */
> -};
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml b/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> new file mode 100644
> index 000000000000..c42051f8a191
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,mcp3021.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip MCP3021 A/D converter
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,mcp3021
> +      - microchip,mcp3221
> +
> +  reg:
> +    maxItems: 1
> +
> +  reference-voltage-microvolt:
> +    description:
> +      VDD supply power and reference voltage
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@4d {
> +            compatible = "microchip,mcp3021";
> +            reg = <0x4d>;
> +
> +            reference-voltage-microvolt = <4500000>; /* 4.5 V */
> +        };
> +    };