From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Jiri Kosina <trivial@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices
Date: Fri, 8 Oct 2021 06:03:00 -0700 [thread overview]
Message-ID: <20211008130300.GA3670503@roeck-us.net> (raw)
In-Reply-To: <20210921102832.143352-3-krzysztof.kozlowski@canonical.com>
On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
> trivial, so they can be integrated into trivial devices bindings.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Following Rob's suggestion:
"... I'd much rather have a schema for these than wait on
someone to decide to convert them. That could mean a device.txt ->
trivial-devices.yaml -> device.yaml trip, but that doesn't seem that
terrible to me. Then we at least are running schema checks on the
devices and know if actual users have more undocumented properties."
Applied.
Thanks,
Guenter
> ---
> .../devicetree/bindings/hwmon/ibm,cffps1.txt | 26 -------------------
> .../devicetree/bindings/trivial-devices.yaml | 6 +++++
> MAINTAINERS | 1 -
> 3 files changed, 6 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt b/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> deleted file mode 100644
> index d9a2719f9243..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -Device-tree bindings for IBM Common Form Factor Power Supply Versions 1 and 2
> ------------------------------------------------------------------------------
> -
> -Required properties:
> - - compatible : Must be one of the following:
> - "ibm,cffps1"
> - "ibm,cffps2"
> - or "ibm,cffps" if the system
> - must support any version of the
> - power supply
> - - reg = < I2C bus address >; : Address of the power supply on the
> - I2C bus.
> -
> -Example:
> -
> - i2c-bus@100 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - #interrupt-cells = <1>;
> - < more properties >
> -
> - power-supply@68 {
> - compatible = "ibm,cffps1";
> - reg = <0x68>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6ad0628741cf..791079021f1b 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -113,6 +113,12 @@ properties:
> - mps,mp2975
> # Honeywell Humidicon HIH-6130 humidity/temperature sensor
> - honeywell,hi6130
> + # IBM Common Form Factor Power Supply Versions (all versions)
> + - ibm,cffps
> + # IBM Common Form Factor Power Supply Versions 1
> + - ibm,cffps1
> + # IBM Common Form Factor Power Supply Versions 2
> + - ibm,cffps2
> # Infineon IR36021 digital POL buck controller
> - infineon,ir36021
> # Infineon IR38064 Voltage Regulator
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 15c4d3c809e8..cc5df54bdc51 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14956,7 +14956,6 @@ S: Maintained
> W: http://hwmon.wiki.kernel.org/
> W: http://www.roeck-us.net/linux/drivers/
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> -F: Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> F: Documentation/devicetree/bindings/hwmon/ltc2978.txt
> F: Documentation/devicetree/bindings/hwmon/max31785.txt
> F: Documentation/hwmon/adm1275.rst
next prev parent reply other threads:[~2021-10-08 13:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 10:28 [PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema Krzysztof Kozlowski
2021-09-21 10:28 ` [PATCH 2/6] dt-bindings: hwmon: ti,tmp102: add bindings and remove from trivial devices Krzysztof Kozlowski
2021-09-23 22:25 ` Rob Herring
2021-09-24 1:54 ` Guenter Roeck
2021-09-21 10:28 ` [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to " Krzysztof Kozlowski
2021-09-21 12:30 ` Guenter Roeck
2021-09-21 12:45 ` Krzysztof Kozlowski
2021-09-21 13:18 ` Guenter Roeck
2021-09-21 14:40 ` Krzysztof Kozlowski
2021-09-22 12:28 ` Guenter Roeck
2021-09-23 22:24 ` Rob Herring
2021-09-27 16:28 ` Rob Herring
2021-10-08 13:03 ` Guenter Roeck [this message]
2021-09-21 10:28 ` [PATCH 4/6] dt-bindings: hwmon: lltc,ltc4151: convert to dtschema Krzysztof Kozlowski
2021-09-23 22:28 ` Rob Herring
2021-09-24 1:55 ` Guenter Roeck
2021-09-21 10:28 ` [PATCH 5/6] dt-bindings: hwmon: microchip,mcp3021: " Krzysztof Kozlowski
2021-09-23 22:29 ` Rob Herring
2021-09-24 1:56 ` Guenter Roeck
2021-09-21 10:28 ` [PATCH 6/6] dt-bindings: hwmon: sensirion,sht15: " Krzysztof Kozlowski
2021-09-23 22:30 ` Rob Herring
2021-09-24 1:57 ` Guenter Roeck
2021-09-23 22:25 ` [PATCH 1/6] dt-bindings: hwmon: ti,tmp108: " Rob Herring
2021-09-24 1:52 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211008130300.GA3670503@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.