From: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Cc: bjorn.andersson@linaro.org, swboyd@chromium.org,
jani.nikula@intel.com, abhinavk@codeaurora.org,
Sean Paul <seanpaul@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org
Subject: [PATCH v4 11/14] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules
Date: Thu, 4 Nov 2021 23:04:28 -0400 [thread overview]
Message-ID: <20211105030434.2828845-12-sean@poorly.run> (raw)
In-Reply-To: <20211105030434.2828845-1-sean@poorly.run>
From: Sean Paul <seanpaul@chromium.org>
Audio is initialized last, it should be de-initialized first to match
the order in dp_init_sub_modules().
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-sean@poorly.run #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-12-sean@poorly.run #v2
Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-12-sean@poorly.run #v3
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-None
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index aba8aa47ed76..79412a8fbaff 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -707,9 +707,9 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data)
static void dp_display_deinit_sub_modules(struct dp_display_private *dp)
{
dp_debug_put(dp->debug);
+ dp_audio_put(dp->audio);
dp_panel_put(dp->panel);
dp_aux_put(dp->aux);
- dp_audio_put(dp->audio);
}
static int dp_init_sub_modules(struct dp_display_private *dp)
--
Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Cc: jani.nikula@intel.com, linux-arm-msm@vger.kernel.org,
abhinavk@codeaurora.org, swboyd@chromium.org,
David Airlie <airlied@linux.ie>,
Sean Paul <seanpaul@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
bjorn.andersson@linaro.org, Sean Paul <sean@poorly.run>
Subject: [PATCH v4 11/14] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules
Date: Thu, 4 Nov 2021 23:04:28 -0400 [thread overview]
Message-ID: <20211105030434.2828845-12-sean@poorly.run> (raw)
In-Reply-To: <20211105030434.2828845-1-sean@poorly.run>
From: Sean Paul <seanpaul@chromium.org>
Audio is initialized last, it should be de-initialized first to match
the order in dp_init_sub_modules().
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-sean@poorly.run #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-12-sean@poorly.run #v2
Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-12-sean@poorly.run #v3
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-None
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index aba8aa47ed76..79412a8fbaff 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -707,9 +707,9 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data)
static void dp_display_deinit_sub_modules(struct dp_display_private *dp)
{
dp_debug_put(dp->debug);
+ dp_audio_put(dp->audio);
dp_panel_put(dp->panel);
dp_aux_put(dp->aux);
- dp_audio_put(dp->audio);
}
static int dp_init_sub_modules(struct dp_display_private *dp)
--
Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Cc: jani.nikula@intel.com, linux-arm-msm@vger.kernel.org,
abhinavk@codeaurora.org, swboyd@chromium.org,
David Airlie <airlied@linux.ie>,
Sean Paul <seanpaul@chromium.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
bjorn.andersson@linaro.org
Subject: [Intel-gfx] [PATCH v4 11/14] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules
Date: Thu, 4 Nov 2021 23:04:28 -0400 [thread overview]
Message-ID: <20211105030434.2828845-12-sean@poorly.run> (raw)
In-Reply-To: <20211105030434.2828845-1-sean@poorly.run>
From: Sean Paul <seanpaul@chromium.org>
Audio is initialized last, it should be de-initialized first to match
the order in dp_init_sub_modules().
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-sean@poorly.run #v1
Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-12-sean@poorly.run #v2
Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-12-sean@poorly.run #v3
Changes in v2:
-None
Changes in v3:
-None
Changes in v4:
-None
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index aba8aa47ed76..79412a8fbaff 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -707,9 +707,9 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data)
static void dp_display_deinit_sub_modules(struct dp_display_private *dp)
{
dp_debug_put(dp->debug);
+ dp_audio_put(dp->audio);
dp_panel_put(dp->panel);
dp_aux_put(dp->aux);
- dp_audio_put(dp->audio);
}
static int dp_init_sub_modules(struct dp_display_private *dp)
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2021-11-05 3:05 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 3:04 [PATCH v4 00/14] drm/hdcp: Pull HDCP auth/exchange/check into helpers Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 01/14] drm/hdcp: Add drm_hdcp_atomic_check() Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 02/14] drm/hdcp: Avoid changing crtc state in hdcp atomic check Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 03/14] drm/hdcp: Update property value on content type and user changes Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 04/14] drm/hdcp: Expand HDCP helper library for enable/disable/check Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 05/14] drm/i915/hdcp: Consolidate HDCP setup/state cache Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 06/14] drm/i915/hdcp: Retain hdcp_capable return codes Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 07/14] drm/i915/hdcp: Use HDCP helpers for i915 Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` [PATCH v4 08/14] drm/msm/dpu_kms: Re-order dpu includes Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-11-05 3:04 ` [PATCH v4 09/14] drm/msm/dpu: Remove useless checks in dpu_encoder Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-11-05 3:04 ` [PATCH v4 10/14] drm/msm/dpu: Remove encoder->enable() hack Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-11-05 3:04 ` Sean Paul [this message]
2021-11-05 3:04 ` [Intel-gfx] [PATCH v4 11/14] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-11-05 3:04 ` [PATCH v4 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-11-12 22:06 ` Rob Herring
2021-11-12 22:06 ` [Intel-gfx] " Rob Herring
2021-11-12 22:06 ` Rob Herring
2021-11-15 20:21 ` [PATCH v4.5 " Sean Paul
2021-11-15 20:21 ` Sean Paul
2021-11-15 20:21 ` [Intel-gfx] " Sean Paul
2021-11-29 22:03 ` Rob Herring
2021-11-29 22:03 ` Rob Herring
2021-11-29 22:03 ` [Intel-gfx] " Rob Herring
2021-11-05 3:04 ` [PATCH v4 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-12-08 22:06 ` [Freedreno] " Rob Clark
2021-12-08 22:06 ` [Intel-gfx] " Rob Clark
2021-12-08 22:06 ` Rob Clark
2021-11-05 3:04 ` [PATCH v4 14/14] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers Sean Paul
2021-11-05 3:04 ` [Intel-gfx] " Sean Paul
2021-11-05 3:04 ` Sean Paul
2021-12-09 3:31 ` Stephen Boyd
2021-12-09 3:31 ` Stephen Boyd
2021-12-09 3:31 ` [Intel-gfx] " Stephen Boyd
2022-02-09 21:41 ` Dmitry Baryshkov
2022-02-09 21:41 ` [Intel-gfx] " Dmitry Baryshkov
2022-02-09 21:41 ` Dmitry Baryshkov
2021-11-05 3:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev3) Patchwork
2021-11-05 3:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-05 3:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-11-15 20:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev4) Patchwork
2021-11-15 20:34 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-11-15 20:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2021-11-15 20:58 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-12-08 20:55 ` [Freedreno] [PATCH v4 00/14] drm/hdcp: Pull HDCP auth/exchange/check into helpers Rob Clark
2021-12-08 20:55 ` [Intel-gfx] " Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105030434.2828845-12-sean@poorly.run \
--to=sean@poorly.run \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.