From: Sam Protsenko <semen.protsenko@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v4 01/12] dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7
Date: Sun, 21 Nov 2021 18:56:36 +0200 [thread overview]
Message-ID: <20211121165647.26706-2-semen.protsenko@linaro.org> (raw)
In-Reply-To: <20211121165647.26706-1-semen.protsenko@linaro.org>
Exynos7 watchdog driver is clearly indicating that its dts node must
define syscon phandle property. That was probably forgotten, so add it.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Fixes: 2b9366b66967 ("watchdog: s3c2410_wdt: Add support for Watchdog device on Exynos7")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
Changes in v4:
- Added R-b tag by Guenter Roeck
Changes in v3:
- Added R-b tag by Rob Herring
Changes in v2:
- Added R-b tag by Krzysztof Kozlowski
- Added "Fixes" tag
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
index 76cb9586ee00..93cd77a6e92c 100644
--- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
@@ -39,8 +39,8 @@ properties:
samsung,syscon-phandle:
$ref: /schemas/types.yaml#/definitions/phandle
description:
- Phandle to the PMU system controller node (in case of Exynos5250
- and Exynos5420).
+ Phandle to the PMU system controller node (in case of Exynos5250,
+ Exynos5420 and Exynos7).
required:
- compatible
@@ -58,6 +58,7 @@ allOf:
enum:
- samsung,exynos5250-wdt
- samsung,exynos5420-wdt
+ - samsung,exynos7-wdt
then:
required:
- samsung,syscon-phandle
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Sam Protsenko <semen.protsenko@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v4 01/12] dt-bindings: watchdog: Require samsung, syscon-phandle for Exynos7
Date: Sun, 21 Nov 2021 18:56:36 +0200 [thread overview]
Message-ID: <20211121165647.26706-2-semen.protsenko@linaro.org> (raw)
In-Reply-To: <20211121165647.26706-1-semen.protsenko@linaro.org>
Exynos7 watchdog driver is clearly indicating that its dts node must
define syscon phandle property. That was probably forgotten, so add it.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Fixes: 2b9366b66967 ("watchdog: s3c2410_wdt: Add support for Watchdog device on Exynos7")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
---
Changes in v4:
- Added R-b tag by Guenter Roeck
Changes in v3:
- Added R-b tag by Rob Herring
Changes in v2:
- Added R-b tag by Krzysztof Kozlowski
- Added "Fixes" tag
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
index 76cb9586ee00..93cd77a6e92c 100644
--- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
@@ -39,8 +39,8 @@ properties:
samsung,syscon-phandle:
$ref: /schemas/types.yaml#/definitions/phandle
description:
- Phandle to the PMU system controller node (in case of Exynos5250
- and Exynos5420).
+ Phandle to the PMU system controller node (in case of Exynos5250,
+ Exynos5420 and Exynos7).
required:
- compatible
@@ -58,6 +58,7 @@ allOf:
enum:
- samsung,exynos5250-wdt
- samsung,exynos5420-wdt
+ - samsung,exynos7-wdt
then:
required:
- samsung,syscon-phandle
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-21 16:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 16:56 [PATCH v4 00/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko [this message]
2021-11-21 16:56 ` [PATCH v4 01/12] dt-bindings: watchdog: Require samsung, syscon-phandle for Exynos7 Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 02/12] dt-bindings: watchdog: Document Exynos850 watchdog bindings Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 03/12] watchdog: s3c2410: Fail probe if can't find valid timeout Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 04/12] watchdog: s3c2410: Let kernel kick watchdog Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 05/12] watchdog: s3c2410: Make reset disable register optional Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 06/12] watchdog: s3c2410: Extract disable and mask code into separate functions Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 07/12] watchdog: s3c2410: Implement a way to invert mask reg value Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 08/12] watchdog: s3c2410: Add support for WDT counter enable register Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 09/12] watchdog: s3c2410: Cleanup PMU related code Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-23 16:06 ` Guenter Roeck
2021-11-23 16:06 ` Guenter Roeck
2021-11-23 16:17 ` Sam Protsenko
2021-11-23 16:17 ` Sam Protsenko
2021-11-23 22:33 ` Guenter Roeck
2021-11-23 22:33 ` Guenter Roeck
2021-11-23 23:30 ` Sam Protsenko
2021-11-23 23:30 ` Sam Protsenko
2021-11-27 22:52 ` Sam Protsenko
2021-11-27 22:52 ` Sam Protsenko
2021-11-28 17:56 ` Guenter Roeck
2021-11-28 17:56 ` Guenter Roeck
2021-11-28 19:18 ` Sam Protsenko
2021-11-28 19:18 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 10/12] watchdog: s3c2410: Support separate source clock Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 11/12] watchdog: s3c2410: Remove superfluous err label Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-21 16:56 ` [PATCH v4 12/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-11-21 16:56 ` Sam Protsenko
2021-11-22 15:14 ` Sam Protsenko
2021-11-22 15:14 ` Sam Protsenko
2021-11-23 16:12 ` Guenter Roeck
2021-11-23 16:12 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121165647.26706-2-semen.protsenko@linaro.org \
--to=semen.protsenko@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.