From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Dmitry Osipenko <digetx@gmail.com> Cc: Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Ulf Hansson <ulf.hansson@linaro.org>, Viresh Kumar <vireshk@kernel.org>, Stephen Boyd <sboyd@kernel.org>, Peter De Schrijver <pdeschrijver@nvidia.com>, Mikko Perttunen <mperttunen@nvidia.com>, Lee Jones <lee.jones@linaro.org>, Nishanth Menon <nm@ti.com>, Adrian Hunter <adrian.hunter@intel.com>, Michael Turquette <mturquette@baylibre.com>, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mmc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, David Heidelberg <david@ixit.cz> Subject: Re: [PATCH v16 21/40] pwm: tegra: Add runtime PM and OPP support Date: Mon, 21 Feb 2022 14:37:24 +0100 [thread overview] Message-ID: <20220221133724.iusksyn7n7hmxil2@pengutronix.de> (raw) In-Reply-To: <677beebd-5a16-297f-c09a-fa4b72c001c9@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1819 bytes --] Hello, On Mon, Feb 21, 2022 at 12:53:58PM +0300, Dmitry Osipenko wrote: > 21.02.2022 11:17, Uwe Kleine-König пишет: > >> @@ -344,7 +387,10 @@ static const struct of_device_id tegra_pwm_of_match[] = { > >> MODULE_DEVICE_TABLE(of, tegra_pwm_of_match); > >> > >> static const struct dev_pm_ops tegra_pwm_pm_ops = { > >> - SET_SYSTEM_SLEEP_PM_OPS(tegra_pwm_suspend, tegra_pwm_resume) > >> + SET_RUNTIME_PM_OPS(tegra_pwm_runtime_suspend, tegra_pwm_runtime_resume, > >> + NULL) > >> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > >> + pm_runtime_force_resume) > >> }; > >> > >> static struct platform_driver tegra_pwm_driver = { > > I admit to not completely understand the effects of this patch, but I > > don't see a problem either. So for me this patch is OK: > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > I spot a problem, it's not introduced by this patch however: If the > > consumer of the PWM didn't stop the hardware, the suspend should IMHO be > > prevented. > > Why? The PWM driver itself will stop the h/w on suspend. Stopping the PWM might be bad. Only the consumer can know if it's ok to stop the PWM on suspend. If so the consumer should stop the PWM in their suspend callback and the PWM should prevent suspend if it wasn't stopped. > > I wonder if the patches in this series go in in one go via an ARM or > > Tegra tree, or each patch via its respective maintainer tree. > > This series, including this patch, was already applied to 5.17 via the > tegra/soc tree. No action is needed anymore. Ah, I missed that, thanks. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Dmitry Osipenko <digetx@gmail.com> Cc: Nishanth Menon <nm@ti.com>, linux-pwm@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>, Viresh Kumar <vireshk@kernel.org>, Peter De Schrijver <pdeschrijver@nvidia.com>, linux-mmc@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>, dri-devel@lists.freedesktop.org, Jonathan Hunter <jonathanh@nvidia.com>, Thierry Reding <thierry.reding@gmail.com>, David Heidelberg <david@ixit.cz>, linux-tegra@vger.kernel.org, Mikko Perttunen <mperttunen@nvidia.com>, Lee Jones <lee.jones@linaro.org>, Michael Turquette <mturquette@baylibre.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 21/40] pwm: tegra: Add runtime PM and OPP support Date: Mon, 21 Feb 2022 14:37:24 +0100 [thread overview] Message-ID: <20220221133724.iusksyn7n7hmxil2@pengutronix.de> (raw) In-Reply-To: <677beebd-5a16-297f-c09a-fa4b72c001c9@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1819 bytes --] Hello, On Mon, Feb 21, 2022 at 12:53:58PM +0300, Dmitry Osipenko wrote: > 21.02.2022 11:17, Uwe Kleine-König пишет: > >> @@ -344,7 +387,10 @@ static const struct of_device_id tegra_pwm_of_match[] = { > >> MODULE_DEVICE_TABLE(of, tegra_pwm_of_match); > >> > >> static const struct dev_pm_ops tegra_pwm_pm_ops = { > >> - SET_SYSTEM_SLEEP_PM_OPS(tegra_pwm_suspend, tegra_pwm_resume) > >> + SET_RUNTIME_PM_OPS(tegra_pwm_runtime_suspend, tegra_pwm_runtime_resume, > >> + NULL) > >> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > >> + pm_runtime_force_resume) > >> }; > >> > >> static struct platform_driver tegra_pwm_driver = { > > I admit to not completely understand the effects of this patch, but I > > don't see a problem either. So for me this patch is OK: > > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > I spot a problem, it's not introduced by this patch however: If the > > consumer of the PWM didn't stop the hardware, the suspend should IMHO be > > prevented. > > Why? The PWM driver itself will stop the h/w on suspend. Stopping the PWM might be bad. Only the consumer can know if it's ok to stop the PWM on suspend. If so the consumer should stop the PWM in their suspend callback and the PWM should prevent suspend if it wasn't stopped. > > I wonder if the patches in this series go in in one go via an ARM or > > Tegra tree, or each patch via its respective maintainer tree. > > This series, including this patch, was already applied to 5.17 via the > tegra/soc tree. No action is needed anymore. Ah, I missed that, thanks. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-21 13:37 UTC|newest] Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-30 23:23 [PATCH v16 00/40] NVIDIA Tegra power management patches for 5.17 Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 01/40] soc/tegra: Enable runtime PM during OPP state-syncing Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 02/40] soc/tegra: Add devm_tegra_core_dev_init_opp_table_common() Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 03/40] soc/tegra: Don't print error message when OPPs not available Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 04/40] dt-bindings: clock: tegra-car: Document new clock sub-nodes Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 05/40] clk: tegra: Support runtime PM and power domain Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 06/40] dt-bindings: host1x: Document OPP and power domain properties Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 07/40] dt-bindings: host1x: Document Memory Client resets of Host1x, GR2D and GR3D Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 08/40] gpu: host1x: Add initial runtime PM and OPP support Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-12-21 18:55 ` Jon Hunter 2021-12-21 18:55 ` Jon Hunter 2021-12-21 20:58 ` Dmitry Osipenko 2021-12-21 20:58 ` Dmitry Osipenko 2021-12-22 9:47 ` Jon Hunter 2021-12-22 9:47 ` Jon Hunter 2021-12-22 18:41 ` Jon Hunter 2021-12-22 18:41 ` Jon Hunter 2021-12-22 19:01 ` Dmitry Osipenko 2021-12-22 19:01 ` Dmitry Osipenko 2021-12-22 19:30 ` Jon Hunter 2021-12-22 19:30 ` Jon Hunter 2021-12-22 19:31 ` Dmitry Osipenko 2021-12-22 19:31 ` Dmitry Osipenko 2022-01-31 20:39 ` Marc Zyngier 2022-01-31 20:39 ` Marc Zyngier 2021-11-30 23:23 ` [PATCH v16 09/40] gpu: host1x: Add host1x_channel_stop() Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 10/40] drm/tegra: submit: Add missing pm_runtime_mark_last_busy() Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 11/40] drm/tegra: dc: Support OPP and SoC core voltage scaling Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 12/40] drm/tegra: hdmi: Add OPP support Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 13/40] drm/tegra: gr2d: Support generic power domain and runtime PM Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 14/40] drm/tegra: gr3d: " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 15/40] drm/tegra: vic: Stop channel on suspend Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 16/40] drm/tegra: nvdec: " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 17/40] drm/tegra: submit: Remove pm_runtime_enabled() checks Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 18/40] drm/tegra: Consolidate runtime PM management of older UAPI codepath Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 19/40] usb: chipidea: tegra: Add runtime PM and OPP support Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 20/40] bus: tegra-gmi: " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 21/40] pwm: tegra: " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2022-02-21 8:17 ` Uwe Kleine-König 2022-02-21 8:17 ` Uwe Kleine-König 2022-02-21 9:53 ` Dmitry Osipenko 2022-02-21 9:53 ` Dmitry Osipenko 2022-02-21 13:37 ` Uwe Kleine-König [this message] 2022-02-21 13:37 ` Uwe Kleine-König 2021-11-30 23:23 ` [PATCH v16 22/40] mmc: sdhci-tegra: " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-12-02 8:16 ` Adrian Hunter 2021-12-02 8:16 ` Adrian Hunter 2021-11-30 23:23 ` [PATCH v16 23/40] mtd: rawnand: tegra: " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 24/40] spi: tegra20-slink: Add " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 25/40] media: dt: bindings: tegra-vde: Convert to schema Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 26/40] media: dt: bindings: tegra-vde: Document OPP and power domain Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 27/40] media: staging: tegra-vde: Support generic " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 28/40] soc/tegra: fuse: Reset hardware Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-12-16 12:59 ` Thierry Reding 2021-12-16 12:59 ` Thierry Reding 2021-11-30 23:23 ` [PATCH v16 30/40] soc/tegra: regulators: Prepare for suspend Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 31/40] soc/tegra: pmc: Rename 3d power domains Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 32/40] soc/tegra: pmc: Rename core power domain Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 33/40] soc/tegra: pmc: Enable core domain support for Tegra20 and Tegra30 Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2022-02-03 17:51 ` Thierry Reding 2022-02-03 17:51 ` Thierry Reding 2021-11-30 23:23 ` [PATCH v16 34/40] ARM: tegra: Rename CPU and EMC OPP table device-tree nodes Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 35/40] ARM: tegra: Add 500MHz entry to Tegra30 memory OPP table Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 36/40] ARM: tegra: Add OPP tables and power domains to Tegra20 device-trees Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 37/40] ARM: tegra: Add OPP tables and power domains to Tegra30 device-trees Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 38/40] ARM: tegra: Add Memory Client resets to Tegra20 GR2D, GR3D and Host1x Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 39/40] ARM: tegra: Add Memory Client resets to Tegra30 " Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-11-30 23:23 ` [PATCH v16 40/40] ARM: tegra20/30: Disable unused host1x hardware Dmitry Osipenko 2021-11-30 23:23 ` Dmitry Osipenko 2021-12-15 15:55 ` [PATCH v16 00/40] NVIDIA Tegra power management patches for 5.17 Thierry Reding 2021-12-15 15:55 ` Thierry Reding 2021-12-15 16:11 ` Dmitry Osipenko 2021-12-15 16:11 ` Dmitry Osipenko 2021-12-16 13:14 ` Thierry Reding 2021-12-16 13:14 ` Thierry Reding 2021-12-16 14:19 ` Dmitry Osipenko 2021-12-16 14:19 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220221133724.iusksyn7n7hmxil2@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=adrian.hunter@intel.com \ --cc=david@ixit.cz \ --cc=digetx@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jonathanh@nvidia.com \ --cc=lee.jones@linaro.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mperttunen@nvidia.com \ --cc=mturquette@baylibre.com \ --cc=nm@ti.com \ --cc=pdeschrijver@nvidia.com \ --cc=sboyd@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=ulf.hansson@linaro.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.