From: Lucas Tanure <tanureal@opensource.cirrus.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: [PATCH v2 04/20] ASoC: cs35l41: Remove unnecessary param
Date: Fri, 4 Mar 2022 15:07:05 +0000 [thread overview]
Message-ID: <20220304150721.3802-5-tanureal@opensource.cirrus.com> (raw)
In-Reply-To: <20220304150721.3802-1-tanureal@opensource.cirrus.com>
cs35l41_private is not used on cs35l41_handle_pdata
Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
sound/soc/codecs/cs35l41.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
index 05de94fd2e55..6b784a62df0c 100644
--- a/sound/soc/codecs/cs35l41.c
+++ b/sound/soc/codecs/cs35l41.c
@@ -1115,9 +1115,7 @@ static const struct snd_soc_component_driver soc_component_dev_cs35l41 = {
.set_sysclk = cs35l41_component_set_sysclk,
};
-static int cs35l41_handle_pdata(struct device *dev,
- struct cs35l41_platform_data *pdata,
- struct cs35l41_private *cs35l41)
+static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_platform_data *pdata)
{
struct cs35l41_irq_cfg *irq_gpio1_config = &pdata->irq_config1;
struct cs35l41_irq_cfg *irq_gpio2_config = &pdata->irq_config2;
@@ -1260,7 +1258,7 @@ int cs35l41_probe(struct cs35l41_private *cs35l41,
if (pdata) {
cs35l41->pdata = *pdata;
} else {
- ret = cs35l41_handle_pdata(cs35l41->dev, &cs35l41->pdata, cs35l41);
+ ret = cs35l41_handle_pdata(cs35l41->dev, &cs35l41->pdata);
if (ret != 0)
return ret;
}
--
2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Tanure <tanureal@opensource.cirrus.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Lucas Tanure <tanureal@opensource.cirrus.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: [PATCH v2 04/20] ASoC: cs35l41: Remove unnecessary param
Date: Fri, 4 Mar 2022 15:07:05 +0000 [thread overview]
Message-ID: <20220304150721.3802-5-tanureal@opensource.cirrus.com> (raw)
In-Reply-To: <20220304150721.3802-1-tanureal@opensource.cirrus.com>
cs35l41_private is not used on cs35l41_handle_pdata
Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
sound/soc/codecs/cs35l41.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
index 05de94fd2e55..6b784a62df0c 100644
--- a/sound/soc/codecs/cs35l41.c
+++ b/sound/soc/codecs/cs35l41.c
@@ -1115,9 +1115,7 @@ static const struct snd_soc_component_driver soc_component_dev_cs35l41 = {
.set_sysclk = cs35l41_component_set_sysclk,
};
-static int cs35l41_handle_pdata(struct device *dev,
- struct cs35l41_platform_data *pdata,
- struct cs35l41_private *cs35l41)
+static int cs35l41_handle_pdata(struct device *dev, struct cs35l41_platform_data *pdata)
{
struct cs35l41_irq_cfg *irq_gpio1_config = &pdata->irq_config1;
struct cs35l41_irq_cfg *irq_gpio2_config = &pdata->irq_config2;
@@ -1260,7 +1258,7 @@ int cs35l41_probe(struct cs35l41_private *cs35l41,
if (pdata) {
cs35l41->pdata = *pdata;
} else {
- ret = cs35l41_handle_pdata(cs35l41->dev, &cs35l41->pdata, cs35l41);
+ ret = cs35l41_handle_pdata(cs35l41->dev, &cs35l41->pdata);
if (ret != 0)
return ret;
}
--
2.35.1
next prev parent reply other threads:[~2022-03-04 15:08 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 15:07 [PATCH v2 00/20] Support external boost at CS35l41 ASoC driver Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 01/20] ASoC: cs35l41: Fix GPIO2 configuration Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:22 ` Charles Keepax
2022-03-04 15:22 ` Charles Keepax
2022-03-04 15:44 ` tanureal
2022-03-04 15:07 ` [PATCH v2 02/20] ASoC: cs35l41: Fix max number of TX channels Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 03/20] ASoC: cs35l41: Fix DSP mbox start command and global enable order Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure [this message]
2022-03-04 15:07 ` [PATCH v2 04/20] ASoC: cs35l41: Remove unnecessary param Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 05/20] sound: cs35l41: Unify hardware configuration Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 06/20] sound: cs35l41: Check hw_config before using it Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 07/20] sound: cs35l41: Move cs35l41_gpio_config to shared lib Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 08/20] hda: cs35l41: Fix I2S params comments Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 09/20] hda: cs35l41: Always configure the DAI Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 10/20] hda: cs35l41: Add Boost type flag Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 11/20] hda: cs35l41: Put the device into safe mode for external boost Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 12/20] hda: cs35l41: Mute the device before shutdown Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 13/20] sound: cs35l41: Enable Internal Boost in shared lib Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 16:17 ` Charles Keepax
2022-03-04 16:17 ` Charles Keepax
2022-03-04 15:07 ` [PATCH v2 14/20] hda: cs35l41: Move boost config to initialization code Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 15/20] hda: cs35l41: Remove cs35l41_hda_reg_sequence struct Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 16/20] hda: cs35l41: Reorganize log for playback actions Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 17/20] hda: cs35l41: Handle all external boost setups the same way Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 18/20] hda: cs35l41: Move external boost handling to lib for ASoC use Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 19/20] ASoC: cs35l41: Support external boost Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 15:07 ` [PATCH v2 20/20] ASoC: cs35l41: Document CS35l41 External Boost Lucas Tanure
2022-03-04 15:07 ` Lucas Tanure
2022-03-04 17:05 ` [PATCH v2 00/20] Support external boost at CS35l41 ASoC driver Takashi Iwai
2022-03-04 17:05 ` Takashi Iwai
2022-03-07 20:38 ` (subset) " Mark Brown
2022-03-07 20:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220304150721.3802-5-tanureal@opensource.cirrus.com \
--to=tanureal@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.