From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
robh+dt@kernel.org, tzungbi@google.com,
angelogioacchino.delregno@collabora.com, aaronyu@google.com,
matthias.bgg@gmail.com, trevor.wu@mediatek.com,
linmq006@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: Re: [v7 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker
Date: Wed, 30 Mar 2022 12:14:50 -0400 [thread overview]
Message-ID: <20220330161450.xxak64el6g6lzcem@notapiano> (raw)
In-Reply-To: <734fbf254c64668856e987aafe9d7dfd3ec86941.camel@mediatek.com>
On Wed, Mar 30, 2022 at 11:48:01PM +0800, Jiaxin Yu wrote:
> On Wed, 2022-03-30 at 15:24 +0100, Mark Brown wrote:
> > On Wed, Mar 30, 2022 at 10:06:24PM +0800, Jiaxin Yu wrote:
> > > On Wed, 2022-03-30 at 13:30 +0100, Mark Brown wrote:
> > > > Making a previously optional property required means that systems
> > > > that
> > > > previously worked may stop working unless they update their DT,
> > > > DTs
> > > > may
> > > > be distributed separately to the kernel and perhaps even baked
> > > > into
> > > > firmware or similar.
> > > Thank you for your detailed answer. I should keep the driver's
> > > behavior
> > > consistent with the description of dt-bindings. The "mediatek,hdmi-
> > > codec" needs to be set as the required property. Is my
> > > understanding
> > > right?
> >
> > The binding document and code should match so if one is changed the
> > other needs to be changed too.
> >
> > In theory we should never change a previously optional property to
> > required which would mean that the code should be updated to reflect
> > the
> > binding document, however sometimes the DT isn't actually used as a
> > stable intereface by anything for a given property or device type so
> > we
> > can get away with changing things.
>
> "however sometimes the DT isn't actually used as a stable intereface by
> anything for a given property or device type so we can get away with
> changing things."
>
> Sorry, I don't understand the real idea of this description. Does it
> mean that dt-bindings in this series don't need to be updated, but the
> driver?
He means that usually the DT (and dt-binding) shouldn't be changed to avoid
incompatibilities, but sometimes it's OK to change them. For example if there
are no users of the DT yet.
But in any case, like I mentioned in my latest reply [1], I don't think changing
the dt-binding is the proper solution in this case. The driver should be changed
instead.
Thanks,
Nícolas
[1] https://lore.kernel.org/all/20220330152026.6nuigsldx46lue44@notapiano
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
robh+dt@kernel.org, tzungbi@google.com,
angelogioacchino.delregno@collabora.com, aaronyu@google.com,
matthias.bgg@gmail.com, trevor.wu@mediatek.com,
linmq006@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: Re: [v7 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker
Date: Wed, 30 Mar 2022 12:14:50 -0400 [thread overview]
Message-ID: <20220330161450.xxak64el6g6lzcem@notapiano> (raw)
In-Reply-To: <734fbf254c64668856e987aafe9d7dfd3ec86941.camel@mediatek.com>
On Wed, Mar 30, 2022 at 11:48:01PM +0800, Jiaxin Yu wrote:
> On Wed, 2022-03-30 at 15:24 +0100, Mark Brown wrote:
> > On Wed, Mar 30, 2022 at 10:06:24PM +0800, Jiaxin Yu wrote:
> > > On Wed, 2022-03-30 at 13:30 +0100, Mark Brown wrote:
> > > > Making a previously optional property required means that systems
> > > > that
> > > > previously worked may stop working unless they update their DT,
> > > > DTs
> > > > may
> > > > be distributed separately to the kernel and perhaps even baked
> > > > into
> > > > firmware or similar.
> > > Thank you for your detailed answer. I should keep the driver's
> > > behavior
> > > consistent with the description of dt-bindings. The "mediatek,hdmi-
> > > codec" needs to be set as the required property. Is my
> > > understanding
> > > right?
> >
> > The binding document and code should match so if one is changed the
> > other needs to be changed too.
> >
> > In theory we should never change a previously optional property to
> > required which would mean that the code should be updated to reflect
> > the
> > binding document, however sometimes the DT isn't actually used as a
> > stable intereface by anything for a given property or device type so
> > we
> > can get away with changing things.
>
> "however sometimes the DT isn't actually used as a stable intereface by
> anything for a given property or device type so we can get away with
> changing things."
>
> Sorry, I don't understand the real idea of this description. Does it
> mean that dt-bindings in this series don't need to be updated, but the
> driver?
He means that usually the DT (and dt-binding) shouldn't be changed to avoid
incompatibilities, but sometimes it's OK to change them. For example if there
are no users of the DT yet.
But in any case, like I mentioned in my latest reply [1], I don't think changing
the dt-binding is the proper solution in this case. The driver should be changed
instead.
Thanks,
Nícolas
[1] https://lore.kernel.org/all/20220330152026.6nuigsldx46lue44@notapiano
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: devicetree@vger.kernel.org, linmq006@gmail.com,
alsa-devel@alsa-project.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
tzungbi@google.com, Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com,
Tzung-Bi Shih <tzungbi@kernel.org>,
matthias.bgg@gmail.com, aaronyu@google.com,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [v7 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker
Date: Wed, 30 Mar 2022 12:14:50 -0400 [thread overview]
Message-ID: <20220330161450.xxak64el6g6lzcem@notapiano> (raw)
In-Reply-To: <734fbf254c64668856e987aafe9d7dfd3ec86941.camel@mediatek.com>
On Wed, Mar 30, 2022 at 11:48:01PM +0800, Jiaxin Yu wrote:
> On Wed, 2022-03-30 at 15:24 +0100, Mark Brown wrote:
> > On Wed, Mar 30, 2022 at 10:06:24PM +0800, Jiaxin Yu wrote:
> > > On Wed, 2022-03-30 at 13:30 +0100, Mark Brown wrote:
> > > > Making a previously optional property required means that systems
> > > > that
> > > > previously worked may stop working unless they update their DT,
> > > > DTs
> > > > may
> > > > be distributed separately to the kernel and perhaps even baked
> > > > into
> > > > firmware or similar.
> > > Thank you for your detailed answer. I should keep the driver's
> > > behavior
> > > consistent with the description of dt-bindings. The "mediatek,hdmi-
> > > codec" needs to be set as the required property. Is my
> > > understanding
> > > right?
> >
> > The binding document and code should match so if one is changed the
> > other needs to be changed too.
> >
> > In theory we should never change a previously optional property to
> > required which would mean that the code should be updated to reflect
> > the
> > binding document, however sometimes the DT isn't actually used as a
> > stable intereface by anything for a given property or device type so
> > we
> > can get away with changing things.
>
> "however sometimes the DT isn't actually used as a stable intereface by
> anything for a given property or device type so we can get away with
> changing things."
>
> Sorry, I don't understand the real idea of this description. Does it
> mean that dt-bindings in this series don't need to be updated, but the
> driver?
He means that usually the DT (and dt-binding) shouldn't be changed to avoid
incompatibilities, but sometimes it's OK to change them. For example if there
are no users of the DT yet.
But in any case, like I mentioned in my latest reply [1], I don't think changing
the dt-binding is the proper solution in this case. The driver should be changed
instead.
Thanks,
Nícolas
[1] https://lore.kernel.org/all/20220330152026.6nuigsldx46lue44@notapiano
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: Mark Brown <broonie@kernel.org>,
robh+dt@kernel.org, tzungbi@google.com,
angelogioacchino.delregno@collabora.com, aaronyu@google.com,
matthias.bgg@gmail.com, trevor.wu@mediatek.com,
linmq006@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: Re: [v7 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker
Date: Wed, 30 Mar 2022 12:14:50 -0400 [thread overview]
Message-ID: <20220330161450.xxak64el6g6lzcem@notapiano> (raw)
In-Reply-To: <734fbf254c64668856e987aafe9d7dfd3ec86941.camel@mediatek.com>
On Wed, Mar 30, 2022 at 11:48:01PM +0800, Jiaxin Yu wrote:
> On Wed, 2022-03-30 at 15:24 +0100, Mark Brown wrote:
> > On Wed, Mar 30, 2022 at 10:06:24PM +0800, Jiaxin Yu wrote:
> > > On Wed, 2022-03-30 at 13:30 +0100, Mark Brown wrote:
> > > > Making a previously optional property required means that systems
> > > > that
> > > > previously worked may stop working unless they update their DT,
> > > > DTs
> > > > may
> > > > be distributed separately to the kernel and perhaps even baked
> > > > into
> > > > firmware or similar.
> > > Thank you for your detailed answer. I should keep the driver's
> > > behavior
> > > consistent with the description of dt-bindings. The "mediatek,hdmi-
> > > codec" needs to be set as the required property. Is my
> > > understanding
> > > right?
> >
> > The binding document and code should match so if one is changed the
> > other needs to be changed too.
> >
> > In theory we should never change a previously optional property to
> > required which would mean that the code should be updated to reflect
> > the
> > binding document, however sometimes the DT isn't actually used as a
> > stable intereface by anything for a given property or device type so
> > we
> > can get away with changing things.
>
> "however sometimes the DT isn't actually used as a stable intereface by
> anything for a given property or device type so we can get away with
> changing things."
>
> Sorry, I don't understand the real idea of this description. Does it
> mean that dt-bindings in this series don't need to be updated, but the
> driver?
He means that usually the DT (and dt-binding) shouldn't be changed to avoid
incompatibilities, but sometimes it's OK to change them. For example if there
are no users of the DT yet.
But in any case, like I mentioned in my latest reply [1], I don't think changing
the dt-binding is the proper solution in this case. The driver should be changed
instead.
Thanks,
Nícolas
[1] https://lore.kernel.org/all/20220330152026.6nuigsldx46lue44@notapiano
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-30 16:15 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 6:45 [v7 0/4] ASoC: mediatek: mt8192: support rt1015p_rt5682s Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` [v7 1/4] ASoC: dt-bindings: mt8192-mt6359: add new compatible and new properties Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-29 23:13 ` Rob Herring
2022-03-29 23:13 ` Rob Herring
2022-03-29 23:13 ` Rob Herring
2022-03-29 23:13 ` Rob Herring
2022-03-24 6:45 ` [v7 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-29 22:30 ` Nícolas F. R. A. Prado
2022-03-29 22:30 ` Nícolas F. R. A. Prado
2022-03-29 22:30 ` Nícolas F. R. A. Prado
2022-03-29 22:30 ` Nícolas F. R. A. Prado
2022-03-30 2:33 ` Jiaxin Yu
2022-03-30 2:33 ` Jiaxin Yu
2022-03-30 2:33 ` Jiaxin Yu
2022-03-30 2:33 ` Jiaxin Yu
2022-03-30 12:30 ` Mark Brown
2022-03-30 12:30 ` Mark Brown
2022-03-30 12:30 ` Mark Brown
2022-03-30 12:30 ` Mark Brown
2022-03-30 14:06 ` Jiaxin Yu
2022-03-30 14:06 ` Jiaxin Yu
2022-03-30 14:06 ` Jiaxin Yu
2022-03-30 14:06 ` Jiaxin Yu
2022-03-30 14:24 ` Mark Brown
2022-03-30 14:24 ` Mark Brown
2022-03-30 14:24 ` Mark Brown
2022-03-30 14:24 ` Mark Brown
2022-03-30 15:48 ` Jiaxin Yu
2022-03-30 15:48 ` Jiaxin Yu
2022-03-30 15:48 ` Jiaxin Yu
2022-03-30 15:48 ` Jiaxin Yu
2022-03-30 16:14 ` Nícolas F. R. A. Prado [this message]
2022-03-30 16:14 ` Nícolas F. R. A. Prado
2022-03-30 16:14 ` Nícolas F. R. A. Prado
2022-03-30 16:14 ` Nícolas F. R. A. Prado
2022-03-30 15:20 ` Nícolas F. R. A. Prado
2022-03-30 15:20 ` Nícolas F. R. A. Prado
2022-03-30 15:20 ` Nícolas F. R. A. Prado
2022-03-30 15:20 ` Nícolas F. R. A. Prado
2022-03-30 16:20 ` Jiaxin Yu
2022-03-30 16:20 ` Jiaxin Yu
2022-03-30 16:20 ` Jiaxin Yu
2022-03-30 16:20 ` Jiaxin Yu
2022-03-24 6:45 ` [v7 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` [v7 4/4] ASoC: mediatek: mt8192: support rt1015p_rt5682s Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
2022-03-24 6:45 ` Jiaxin Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330161450.xxak64el6g6lzcem@notapiano \
--to=nfraprado@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.