From: "Michal Koutný" <mkoutny@suse.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Vasily Averin <vvs@openvz.org>, Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
kernel@openvz.org, Florian Westphal <fw@strlen.de>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>, Cgroups <cgroups@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH memcg v4] net: set proper memcg for net_init hooks allocations
Date: Wed, 27 Apr 2022 14:22:32 +0200 [thread overview]
Message-ID: <20220427122232.GA9823@blackbody.suse.cz> (raw)
In-Reply-To: <CALvZod4oaj9MpBDVUp9KGmnqu4F3UxjXgOLkrkvmRfFjA7F1dw@mail.gmail.com>
On Tue, Apr 26, 2022 at 10:23:32PM -0700, Shakeel Butt <shakeelb@google.com> wrote:
> [...]
> >
> > +static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p)
> > +{
> > + struct mem_cgroup *memcg;
> > +
>
> Do we need memcg_kmem_enabled() check here or maybe
> mem_cgroup_from_obj() should be doing memcg_kmem_enabled() instead of
> mem_cgroup_disabled() as we can have "cgroup.memory=nokmem" boot
> param.
I reckon such a guard is on the charge side and readers should treat
NULL and root_mem_group equally. Or is there a case when these two are
different?
(I can see it's different semantics when stored in current->active_memcg
(and active_memcg() getter) but for such "outer" callers like here it
seems equal.)
Regards,
Michal
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: Vasily Averin <vvs-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>,
Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>,
Roman Gushchin
<roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>,
kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
Florian Westphal <fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Paolo Abeni <pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH memcg v4] net: set proper memcg for net_init hooks allocations
Date: Wed, 27 Apr 2022 14:22:32 +0200 [thread overview]
Message-ID: <20220427122232.GA9823@blackbody.suse.cz> (raw)
In-Reply-To: <CALvZod4oaj9MpBDVUp9KGmnqu4F3UxjXgOLkrkvmRfFjA7F1dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, Apr 26, 2022 at 10:23:32PM -0700, Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
> [...]
> >
> > +static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p)
> > +{
> > + struct mem_cgroup *memcg;
> > +
>
> Do we need memcg_kmem_enabled() check here or maybe
> mem_cgroup_from_obj() should be doing memcg_kmem_enabled() instead of
> mem_cgroup_disabled() as we can have "cgroup.memory=nokmem" boot
> param.
I reckon such a guard is on the charge side and readers should treat
NULL and root_mem_group equally. Or is there a case when these two are
different?
(I can see it's different semantics when stored in current->active_memcg
(and active_memcg() getter) but for such "outer" callers like here it
seems equal.)
Regards,
Michal
next prev parent reply other threads:[~2022-04-27 12:22 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 7:17 [PATCH RFC] net: memcg accounting for veth devices Vasily Averin
2022-02-28 14:36 ` Luis Chamberlain
2022-03-01 18:09 ` Shakeel Butt
2022-03-01 18:28 ` Luis Chamberlain
2022-03-01 20:50 ` Eric W. Biederman
2022-03-01 21:25 ` Luis Chamberlain
2022-03-01 21:31 ` Luis Chamberlain
2022-03-02 14:43 ` Eric W. Biederman
2022-03-02 21:52 ` Luis Chamberlain
2022-03-02 13:30 ` King, Colin
2022-04-11 9:40 ` problem with accounting of allocations called from __net_init hooks Vasily Averin
2022-04-17 6:39 ` [PATCH memcg RFC] net: set proper memcg for net_init hooks allocations Vasily Averin
2022-04-21 15:56 ` Shakeel Butt
2022-04-22 20:01 ` Vasily Averin
2022-04-22 20:09 ` Vasily Averin
2022-04-22 20:22 ` Shakeel Butt
2022-04-23 7:56 ` [PATCH] " Vasily Averin
2022-04-23 7:56 ` Vasily Averin
2022-04-23 9:39 ` kernel test robot
2022-04-23 9:39 ` kernel test robot
2022-04-23 9:39 ` kernel test robot
2022-04-23 9:39 ` kernel test robot
2022-04-23 10:31 ` kernel test robot
2022-04-23 15:38 ` [PATCH memcg v2] " Vasily Averin
2022-04-24 14:46 ` [net] 3b379e5391: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2022-04-24 14:46 ` kernel test robot
2022-04-25 10:56 ` [PATCH memcg v3] net: set proper memcg for net_init hooks allocations Vasily Averin
2022-04-25 10:56 ` Vasily Averin
2022-04-26 2:50 ` Roman Gushchin
2022-04-26 5:58 ` Vasily Averin
2022-04-26 5:58 ` Vasily Averin
2022-04-26 6:43 ` [PATCH memcg v4] " Vasily Averin
2022-04-26 22:13 ` Roman Gushchin
2022-04-26 22:13 ` Roman Gushchin
2022-04-27 5:23 ` Shakeel Butt
2022-04-27 12:22 ` Michal Koutný [this message]
2022-04-27 12:22 ` Michal Koutný
2022-04-27 15:06 ` Shakeel Butt
2022-04-27 15:06 ` Shakeel Butt
2022-04-27 22:16 ` Vasily Averin
2022-04-27 22:16 ` Vasily Averin
2022-04-27 22:36 ` Roman Gushchin
2022-04-28 4:37 ` Vasily Averin
2022-04-28 4:37 ` Vasily Averin
2022-04-27 22:47 ` Shakeel Butt
2022-04-27 22:47 ` Shakeel Butt
2022-05-01 13:44 ` Vasily Averin
2022-05-01 13:44 ` Vasily Averin
2022-05-01 21:09 ` Roman Gushchin
2022-05-01 21:09 ` Roman Gushchin
2022-05-02 0:10 ` [PATCH memcg v5] " Vasily Averin
2022-05-30 8:57 ` Vasily Averin
2022-05-30 8:57 ` Vasily Averin
2022-06-03 4:19 ` [PATCH memcg v6] " Vasily Averin
2022-06-03 4:19 ` Vasily Averin
2022-06-06 13:49 ` Qian Cai
2022-06-06 13:49 ` Qian Cai
2022-06-06 17:37 ` Vasily Averin
2022-06-06 18:43 ` Qian Cai
2022-06-06 18:43 ` Qian Cai
2022-06-06 18:45 ` Vasily Averin
2022-06-06 18:45 ` Vasily Averin
2022-06-07 5:58 ` Shakeel Butt
2022-06-07 5:58 ` Shakeel Butt
2022-06-07 12:37 ` Vasily Averin
2022-06-07 12:37 ` Vasily Averin
2022-06-07 14:10 ` Shakeel Butt
2022-06-07 14:10 ` Shakeel Butt
2022-09-18 9:28 ` [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) Anatoly Pugachev
2022-09-21 14:41 ` Anatoly Pugachev
2022-09-21 14:44 ` Anatoly Pugachev
2022-09-21 14:44 ` Anatoly Pugachev
2022-09-21 17:02 ` Michal Koutný
2022-09-21 17:02 ` Michal Koutný
2022-09-26 13:06 ` Anatoly Pugachev
2022-09-26 13:06 ` Anatoly Pugachev
2022-09-26 17:28 ` Jakub Kicinski
2022-09-26 17:28 ` Jakub Kicinski
2022-09-26 17:32 ` Shakeel Butt
2022-09-26 17:32 ` Shakeel Butt
2022-09-26 17:36 ` Andrew Morton
2022-09-26 17:36 ` Andrew Morton
2022-09-26 19:00 ` Shakeel Butt
2022-09-27 9:54 ` Vlastimil Babka
2022-09-27 9:54 ` Vlastimil Babka
2022-09-28 7:54 ` Thorsten Leemhuis
2022-09-28 7:21 ` [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220427122232.GA9823@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kernel@openvz.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
--cc=vvs@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.