From: Shakeel Butt <shakeelb@google.com> To: Vasily Averin <vvs@openvz.org> Cc: "Qian Cai" <quic_qiancai@quicinc.com>, "Roman Gushchin" <roman.gushchin@linux.dev>, "Andrew Morton" <akpm@linux-foundation.org>, kernel@openvz.org, LKML <linux-kernel@vger.kernel.org>, "Linux MM" <linux-mm@kvack.org>, "Michal Koutný" <mkoutny@suse.com>, "Vlastimil Babka" <vbabka@suse.cz>, "Michal Hocko" <mhocko@suse.com>, "Florian Westphal" <fw@strlen.de>, "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Eric Dumazet" <edumazet@google.com>, Cgroups <cgroups@vger.kernel.org> Subject: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations Date: Mon, 6 Jun 2022 22:58:45 -0700 [thread overview] Message-ID: <CALvZod7+tpgKSQpMAgNKDtcsimcSjoh4rbKmUsy3G=QcRHci+Q@mail.gmail.com> (raw) In-Reply-To: <360a2672-65a7-4ad4-c8b8-cc4c1f0c02cd@openvz.org> On Mon, Jun 6, 2022 at 11:45 AM Vasily Averin <vvs@openvz.org> wrote: > [...] > > As far as I understand this report means that 'init_net' have incorrect > virtual address on arm64. So, the two call stacks tell the addresses belong to the kernel modules (nfnetlink and nf_tables) whose underlying memory is allocated through vmalloc and virt_to_page() does not work on vmalloc() addresses. > > Roman, Shakeel, I need your help > > Should we perhaps verify kaddr via virt_addr_valid() before using virt_to_page() > If so, where it should be checked? I think virt_addr_valid() check in mem_cgroup_from_obj() should work but I think it is expensive on the arm64 platform. The cheaper and a bit hacky way to avoid such addresses is to directly use is_vmalloc_addr() directly.
WARNING: multiple messages have this Message-ID (diff)
From: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> To: Vasily Averin <vvs-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> Cc: "Qian Cai" <quic_qiancai-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org>, "Roman Gushchin" <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>, "Andrew Morton" <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Linux MM" <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>, "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>, "Vlastimil Babka" <vbabka-AlSwsSmVLrQ@public.gmane.org>, "Michal Hocko" <mhocko-IBi9RG/b67k@public.gmane.org>, "Florian Westphal" <fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, "Jakub Kicinski" <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Paolo Abeni" <pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "Eric Dumazet" <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations Date: Mon, 6 Jun 2022 22:58:45 -0700 [thread overview] Message-ID: <CALvZod7+tpgKSQpMAgNKDtcsimcSjoh4rbKmUsy3G=QcRHci+Q@mail.gmail.com> (raw) In-Reply-To: <360a2672-65a7-4ad4-c8b8-cc4c1f0c02cd-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> On Mon, Jun 6, 2022 at 11:45 AM Vasily Averin <vvs-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> wrote: > [...] > > As far as I understand this report means that 'init_net' have incorrect > virtual address on arm64. So, the two call stacks tell the addresses belong to the kernel modules (nfnetlink and nf_tables) whose underlying memory is allocated through vmalloc and virt_to_page() does not work on vmalloc() addresses. > > Roman, Shakeel, I need your help > > Should we perhaps verify kaddr via virt_addr_valid() before using virt_to_page() > If so, where it should be checked? I think virt_addr_valid() check in mem_cgroup_from_obj() should work but I think it is expensive on the arm64 platform. The cheaper and a bit hacky way to avoid such addresses is to directly use is_vmalloc_addr() directly.
next prev parent reply other threads:[~2022-06-07 5:59 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-28 7:17 [PATCH RFC] net: memcg accounting for veth devices Vasily Averin 2022-02-28 14:36 ` Luis Chamberlain 2022-03-01 18:09 ` Shakeel Butt 2022-03-01 18:28 ` Luis Chamberlain 2022-03-01 20:50 ` Eric W. Biederman 2022-03-01 21:25 ` Luis Chamberlain 2022-03-01 21:31 ` Luis Chamberlain 2022-03-02 14:43 ` Eric W. Biederman 2022-03-02 21:52 ` Luis Chamberlain 2022-03-02 13:30 ` King, Colin 2022-04-11 9:40 ` problem with accounting of allocations called from __net_init hooks Vasily Averin 2022-04-17 6:39 ` [PATCH memcg RFC] net: set proper memcg for net_init hooks allocations Vasily Averin 2022-04-21 15:56 ` Shakeel Butt 2022-04-22 20:01 ` Vasily Averin 2022-04-22 20:09 ` Vasily Averin 2022-04-22 20:22 ` Shakeel Butt 2022-04-23 7:56 ` [PATCH] " Vasily Averin 2022-04-23 7:56 ` Vasily Averin 2022-04-23 9:39 ` kernel test robot 2022-04-23 9:39 ` kernel test robot 2022-04-23 9:39 ` kernel test robot 2022-04-23 9:39 ` kernel test robot 2022-04-23 10:31 ` kernel test robot 2022-04-23 15:38 ` [PATCH memcg v2] " Vasily Averin 2022-04-24 14:46 ` [net] 3b379e5391: BUG:kernel_NULL_pointer_dereference,address kernel test robot 2022-04-24 14:46 ` kernel test robot 2022-04-25 10:56 ` [PATCH memcg v3] net: set proper memcg for net_init hooks allocations Vasily Averin 2022-04-25 10:56 ` Vasily Averin 2022-04-26 2:50 ` Roman Gushchin 2022-04-26 5:58 ` Vasily Averin 2022-04-26 5:58 ` Vasily Averin 2022-04-26 6:43 ` [PATCH memcg v4] " Vasily Averin 2022-04-26 22:13 ` Roman Gushchin 2022-04-26 22:13 ` Roman Gushchin 2022-04-27 5:23 ` Shakeel Butt 2022-04-27 12:22 ` Michal Koutný 2022-04-27 12:22 ` Michal Koutný 2022-04-27 15:06 ` Shakeel Butt 2022-04-27 15:06 ` Shakeel Butt 2022-04-27 22:16 ` Vasily Averin 2022-04-27 22:16 ` Vasily Averin 2022-04-27 22:36 ` Roman Gushchin 2022-04-28 4:37 ` Vasily Averin 2022-04-28 4:37 ` Vasily Averin 2022-04-27 22:47 ` Shakeel Butt 2022-04-27 22:47 ` Shakeel Butt 2022-05-01 13:44 ` Vasily Averin 2022-05-01 13:44 ` Vasily Averin 2022-05-01 21:09 ` Roman Gushchin 2022-05-01 21:09 ` Roman Gushchin 2022-05-02 0:10 ` [PATCH memcg v5] " Vasily Averin 2022-05-30 8:57 ` Vasily Averin 2022-05-30 8:57 ` Vasily Averin 2022-06-03 4:19 ` [PATCH memcg v6] " Vasily Averin 2022-06-03 4:19 ` Vasily Averin 2022-06-06 13:49 ` Qian Cai 2022-06-06 13:49 ` Qian Cai 2022-06-06 17:37 ` Vasily Averin 2022-06-06 18:43 ` Qian Cai 2022-06-06 18:43 ` Qian Cai 2022-06-06 18:45 ` Vasily Averin 2022-06-06 18:45 ` Vasily Averin 2022-06-07 5:58 ` Shakeel Butt [this message] 2022-06-07 5:58 ` Shakeel Butt 2022-06-07 12:37 ` Vasily Averin 2022-06-07 12:37 ` Vasily Averin 2022-06-07 14:10 ` Shakeel Butt 2022-06-07 14:10 ` Shakeel Butt 2022-09-18 9:28 ` [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) Anatoly Pugachev 2022-09-21 14:41 ` Anatoly Pugachev 2022-09-21 14:44 ` Anatoly Pugachev 2022-09-21 14:44 ` Anatoly Pugachev 2022-09-21 17:02 ` Michal Koutný 2022-09-21 17:02 ` Michal Koutný 2022-09-26 13:06 ` Anatoly Pugachev 2022-09-26 13:06 ` Anatoly Pugachev 2022-09-26 17:28 ` Jakub Kicinski 2022-09-26 17:28 ` Jakub Kicinski 2022-09-26 17:32 ` Shakeel Butt 2022-09-26 17:32 ` Shakeel Butt 2022-09-26 17:36 ` Andrew Morton 2022-09-26 17:36 ` Andrew Morton 2022-09-26 19:00 ` Shakeel Butt 2022-09-27 9:54 ` Vlastimil Babka 2022-09-27 9:54 ` Vlastimil Babka 2022-09-28 7:54 ` Thorsten Leemhuis 2022-09-28 7:21 ` [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) #forregzbot Thorsten Leemhuis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALvZod7+tpgKSQpMAgNKDtcsimcSjoh4rbKmUsy3G=QcRHci+Q@mail.gmail.com' \ --to=shakeelb@google.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=fw@strlen.de \ --cc=kernel@openvz.org \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=mkoutny@suse.com \ --cc=pabeni@redhat.com \ --cc=quic_qiancai@quicinc.com \ --cc=roman.gushchin@linux.dev \ --cc=vbabka@suse.cz \ --cc=vvs@openvz.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.