From: "Jouni Högander" <jouni.hogander@intel.com> To: intel-gfx@lists.freedesktop.org Cc: "Jouni Högander" <jouni.hogander@intel.com>, "Mark Pearson" <markpearson@lenovo.com>, "José Roberto de Souza" <jose.souza@intel.com>, dri-devel@lists.freedesktop.org, "Mika Kahola" <mika.kahola@intel.com> Subject: [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails Date: Tue, 10 May 2022 21:33:12 +0300 [thread overview] Message-ID: <20220510183313.1046628-3-jouni.hogander@intel.com> (raw) In-Reply-To: <20220510183313.1046628-1-jouni.hogander@intel.com> Currently we have some corner cases where area calculation fails. For these sel fetch area calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. One of such for example is big fb with offset. We don't have usable offset in psr2_sel_fetch_update. Currently it's open what is the proper way to fix this corner case. Use full update for now. v2: Commit message modified v3: Print out debug info once when area calculation fails Cc: José Roberto de Souza <jose.souza@intel.com> Cc: Mika Kahola <mika.kahola@intel.com> Cc: Mark Pearson <markpearson@lenovo.com> Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 06db407e2749..3561c218cfb1 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -1685,6 +1685,7 @@ static bool psr2_sel_fetch_pipe_state_supported(const struct intel_crtc_state *c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, struct intel_crtc *crtc) { + struct drm_i915_private *dev_priv = to_i915(state->base.dev); struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc); struct drm_rect pipe_clip = { .x1 = 0, .y1 = -1, .x2 = INT_MAX, .y2 = -1 }; struct intel_plane_state *new_plane_state, *old_plane_state; @@ -1770,6 +1771,17 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, clip_area_update(&pipe_clip, &damaged_area); } + /* + * TODO: For now we are just using full update in case + * selective fetch area calculation fails. To optimize this we + * should identify cases where this happens and fix the area + * calculation for those. + */ + if (pipe_clip.y1 == -1) { + drm_dbg_once_kms(&dev_priv->drm, "No selective fetch area, using full update"); + full_update = true; + } + if (full_update) goto skip_sel_fetch_set_loop; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Jouni Högander" <jouni.hogander@intel.com> To: intel-gfx@lists.freedesktop.org Cc: Mark Pearson <markpearson@lenovo.com>, dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails Date: Tue, 10 May 2022 21:33:12 +0300 [thread overview] Message-ID: <20220510183313.1046628-3-jouni.hogander@intel.com> (raw) In-Reply-To: <20220510183313.1046628-1-jouni.hogander@intel.com> Currently we have some corner cases where area calculation fails. For these sel fetch area calculation ends up having update area as y1 = 0, y2 = 4. Instead of these values safer option is full update. One of such for example is big fb with offset. We don't have usable offset in psr2_sel_fetch_update. Currently it's open what is the proper way to fix this corner case. Use full update for now. v2: Commit message modified v3: Print out debug info once when area calculation fails Cc: José Roberto de Souza <jose.souza@intel.com> Cc: Mika Kahola <mika.kahola@intel.com> Cc: Mark Pearson <markpearson@lenovo.com> Signed-off-by: Jouni Högander <jouni.hogander@intel.com> --- drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c index 06db407e2749..3561c218cfb1 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -1685,6 +1685,7 @@ static bool psr2_sel_fetch_pipe_state_supported(const struct intel_crtc_state *c int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, struct intel_crtc *crtc) { + struct drm_i915_private *dev_priv = to_i915(state->base.dev); struct intel_crtc_state *crtc_state = intel_atomic_get_new_crtc_state(state, crtc); struct drm_rect pipe_clip = { .x1 = 0, .y1 = -1, .x2 = INT_MAX, .y2 = -1 }; struct intel_plane_state *new_plane_state, *old_plane_state; @@ -1770,6 +1771,17 @@ int intel_psr2_sel_fetch_update(struct intel_atomic_state *state, clip_area_update(&pipe_clip, &damaged_area); } + /* + * TODO: For now we are just using full update in case + * selective fetch area calculation fails. To optimize this we + * should identify cases where this happens and fix the area + * calculation for those. + */ + if (pipe_clip.y1 == -1) { + drm_dbg_once_kms(&dev_priv->drm, "No selective fetch area, using full update"); + full_update = true; + } + if (full_update) goto skip_sel_fetch_set_loop; -- 2.25.1
next prev parent reply other threads:[~2022-05-10 18:33 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-10 18:33 [PATCH v3 0/3] Fixes for selective fetch area calculation Jouni Högander 2022-05-10 18:33 ` [Intel-gfx] " Jouni Högander 2022-05-10 18:33 ` [PATCH v3 1/3] drm/print: Add drm_debug_once* macros Jouni Högander 2022-05-10 18:33 ` [Intel-gfx] " Jouni Högander 2022-05-10 19:22 ` Souza, Jose 2022-05-10 19:22 ` [Intel-gfx] " Souza, Jose 2022-05-10 18:33 ` Jouni Högander [this message] 2022-05-10 18:33 ` [Intel-gfx] [PATCH v3 2/3] drm/i915/psr: Use full update In case of area calculation fails Jouni Högander 2022-05-10 18:52 ` Souza, Jose 2022-05-10 18:52 ` [Intel-gfx] " Souza, Jose 2022-05-10 18:33 ` [PATCH v3 3/3] drm/i915: Ensure damage clip area is within pipe area Jouni Högander 2022-05-10 18:33 ` [Intel-gfx] " Jouni Högander 2022-05-10 18:53 ` Souza, Jose 2022-05-10 18:53 ` [Intel-gfx] " Souza, Jose 2022-05-10 19:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes for selective fetch area calculation (rev3) Patchwork 2022-05-10 19:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-05-10 23:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220510183313.1046628-3-jouni.hogander@intel.com \ --to=jouni.hogander@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jose.souza@intel.com \ --cc=markpearson@lenovo.com \ --cc=mika.kahola@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.