From: Wupeng Ma <mawupeng1@huawei.com>
To: <corbet@lwn.net>, <will@kernel.org>, <ardb@kernel.org>,
<catalin.marinas@arm.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>, <rppt@kernel.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<mawupeng1@huawei.com>, <anshuman.khandual@arm.com>,
<thunder.leizhen@huawei.com>, <wangkefeng.wang@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <chenzhou10@huawei.com>,
<vijayb@linux.microsoft.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages
Date: Tue, 7 Jun 2022 17:38:02 +0800 [thread overview]
Message-ID: <20220607093805.1354256-4-mawupeng1@huawei.com> (raw)
In-Reply-To: <20220607093805.1354256-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
If system has mirrored memory, memblock will try to allocate mirrored
memory firstly and fallback to non-mirrored memory when fails, but if with
limited mirrored memory or some numa node without mirrored memory, lots of
warning message about memblock allocation will occur.
This patch ratelimit the warning message to avoid a very long print during
bootup.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/memblock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index e4f03a6e8e56..b1d2a0009733 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -327,7 +327,7 @@ static phys_addr_t __init_memblock memblock_find_in_range(phys_addr_t start,
NUMA_NO_NODE, flags);
if (!ret && (flags & MEMBLOCK_MIRROR)) {
- pr_warn("Could not allocate %pap bytes of mirrored memory\n",
+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
&size);
flags &= ~MEMBLOCK_MIRROR;
goto again;
@@ -1384,7 +1384,7 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size,
if (flags & MEMBLOCK_MIRROR) {
flags &= ~MEMBLOCK_MIRROR;
- pr_warn("Could not allocate %pap bytes of mirrored memory\n",
+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
&size);
goto again;
}
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Wupeng Ma <mawupeng1@huawei.com>
To: <corbet@lwn.net>, <will@kernel.org>, <ardb@kernel.org>,
<catalin.marinas@arm.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>, <rppt@kernel.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<mawupeng1@huawei.com>, <anshuman.khandual@arm.com>,
<thunder.leizhen@huawei.com>, <wangkefeng.wang@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <chenzhou10@huawei.com>,
<vijayb@linux.microsoft.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages
Date: Tue, 7 Jun 2022 17:38:02 +0800 [thread overview]
Message-ID: <20220607093805.1354256-4-mawupeng1@huawei.com> (raw)
In-Reply-To: <20220607093805.1354256-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
If system has mirrored memory, memblock will try to allocate mirrored
memory firstly and fallback to non-mirrored memory when fails, but if with
limited mirrored memory or some numa node without mirrored memory, lots of
warning message about memblock allocation will occur.
This patch ratelimit the warning message to avoid a very long print during
bootup.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/memblock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index e4f03a6e8e56..b1d2a0009733 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -327,7 +327,7 @@ static phys_addr_t __init_memblock memblock_find_in_range(phys_addr_t start,
NUMA_NO_NODE, flags);
if (!ret && (flags & MEMBLOCK_MIRROR)) {
- pr_warn("Could not allocate %pap bytes of mirrored memory\n",
+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
&size);
flags &= ~MEMBLOCK_MIRROR;
goto again;
@@ -1384,7 +1384,7 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size,
if (flags & MEMBLOCK_MIRROR) {
flags &= ~MEMBLOCK_MIRROR;
- pr_warn("Could not allocate %pap bytes of mirrored memory\n",
+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
&size);
goto again;
}
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Wupeng Ma <mawupeng1@huawei.com>
To: <corbet@lwn.net>, <will@kernel.org>, <ardb@kernel.org>,
<catalin.marinas@arm.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>, <rppt@kernel.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<mawupeng1@huawei.com>, <anshuman.khandual@arm.com>,
<thunder.leizhen@huawei.com>, <wangkefeng.wang@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <chenzhou10@huawei.com>,
<vijayb@linux.microsoft.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages
Date: Tue, 7 Jun 2022 17:38:02 +0800 [thread overview]
Message-ID: <20220607093805.1354256-4-mawupeng1@huawei.com> (raw)
In-Reply-To: <20220607093805.1354256-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
If system has mirrored memory, memblock will try to allocate mirrored
memory firstly and fallback to non-mirrored memory when fails, but if with
limited mirrored memory or some numa node without mirrored memory, lots of
warning message about memblock allocation will occur.
This patch ratelimit the warning message to avoid a very long print during
bootup.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/memblock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index e4f03a6e8e56..b1d2a0009733 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -327,7 +327,7 @@ static phys_addr_t __init_memblock memblock_find_in_range(phys_addr_t start,
NUMA_NO_NODE, flags);
if (!ret && (flags & MEMBLOCK_MIRROR)) {
- pr_warn("Could not allocate %pap bytes of mirrored memory\n",
+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
&size);
flags &= ~MEMBLOCK_MIRROR;
goto again;
@@ -1384,7 +1384,7 @@ phys_addr_t __init memblock_alloc_range_nid(phys_addr_t size,
if (flags & MEMBLOCK_MIRROR) {
flags &= ~MEMBLOCK_MIRROR;
- pr_warn("Could not allocate %pap bytes of mirrored memory\n",
+ pr_warn_ratelimited("Could not allocate %pap bytes of mirrored memory\n",
&size);
goto again;
}
--
2.25.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-06-07 9:17 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 9:37 [PATCH v3 0/6] introduce mirrored memory support for arm64 Wupeng Ma
2022-06-07 9:37 ` Wupeng Ma
2022-06-07 9:37 ` Wupeng Ma
2022-06-07 9:38 ` [PATCH v3 1/6] efi: Make efi_find_mirror() public Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-10 9:22 ` Kefeng Wang
2022-06-10 9:22 ` Kefeng Wang
2022-06-10 9:22 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-10 9:27 ` Kefeng Wang
2022-06-10 9:27 ` Kefeng Wang
2022-06-10 9:27 ` Kefeng Wang
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-07 9:38 ` Wupeng Ma [this message]
2022-06-07 9:38 ` [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 12:24 ` David Hildenbrand
2022-06-07 12:24 ` David Hildenbrand
2022-06-07 12:24 ` David Hildenbrand
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 10:02 ` Anshuman Khandual
2022-06-08 10:02 ` Anshuman Khandual
2022-06-08 10:02 ` Anshuman Khandual
2022-06-10 9:29 ` Kefeng Wang
2022-06-10 9:29 ` Kefeng Wang
2022-06-10 9:29 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 4/6] mm: Demote warning message in vmemmap_verify() to debug level Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 12:25 ` David Hildenbrand
2022-06-07 12:25 ` David Hildenbrand
2022-06-07 12:25 ` David Hildenbrand
2022-06-08 1:26 ` mawupeng
2022-06-08 1:26 ` mawupeng
2022-06-08 1:26 ` mawupeng
2022-06-08 10:00 ` Anshuman Khandual
2022-06-08 10:00 ` Anshuman Khandual
2022-06-08 10:00 ` Anshuman Khandual
2022-06-09 8:13 ` mawupeng
2022-06-09 8:13 ` mawupeng
2022-06-09 8:13 ` mawupeng
2022-06-10 9:35 ` Kefeng Wang
2022-06-10 9:35 ` Kefeng Wang
2022-06-10 9:35 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 5/6] mm: Add mirror flag back on initrd memory Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-08 7:27 ` mawupeng
2022-06-08 7:27 ` mawupeng
2022-06-08 7:27 ` mawupeng
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-09 8:15 ` mawupeng
2022-06-09 8:15 ` mawupeng
2022-06-09 8:15 ` mawupeng
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-07 9:38 ` [PATCH v3 6/6] efi: Disable mirror feature if kernelcore is not specified Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 11:23 ` [PATCH v3 0/6] introduce mirrored memory support for arm64 Ard Biesheuvel
2022-06-10 11:23 ` Ard Biesheuvel
2022-06-10 11:23 ` Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-11 9:56 ` Mike Rapoport
2022-06-11 9:56 ` Mike Rapoport
2022-06-11 9:56 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607093805.1354256-4-mawupeng1@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy@infradead.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chenzhou10@huawei.com \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dvhart@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vijayb@linux.microsoft.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.