From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Wupeng Ma <mawupeng1@huawei.com>, <corbet@lwn.net>,
<will@kernel.org>, <ardb@kernel.org>, <catalin.marinas@arm.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>, <rppt@kernel.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<anshuman.khandual@arm.com>, <thunder.leizhen@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <vijayb@linux.microsoft.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges
Date: Fri, 10 Jun 2022 17:27:31 +0800 [thread overview]
Message-ID: <bfa0b919-fbc1-056c-4ed9-e940edfb6125@huawei.com> (raw)
In-Reply-To: <20220607093805.1354256-3-mawupeng1@huawei.com>
On 2022/6/7 17:38, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
>
> Commit b05b9f5f9dcf ("x86, mirror: x86 enabling - find mirrored memory ranges")
> introduced mirrored memory support for x86 and this could be used on arm64.
>
> Since we only support this feature on arm64, efi_find_mirror() won't be placed
> into efi_init(), which is used by riscv/arm/arm64, it is added in setup_arch()
> to scan the memory map and mark mirrored memory in memblock.
Move into efi_init() looks better, it won't bring negative effects on
arm/riscv.
but let's maintainer to make a decision.
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> arch/arm64/kernel/setup.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 8090130b544b..e3537646b6f7 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2301,7 +2301,7 @@
>
> keepinitrd [HW,ARM]
>
> - kernelcore= [KNL,X86,IA-64,PPC]
> + kernelcore= [KNL,X86,IA-64,PPC,ARM64]
> Format: nn[KMGTPE] | nn% | "mirror"
> This parameter specifies the amount of memory usable by
> the kernel for non-movable allocations. The requested
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index cf3a759f10d4..6e9acd7ecf0f 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -328,6 +328,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
>
> xen_early_init();
> efi_init();
> + efi_find_mirror();
>
> if (!efi_enabled(EFI_BOOT) && ((u64)_text % MIN_KIMG_ALIGN) != 0)
> pr_warn(FW_BUG "Kernel image misaligned at boot, please fix your bootloader!");
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Wupeng Ma <mawupeng1@huawei.com>, <corbet@lwn.net>,
<will@kernel.org>, <ardb@kernel.org>, <catalin.marinas@arm.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>, <rppt@kernel.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<anshuman.khandual@arm.com>, <thunder.leizhen@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <vijayb@linux.microsoft.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges
Date: Fri, 10 Jun 2022 17:27:31 +0800 [thread overview]
Message-ID: <bfa0b919-fbc1-056c-4ed9-e940edfb6125@huawei.com> (raw)
In-Reply-To: <20220607093805.1354256-3-mawupeng1@huawei.com>
On 2022/6/7 17:38, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
>
> Commit b05b9f5f9dcf ("x86, mirror: x86 enabling - find mirrored memory ranges")
> introduced mirrored memory support for x86 and this could be used on arm64.
>
> Since we only support this feature on arm64, efi_find_mirror() won't be placed
> into efi_init(), which is used by riscv/arm/arm64, it is added in setup_arch()
> to scan the memory map and mark mirrored memory in memblock.
Move into efi_init() looks better, it won't bring negative effects on
arm/riscv.
but let's maintainer to make a decision.
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> arch/arm64/kernel/setup.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 8090130b544b..e3537646b6f7 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2301,7 +2301,7 @@
>
> keepinitrd [HW,ARM]
>
> - kernelcore= [KNL,X86,IA-64,PPC]
> + kernelcore= [KNL,X86,IA-64,PPC,ARM64]
> Format: nn[KMGTPE] | nn% | "mirror"
> This parameter specifies the amount of memory usable by
> the kernel for non-movable allocations. The requested
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index cf3a759f10d4..6e9acd7ecf0f 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -328,6 +328,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
>
> xen_early_init();
> efi_init();
> + efi_find_mirror();
>
> if (!efi_enabled(EFI_BOOT) && ((u64)_text % MIN_KIMG_ALIGN) != 0)
> pr_warn(FW_BUG "Kernel image misaligned at boot, please fix your bootloader!");
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Wupeng Ma <mawupeng1@huawei.com>, <corbet@lwn.net>,
<will@kernel.org>, <ardb@kernel.org>, <catalin.marinas@arm.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
<dvhart@infradead.org>, <andy@infradead.org>, <rppt@kernel.org>,
<akpm@linux-foundation.org>, <paul.walmsley@sifive.com>,
<palmer@dabbelt.com>, <aou@eecs.berkeley.edu>,
<paulmck@kernel.org>, <keescook@chromium.org>,
<songmuchun@bytedance.com>, <rdunlap@infradead.org>,
<damien.lemoal@opensource.wdc.com>, <swboyd@chromium.org>,
<wei.liu@kernel.org>, <robin.murphy@arm.com>, <david@redhat.com>,
<anshuman.khandual@arm.com>, <thunder.leizhen@huawei.com>,
<gpiccoli@igalia.com>, <chenhuacai@kernel.org>,
<geert@linux-m68k.org>, <vijayb@linux.microsoft.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-efi@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges
Date: Fri, 10 Jun 2022 17:27:31 +0800 [thread overview]
Message-ID: <bfa0b919-fbc1-056c-4ed9-e940edfb6125@huawei.com> (raw)
In-Reply-To: <20220607093805.1354256-3-mawupeng1@huawei.com>
On 2022/6/7 17:38, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@huawei.com>
>
> Commit b05b9f5f9dcf ("x86, mirror: x86 enabling - find mirrored memory ranges")
> introduced mirrored memory support for x86 and this could be used on arm64.
>
> Since we only support this feature on arm64, efi_find_mirror() won't be placed
> into efi_init(), which is used by riscv/arm/arm64, it is added in setup_arch()
> to scan the memory map and mark mirrored memory in memblock.
Move into efi_init() looks better, it won't bring negative effects on
arm/riscv.
but let's maintainer to make a decision.
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>
> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 2 +-
> arch/arm64/kernel/setup.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 8090130b544b..e3537646b6f7 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -2301,7 +2301,7 @@
>
> keepinitrd [HW,ARM]
>
> - kernelcore= [KNL,X86,IA-64,PPC]
> + kernelcore= [KNL,X86,IA-64,PPC,ARM64]
> Format: nn[KMGTPE] | nn% | "mirror"
> This parameter specifies the amount of memory usable by
> the kernel for non-movable allocations. The requested
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index cf3a759f10d4..6e9acd7ecf0f 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -328,6 +328,7 @@ void __init __no_sanitize_address setup_arch(char **cmdline_p)
>
> xen_early_init();
> efi_init();
> + efi_find_mirror();
>
> if (!efi_enabled(EFI_BOOT) && ((u64)_text % MIN_KIMG_ALIGN) != 0)
> pr_warn(FW_BUG "Kernel image misaligned at boot, please fix your bootloader!");
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-10 9:29 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 9:37 [PATCH v3 0/6] introduce mirrored memory support for arm64 Wupeng Ma
2022-06-07 9:37 ` Wupeng Ma
2022-06-07 9:37 ` Wupeng Ma
2022-06-07 9:38 ` [PATCH v3 1/6] efi: Make efi_find_mirror() public Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-10 9:22 ` Kefeng Wang
2022-06-10 9:22 ` Kefeng Wang
2022-06-10 9:22 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-10 9:27 ` Kefeng Wang [this message]
2022-06-10 9:27 ` Kefeng Wang
2022-06-10 9:27 ` Kefeng Wang
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-07 9:38 ` [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 12:24 ` David Hildenbrand
2022-06-07 12:24 ` David Hildenbrand
2022-06-07 12:24 ` David Hildenbrand
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 10:02 ` Anshuman Khandual
2022-06-08 10:02 ` Anshuman Khandual
2022-06-08 10:02 ` Anshuman Khandual
2022-06-10 9:29 ` Kefeng Wang
2022-06-10 9:29 ` Kefeng Wang
2022-06-10 9:29 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 4/6] mm: Demote warning message in vmemmap_verify() to debug level Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 12:25 ` David Hildenbrand
2022-06-07 12:25 ` David Hildenbrand
2022-06-07 12:25 ` David Hildenbrand
2022-06-08 1:26 ` mawupeng
2022-06-08 1:26 ` mawupeng
2022-06-08 1:26 ` mawupeng
2022-06-08 10:00 ` Anshuman Khandual
2022-06-08 10:00 ` Anshuman Khandual
2022-06-08 10:00 ` Anshuman Khandual
2022-06-09 8:13 ` mawupeng
2022-06-09 8:13 ` mawupeng
2022-06-09 8:13 ` mawupeng
2022-06-10 9:35 ` Kefeng Wang
2022-06-10 9:35 ` Kefeng Wang
2022-06-10 9:35 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 5/6] mm: Add mirror flag back on initrd memory Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-08 7:27 ` mawupeng
2022-06-08 7:27 ` mawupeng
2022-06-08 7:27 ` mawupeng
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-09 8:15 ` mawupeng
2022-06-09 8:15 ` mawupeng
2022-06-09 8:15 ` mawupeng
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-07 9:38 ` [PATCH v3 6/6] efi: Disable mirror feature if kernelcore is not specified Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-07 9:38 ` Wupeng Ma
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 11:23 ` [PATCH v3 0/6] introduce mirrored memory support for arm64 Ard Biesheuvel
2022-06-10 11:23 ` Ard Biesheuvel
2022-06-10 11:23 ` Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-11 9:56 ` Mike Rapoport
2022-06-11 9:56 ` Mike Rapoport
2022-06-11 9:56 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa0b919-fbc1-056c-4ed9-e940edfb6125@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andy@infradead.org \
--cc=anshuman.khandual@arm.com \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dvhart@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mawupeng1@huawei.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vijayb@linux.microsoft.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.