From: Rob Herring <robh@kernel.org>
To: Conor Dooley <mail@conchuod.ie>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
dmaengine@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, Jose Abreu <joabreu@synopsys.com>,
devicetree@vger.kernel.org, Serge Semin <fancer.lancer@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Vinod Koul <vkoul@kernel.org>,
Dillon Min <dillon.minfei@gmail.com>,
linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Mark Brown <broonie@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Niklas Cassel <niklas.cassel@wdc.com>,
Rob Herring <robh+dt@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width
Date: Thu, 30 Jun 2022 10:57:17 -0600 [thread overview]
Message-ID: <20220630165717.GA2895317-robh@kernel.org> (raw)
In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie>
On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the
> Canaan k210 is wired up for a width of 4.
> Quoting Serge:
> The modern DW APB SSI controllers of v.4.* and newer also support the
> enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core
> version is auto-detected at run-time there is no way to create a
> DT-schema correctly constraining the Rx/Tx SPI bus widths.
> /endquote
>
> As such, drop the restriction on only supporting a bus width of 1.
>
> Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <mail@conchuod.ie>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
dmaengine@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel@vger.kernel.org, Jose Abreu <joabreu@synopsys.com>,
devicetree@vger.kernel.org,
Serge Semin <fancer.lancer@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Vinod Koul <vkoul@kernel.org>,
Dillon Min <dillon.minfei@gmail.com>,
linux-riscv@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Mark Brown <broonie@kernel.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor.dooley@microchip.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Niklas Cassel <niklas.cassel@wdc.com>,
Rob Herring <robh+dt@kernel.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width
Date: Thu, 30 Jun 2022 10:57:17 -0600 [thread overview]
Message-ID: <20220630165717.GA2895317-robh@kernel.org> (raw)
In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie>
On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the
> Canaan k210 is wired up for a width of 4.
> Quoting Serge:
> The modern DW APB SSI controllers of v.4.* and newer also support the
> enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core
> version is auto-detected at run-time there is no way to create a
> DT-schema correctly constraining the Rx/Tx SPI bus widths.
> /endquote
>
> As such, drop the restriction on only supporting a bus width of 1.
>
> Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <mail@conchuod.ie>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
alsa-devel@alsa-project.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-riscv@lists.infradead.org, Sam Ravnborg <sam@ravnborg.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Jose Abreu <joabreu@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
devicetree@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Mark Brown <broonie@kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dillon Min <dillon.minfei@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Serge Semin <fancer.lancer@gmail.com>,
linux-spi@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
dmaengine@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width
Date: Thu, 30 Jun 2022 10:57:17 -0600 [thread overview]
Message-ID: <20220630165717.GA2895317-robh@kernel.org> (raw)
In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie>
On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the
> Canaan k210 is wired up for a width of 4.
> Quoting Serge:
> The modern DW APB SSI controllers of v.4.* and newer also support the
> enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core
> version is auto-detected at run-time there is no way to create a
> DT-schema correctly constraining the Rx/Tx SPI bus widths.
> /endquote
>
> As such, drop the restriction on only supporting a bus width of 1.
>
> Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <mail@conchuod.ie>
Cc: Niklas Cassel <niklas.cassel@wdc.com>,
alsa-devel@alsa-project.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Thierry Reding <thierry.reding@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-riscv@lists.infradead.org, Sam Ravnborg <sam@ravnborg.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Jose Abreu <joabreu@synopsys.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
devicetree@vger.kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Mark Brown <broonie@kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Dillon Min <dillon.minfei@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Serge Semin <fancer.lancer@gmail.com>,
linux-spi@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Daniel Vetter <daniel@ffwll.ch>,
dmaengine@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width
Date: Thu, 30 Jun 2022 10:57:17 -0600 [thread overview]
Message-ID: <20220630165717.GA2895317-robh@kernel.org> (raw)
In-Reply-To: <20220629184343.3438856-5-mail@conchuod.ie>
On Wed, 29 Jun 2022 19:43:33 +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Most users of dw-apb-ssi use spi-{r,t}x-bus-width of 1, however the
> Canaan k210 is wired up for a width of 4.
> Quoting Serge:
> The modern DW APB SSI controllers of v.4.* and newer also support the
> enhanced SPI Modes too (Dual, Quad and Octal). Since the IP-core
> version is auto-detected at run-time there is no way to create a
> DT-schema correctly constraining the Rx/Tx SPI bus widths.
> /endquote
>
> As such, drop the restriction on only supporting a bus width of 1.
>
> Link: https://lore.kernel.org/all/20220620205654.g7fyipwytbww5757@mobilestation/
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ------
> 1 file changed, 6 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-06-30 16:57 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 18:43 [PATCH v3 00/15] Canaan devicetree fixes Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 01/15] dt-bindings: display: convert ilitek,ili9341.txt to dt-schema Conor Dooley
2022-06-29 18:43 ` [PATCH v3 01/15] dt-bindings: display: convert ilitek, ili9341.txt " Conor Dooley
2022-06-29 18:43 ` [PATCH v3 01/15] dt-bindings: display: convert ilitek,ili9341.txt " Conor Dooley
2022-06-29 18:43 ` [PATCH v3 02/15] dt-bindings: display: ili9341: document canaan kd233's lcd Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-07-01 19:38 ` Rob Herring
2022-07-01 19:38 ` Rob Herring
2022-07-01 19:38 ` Rob Herring
2022-07-01 19:38 ` Rob Herring
2022-06-29 18:43 ` [PATCH v3 03/15] ASoC: dt-bindings: convert designware-i2s to dt-schema Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-07-01 19:39 ` Rob Herring
2022-07-01 19:39 ` Rob Herring
2022-07-01 19:39 ` Rob Herring
2022-07-01 19:39 ` Rob Herring
2022-06-29 18:43 ` [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r, t}x-bus-width Conor Dooley
2022-06-30 16:57 ` Rob Herring [this message]
2022-06-30 16:57 ` [PATCH v3 04/15] spi: dt-bindings: dw-apb-ssi: update spi-{r,t}x-bus-width Rob Herring
2022-06-30 16:57 ` Rob Herring
2022-06-30 16:57 ` Rob Herring
2022-06-30 21:43 ` Serge Semin
2022-06-30 21:43 ` Serge Semin
2022-06-30 21:43 ` Serge Semin
2022-06-30 21:43 ` Serge Semin
2022-06-29 18:43 ` [PATCH v3 05/15] dt-bindings: dma: dw-axi-dmac: extend the number of interrupts Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-30 21:55 ` Serge Semin
2022-06-30 21:55 ` Serge Semin
2022-06-30 21:55 ` Serge Semin
2022-06-30 21:55 ` Serge Semin
2022-06-30 23:12 ` Conor.Dooley
2022-06-30 23:12 ` Conor.Dooley
2022-06-30 23:12 ` Conor.Dooley
2022-06-30 23:12 ` Conor.Dooley
2022-07-01 19:41 ` Rob Herring
2022-07-01 19:41 ` Rob Herring
2022-07-01 19:41 ` Rob Herring
2022-07-01 19:41 ` Rob Herring
2022-06-29 18:43 ` [PATCH v3 06/15] dt-bindings: memory-controllers: add canaan k210 sram controller Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 07/15] riscv: dts: canaan: fix the k210's memory node Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 08/15] riscv: dts: canaan: fix the k210's timer nodes Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-30 21:51 ` Serge Semin
2022-06-30 21:51 ` Serge Semin
2022-06-30 21:51 ` Serge Semin
2022-06-30 21:51 ` Serge Semin
2022-06-29 18:43 ` [PATCH v3 09/15] riscv: dts: canaan: fix mmc node names Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 10/15] riscv: dts: canaan: fix kd233 display spi frequency Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 11/15] riscv: dts: canaan: use custom compatible for k210 i2s Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 12/15] riscv: dts: canaan: remove spi-max-frequency from controllers Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 13/15] riscv: dts: canaan: fix bus {ranges,reg} warnings Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-30 16:49 ` Niklas Cassel
2022-06-30 16:49 ` Niklas Cassel
2022-06-30 16:49 ` Niklas Cassel
2022-06-30 16:49 ` Niklas Cassel
2022-06-30 17:02 ` Conor.Dooley
2022-06-30 17:02 ` Conor.Dooley
2022-06-30 17:02 ` Conor.Dooley
2022-06-30 17:02 ` Conor.Dooley
2022-06-30 19:31 ` Conor.Dooley
2022-06-30 19:31 ` Conor.Dooley
2022-06-30 19:31 ` Conor.Dooley
2022-06-30 19:31 ` Conor.Dooley
2022-06-29 18:43 ` [PATCH v3 14/15] riscv: dts: canaan: add specific compatible for kd233's LCD Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` [PATCH v3 15/15] riscv: dts: canaan: build all devicetress if SOC_CANAAN Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-29 18:43 ` Conor Dooley
2022-06-30 16:28 ` [PATCH v3 00/15] Canaan devicetree fixes Niklas Cassel
2022-06-30 16:28 ` Niklas Cassel
2022-06-30 16:28 ` Niklas Cassel
2022-06-30 16:28 ` Niklas Cassel
2022-06-30 16:38 ` Conor.Dooley
2022-06-30 16:38 ` Conor.Dooley
2022-06-30 16:38 ` Conor.Dooley
2022-06-30 16:38 ` Conor.Dooley
2022-06-30 17:53 ` Sudeep Holla
2022-06-30 17:53 ` Sudeep Holla
2022-06-30 17:53 ` Sudeep Holla
2022-06-30 17:53 ` Sudeep Holla
2022-06-30 18:01 ` Conor.Dooley
2022-06-30 18:01 ` Conor.Dooley
2022-06-30 18:01 ` Conor.Dooley
2022-06-30 18:01 ` Conor.Dooley
2022-06-30 18:21 ` Sudeep Holla
2022-06-30 18:21 ` Sudeep Holla
2022-06-30 18:21 ` Sudeep Holla
2022-06-30 18:21 ` Sudeep Holla
2022-06-30 18:30 ` Conor.Dooley
2022-06-30 18:30 ` Conor.Dooley
2022-06-30 18:30 ` Conor.Dooley
2022-06-30 18:30 ` Conor.Dooley
2022-06-30 21:16 ` Damien Le Moal
2022-06-30 21:16 ` Damien Le Moal
2022-06-30 21:16 ` Damien Le Moal
2022-06-30 21:16 ` Damien Le Moal
2022-07-01 11:14 ` Sudeep Holla
2022-07-01 11:14 ` Sudeep Holla
2022-07-01 11:14 ` Sudeep Holla
2022-07-01 11:14 ` Sudeep Holla
2022-07-01 10:31 ` (subset) " Mark Brown
2022-07-01 10:31 ` Mark Brown
2022-07-01 10:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220630165717.GA2895317-robh@kernel.org \
--to=robh@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fancer.lancer@gmail.com \
--cc=geert@linux-m68k.org \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=mail@conchuod.ie \
--cc=masahiroy@kernel.org \
--cc=niklas.cassel@wdc.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.