From: Kalesh Singh <kaleshsingh@google.com>
To: maz@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
madvenka@linux.microsoft.com, tabba@google.com,
oliver.upton@linux.dev
Cc: wangkefeng.wang@huawei.com, catalin.marinas@arm.com,
ast@kernel.org, vincenzo.frascino@arm.com, will@kernel.org,
kvmarm@lists.cs.columbia.edu, android-mm@google.com,
kernel-team@android.com, elver@google.com,
linux-arm-kernel@lists.infradead.org, andreyknvl@gmail.com,
linux-kernel@vger.kernel.org, mhiramat@kernel.org
Subject: [PATCH v6 13/17] KVM: arm64: Allocate shared pKVM hyp stacktrace buffers
Date: Tue, 26 Jul 2022 00:37:46 -0700 [thread overview]
Message-ID: <20220726073750.3219117-14-kaleshsingh@google.com> (raw)
In-Reply-To: <20220726073750.3219117-1-kaleshsingh@google.com>
In protected nVHE mode the host cannot directly access
hypervisor memory, so we will dump the hypervisor stacktrace
to a shared buffer with the host.
The minimum size for the buffer required, assuming the min frame
size of [x29, x30] (2 * sizeof(long)), is half the combined size of
the hypervisor and overflow stacks plus an additional entry to
delimit the end of the stacktrace.
The stacktrace buffers are used later in the series to dump the
nVHE hypervisor stacktrace when using protected-mode.
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
Reviewed-by: Fuad Tabba <tabba@google.com>
Tested-by: Fuad Tabba <tabba@google.com>
---
Changes in v6:
- Fix typo in commit text, per Fuad
- Add Fuad’s Reviewed-by and Tested-by tags
Changes in v5:
- Fix typo in commit text, per Marc
arch/arm64/include/asm/memory.h | 8 ++++++++
arch/arm64/kvm/hyp/nvhe/stacktrace.c | 4 ++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
index 0af70d9abede..cab80a9a4086 100644
--- a/arch/arm64/include/asm/memory.h
+++ b/arch/arm64/include/asm/memory.h
@@ -113,6 +113,14 @@
#define OVERFLOW_STACK_SIZE SZ_4K
+/*
+ * With the minimum frame size of [x29, x30], exactly half the combined
+ * sizes of the hyp and overflow stacks is the maximum size needed to
+ * save the unwinded stacktrace; plus an additional entry to delimit the
+ * end.
+ */
+#define NVHE_STACKTRACE_SIZE ((OVERFLOW_STACK_SIZE + PAGE_SIZE) / 2 + sizeof(long))
+
/*
* Alignment of kernel segments (e.g. .text, .data).
*
diff --git a/arch/arm64/kvm/hyp/nvhe/stacktrace.c b/arch/arm64/kvm/hyp/nvhe/stacktrace.c
index b8a280aa026a..e2edda92a108 100644
--- a/arch/arm64/kvm/hyp/nvhe/stacktrace.c
+++ b/arch/arm64/kvm/hyp/nvhe/stacktrace.c
@@ -34,6 +34,10 @@ static void hyp_prepare_backtrace(unsigned long fp, unsigned long pc)
stacktrace_info->pc = pc;
}
+#ifdef CONFIG_PROTECTED_NVHE_STACKTRACE
+DEFINE_PER_CPU(unsigned long [NVHE_STACKTRACE_SIZE/sizeof(long)], pkvm_stacktrace);
+#endif /* CONFIG_PROTECTED_NVHE_STACKTRACE */
+
/*
* kvm_nvhe_prepare_backtrace - prepare to dump the nVHE backtrace
*
--
2.37.1.359.gd136c6c3e2-goog
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Kalesh Singh <kaleshsingh@google.com>
To: maz@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
madvenka@linux.microsoft.com, tabba@google.com,
oliver.upton@linux.dev
Cc: will@kernel.org, qperret@google.com, kaleshsingh@google.com,
james.morse@arm.com, alexandru.elisei@arm.com,
suzuki.poulose@arm.com, catalin.marinas@arm.com,
andreyknvl@gmail.com, vincenzo.frascino@arm.com,
mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com,
elver@google.com, keirf@google.com, yuzenghui@huawei.com,
ardb@kernel.org, oupton@google.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
android-mm@google.com, kernel-team@android.com
Subject: [PATCH v6 13/17] KVM: arm64: Allocate shared pKVM hyp stacktrace buffers
Date: Tue, 26 Jul 2022 00:37:46 -0700 [thread overview]
Message-ID: <20220726073750.3219117-14-kaleshsingh@google.com> (raw)
In-Reply-To: <20220726073750.3219117-1-kaleshsingh@google.com>
In protected nVHE mode the host cannot directly access
hypervisor memory, so we will dump the hypervisor stacktrace
to a shared buffer with the host.
The minimum size for the buffer required, assuming the min frame
size of [x29, x30] (2 * sizeof(long)), is half the combined size of
the hypervisor and overflow stacks plus an additional entry to
delimit the end of the stacktrace.
The stacktrace buffers are used later in the series to dump the
nVHE hypervisor stacktrace when using protected-mode.
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
Reviewed-by: Fuad Tabba <tabba@google.com>
Tested-by: Fuad Tabba <tabba@google.com>
---
Changes in v6:
- Fix typo in commit text, per Fuad
- Add Fuad’s Reviewed-by and Tested-by tags
Changes in v5:
- Fix typo in commit text, per Marc
arch/arm64/include/asm/memory.h | 8 ++++++++
arch/arm64/kvm/hyp/nvhe/stacktrace.c | 4 ++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
index 0af70d9abede..cab80a9a4086 100644
--- a/arch/arm64/include/asm/memory.h
+++ b/arch/arm64/include/asm/memory.h
@@ -113,6 +113,14 @@
#define OVERFLOW_STACK_SIZE SZ_4K
+/*
+ * With the minimum frame size of [x29, x30], exactly half the combined
+ * sizes of the hyp and overflow stacks is the maximum size needed to
+ * save the unwinded stacktrace; plus an additional entry to delimit the
+ * end.
+ */
+#define NVHE_STACKTRACE_SIZE ((OVERFLOW_STACK_SIZE + PAGE_SIZE) / 2 + sizeof(long))
+
/*
* Alignment of kernel segments (e.g. .text, .data).
*
diff --git a/arch/arm64/kvm/hyp/nvhe/stacktrace.c b/arch/arm64/kvm/hyp/nvhe/stacktrace.c
index b8a280aa026a..e2edda92a108 100644
--- a/arch/arm64/kvm/hyp/nvhe/stacktrace.c
+++ b/arch/arm64/kvm/hyp/nvhe/stacktrace.c
@@ -34,6 +34,10 @@ static void hyp_prepare_backtrace(unsigned long fp, unsigned long pc)
stacktrace_info->pc = pc;
}
+#ifdef CONFIG_PROTECTED_NVHE_STACKTRACE
+DEFINE_PER_CPU(unsigned long [NVHE_STACKTRACE_SIZE/sizeof(long)], pkvm_stacktrace);
+#endif /* CONFIG_PROTECTED_NVHE_STACKTRACE */
+
/*
* kvm_nvhe_prepare_backtrace - prepare to dump the nVHE backtrace
*
--
2.37.1.359.gd136c6c3e2-goog
WARNING: multiple messages have this Message-ID (diff)
From: Kalesh Singh <kaleshsingh@google.com>
To: maz@kernel.org, mark.rutland@arm.com, broonie@kernel.org,
madvenka@linux.microsoft.com, tabba@google.com,
oliver.upton@linux.dev
Cc: will@kernel.org, qperret@google.com, kaleshsingh@google.com,
james.morse@arm.com, alexandru.elisei@arm.com,
suzuki.poulose@arm.com, catalin.marinas@arm.com,
andreyknvl@gmail.com, vincenzo.frascino@arm.com,
mhiramat@kernel.org, ast@kernel.org, wangkefeng.wang@huawei.com,
elver@google.com, keirf@google.com, yuzenghui@huawei.com,
ardb@kernel.org, oupton@google.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
android-mm@google.com, kernel-team@android.com
Subject: [PATCH v6 13/17] KVM: arm64: Allocate shared pKVM hyp stacktrace buffers
Date: Tue, 26 Jul 2022 00:37:46 -0700 [thread overview]
Message-ID: <20220726073750.3219117-14-kaleshsingh@google.com> (raw)
In-Reply-To: <20220726073750.3219117-1-kaleshsingh@google.com>
In protected nVHE mode the host cannot directly access
hypervisor memory, so we will dump the hypervisor stacktrace
to a shared buffer with the host.
The minimum size for the buffer required, assuming the min frame
size of [x29, x30] (2 * sizeof(long)), is half the combined size of
the hypervisor and overflow stacks plus an additional entry to
delimit the end of the stacktrace.
The stacktrace buffers are used later in the series to dump the
nVHE hypervisor stacktrace when using protected-mode.
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
Reviewed-by: Fuad Tabba <tabba@google.com>
Tested-by: Fuad Tabba <tabba@google.com>
---
Changes in v6:
- Fix typo in commit text, per Fuad
- Add Fuad’s Reviewed-by and Tested-by tags
Changes in v5:
- Fix typo in commit text, per Marc
arch/arm64/include/asm/memory.h | 8 ++++++++
arch/arm64/kvm/hyp/nvhe/stacktrace.c | 4 ++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
index 0af70d9abede..cab80a9a4086 100644
--- a/arch/arm64/include/asm/memory.h
+++ b/arch/arm64/include/asm/memory.h
@@ -113,6 +113,14 @@
#define OVERFLOW_STACK_SIZE SZ_4K
+/*
+ * With the minimum frame size of [x29, x30], exactly half the combined
+ * sizes of the hyp and overflow stacks is the maximum size needed to
+ * save the unwinded stacktrace; plus an additional entry to delimit the
+ * end.
+ */
+#define NVHE_STACKTRACE_SIZE ((OVERFLOW_STACK_SIZE + PAGE_SIZE) / 2 + sizeof(long))
+
/*
* Alignment of kernel segments (e.g. .text, .data).
*
diff --git a/arch/arm64/kvm/hyp/nvhe/stacktrace.c b/arch/arm64/kvm/hyp/nvhe/stacktrace.c
index b8a280aa026a..e2edda92a108 100644
--- a/arch/arm64/kvm/hyp/nvhe/stacktrace.c
+++ b/arch/arm64/kvm/hyp/nvhe/stacktrace.c
@@ -34,6 +34,10 @@ static void hyp_prepare_backtrace(unsigned long fp, unsigned long pc)
stacktrace_info->pc = pc;
}
+#ifdef CONFIG_PROTECTED_NVHE_STACKTRACE
+DEFINE_PER_CPU(unsigned long [NVHE_STACKTRACE_SIZE/sizeof(long)], pkvm_stacktrace);
+#endif /* CONFIG_PROTECTED_NVHE_STACKTRACE */
+
/*
* kvm_nvhe_prepare_backtrace - prepare to dump the nVHE backtrace
*
--
2.37.1.359.gd136c6c3e2-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-26 7:38 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 7:37 [PATCH v6 00/17] KVM nVHE Hypervisor stack unwinder Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 01/17] arm64: stacktrace: Add shared header for common stack unwinding code Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 02/17] arm64: stacktrace: Factor out on_accessible_stack_common() Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 16:01 ` Marc Zyngier
2022-07-26 16:01 ` Marc Zyngier
2022-07-26 16:01 ` Marc Zyngier
2022-07-26 16:33 ` Kalesh Singh
2022-07-26 16:33 ` Kalesh Singh
2022-07-26 16:33 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 03/17] arm64: stacktrace: Factor out unwind_next_common() Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 04/17] arm64: stacktrace: Handle frame pointer from different address spaces Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 14:34 ` Mark Brown
2022-07-26 14:34 ` Mark Brown
2022-07-26 14:34 ` Mark Brown
2022-07-26 15:30 ` Kalesh Singh
2022-07-26 15:30 ` Kalesh Singh
2022-07-26 15:30 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 05/17] arm64: stacktrace: Factor out common unwind() Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 06/17] arm64: stacktrace: Add description of stacktrace/common.h Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 14:49 ` Mark Brown
2022-07-26 14:49 ` Mark Brown
2022-07-26 14:49 ` Mark Brown
2022-07-26 7:37 ` [PATCH v6 07/17] KVM: arm64: On stack overflow switch to hyp overflow_stack Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 08/17] KVM: arm64: Stub implementation of non-protected nVHE HYP stack unwinder Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 09/17] KVM: arm64: Prepare non-protected nVHE hypervisor stacktrace Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 16:26 ` kernel test robot
2022-07-26 7:37 ` [PATCH v6 10/17] KVM: arm64: Implement non-protected nVHE hyp stack unwinder Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 11/17] KVM: arm64: Introduce hyp_dump_backtrace() Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 12/17] KVM: arm64: Add PROTECTED_NVHE_STACKTRACE Kconfig Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 10:00 ` Marc Zyngier
2022-07-26 10:00 ` Marc Zyngier
2022-07-26 10:00 ` Marc Zyngier
2022-07-26 15:33 ` Kalesh Singh
2022-07-26 15:33 ` Kalesh Singh
2022-07-26 15:33 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh [this message]
2022-07-26 7:37 ` [PATCH v6 13/17] KVM: arm64: Allocate shared pKVM hyp stacktrace buffers Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 14/17] KVM: arm64: Stub implementation of pKVM HYP stack unwinder Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 15/17] KVM: arm64: Save protected-nVHE (pKVM) hyp stacktrace Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 16/17] KVM: arm64: Implement protected nVHE hyp stack unwinder Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` [PATCH v6 17/17] KVM: arm64: Introduce pkvm_dump_backtrace() Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-26 7:37 ` Kalesh Singh
2022-07-27 14:29 ` [PATCH 0/6] KVM: arm64: nVHE stack unwinder rework Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` [PATCH 1/6] KVM: arm64: Move PROTECTED_NVHE_STACKTRACE around Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` [PATCH 2/6] KVM: arm64: Move nVHE stacktrace unwinding into its own compilation unit Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` [PATCH 3/6] KVM: arm64: Make unwind()/on_accessible_stack() per-unwinder functions Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 17:32 ` Mark Brown
2022-07-27 17:32 ` Mark Brown
2022-07-27 17:32 ` Mark Brown
2022-07-27 14:29 ` [PATCH 4/6] KVM: arm64: Move nVHE-only helpers into kvm/stacktrace.c Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` [PATCH 5/6] KVM: arm64: Don't open code ARRAY_SIZE() Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` [PATCH 6/6] arm64: Update 'unwinder howto' Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 14:29 ` Marc Zyngier
2022-07-27 15:56 ` [PATCH 0/6] KVM: arm64: nVHE stack unwinder rework Kalesh Singh
2022-07-27 15:56 ` Kalesh Singh
2022-07-27 15:56 ` Kalesh Singh
2022-07-27 16:01 ` Oliver Upton
2022-07-27 16:01 ` Oliver Upton
2022-07-27 16:01 ` Oliver Upton
2022-07-27 17:45 ` Marc Zyngier
2022-07-27 17:45 ` Marc Zyngier
2022-07-27 17:45 ` Marc Zyngier
2022-07-27 17:44 ` [PATCH v6 00/17] KVM nVHE Hypervisor stack unwinder Marc Zyngier
2022-07-27 17:44 ` Marc Zyngier
2022-07-27 17:44 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220726073750.3219117-14-kaleshsingh@google.com \
--to=kaleshsingh@google.com \
--cc=andreyknvl@gmail.com \
--cc=android-mm@google.com \
--cc=ast@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=elver@google.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madvenka@linux.microsoft.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mhiramat@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=tabba@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.