From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Hans de Goede <hdegoede@redhat.com>,
Icenowy Zheng <icenowy@aosc.io>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 01/10] dt-bindings: sram: sunxi-sram: Clean up the compatible lists
Date: Mon, 15 Aug 2022 13:15:04 +0100 [thread overview]
Message-ID: <20220815131504.65f7b92f@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20220815041248.53268-2-samuel@sholland.org>
On Sun, 14 Aug 2022 23:12:38 -0500
Samuel Holland <samuel@sholland.org> wrote:
> Use enumerations where appropriate to combine "const" choices and
> deduplicate fallback compatible strings.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Verified to be a pure transformation.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> Changes in v2:
> - New patch to first clean up the binding
>
> .../allwinner,sun4i-a10-system-control.yaml | 81 +++++++------------
> 1 file changed, 31 insertions(+), 50 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> index 1c426c211e36..5055c9081059 100644
> --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> @@ -24,32 +24,30 @@ properties:
>
> compatible:
> oneOf:
> - - const: allwinner,sun4i-a10-sram-controller
> + - enum:
> + - allwinner,sun4i-a10-sram-controller
> + - allwinner,sun50i-a64-sram-controller
> deprecated: true
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun5i-a13-system-control
> + - enum:
> + - allwinner,sun4i-a10-system-control
> + - allwinner,sun5i-a13-system-control
> + - allwinner,sun8i-a23-system-control
> + - allwinner,sun8i-h3-system-control
> + - allwinner,sun50i-a64-system-control
> + - allwinner,sun50i-h5-system-control
> + - allwinner,sun50i-h616-system-control
> - items:
> - - const: allwinner,sun7i-a20-system-control
> + - enum:
> + - allwinner,suniv-f1c100s-system-control
> + - allwinner,sun7i-a20-system-control
> + - allwinner,sun8i-r40-system-control
> - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun8i-a23-system-control
> - - const: allwinner,sun8i-h3-system-control
> - items:
> - const: allwinner,sun8i-v3s-system-control
> - const: allwinner,sun8i-h3-system-control
> - - items:
> - - const: allwinner,sun8i-r40-system-control
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun50i-a64-sram-controller
> - deprecated: true
> - - const: allwinner,sun50i-a64-system-control
> - - const: allwinner,sun50i-h5-system-control
> - items:
> - const: allwinner,sun50i-h6-system-control
> - const: allwinner,sun50i-a64-system-control
> - - items:
> - - const: allwinner,suniv-f1c100s-system-control
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun50i-h616-system-control
>
> reg:
> maxItems: 1
> @@ -76,43 +74,26 @@ patternProperties:
> - const: allwinner,sun4i-a10-sram-d
> - const: allwinner,sun50i-a64-sram-c
> - items:
> - - const: allwinner,sun5i-a13-sram-a3-a4
> - - const: allwinner,sun4i-a10-sram-a3-a4
> - - items:
> - - const: allwinner,sun7i-a20-sram-a3-a4
> + - enum:
> + - allwinner,sun5i-a13-sram-a3-a4
> + - allwinner,sun7i-a20-sram-a3-a4
> - const: allwinner,sun4i-a10-sram-a3-a4
> - items:
> - - const: allwinner,sun5i-a13-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun7i-a20-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun8i-a23-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun8i-h3-sram-c1
> + - enum:
> + - allwinner,sun5i-a13-sram-c1
> + - allwinner,sun7i-a20-sram-c1
> + - allwinner,sun8i-a23-sram-c1
> + - allwinner,sun8i-h3-sram-c1
> + - allwinner,sun8i-r40-sram-c1
> + - allwinner,sun50i-a64-sram-c1
> + - allwinner,sun50i-h5-sram-c1
> + - allwinner,sun50i-h6-sram-c1
> - const: allwinner,sun4i-a10-sram-c1
> - items:
> - - const: allwinner,sun8i-r40-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-a64-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-h5-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-h6-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun5i-a13-sram-d
> - - const: allwinner,sun4i-a10-sram-d
> - - items:
> - - const: allwinner,sun7i-a20-sram-d
> - - const: allwinner,sun4i-a10-sram-d
> - - items:
> - - const: allwinner,suniv-f1c100s-sram-d
> + - enum:
> + - allwinner,suniv-f1c100s-sram-d
> + - allwinner,sun5i-a13-sram-d
> + - allwinner,sun7i-a20-sram-d
> - const: allwinner,sun4i-a10-sram-d
> - items:
> - const: allwinner,sun50i-h6-sram-c
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Hans de Goede <hdegoede@redhat.com>,
Icenowy Zheng <icenowy@aosc.io>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 01/10] dt-bindings: sram: sunxi-sram: Clean up the compatible lists
Date: Mon, 15 Aug 2022 13:15:04 +0100 [thread overview]
Message-ID: <20220815131504.65f7b92f@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20220815041248.53268-2-samuel@sholland.org>
On Sun, 14 Aug 2022 23:12:38 -0500
Samuel Holland <samuel@sholland.org> wrote:
> Use enumerations where appropriate to combine "const" choices and
> deduplicate fallback compatible strings.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Verified to be a pure transformation.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> Changes in v2:
> - New patch to first clean up the binding
>
> .../allwinner,sun4i-a10-system-control.yaml | 81 +++++++------------
> 1 file changed, 31 insertions(+), 50 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> index 1c426c211e36..5055c9081059 100644
> --- a/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> +++ b/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
> @@ -24,32 +24,30 @@ properties:
>
> compatible:
> oneOf:
> - - const: allwinner,sun4i-a10-sram-controller
> + - enum:
> + - allwinner,sun4i-a10-sram-controller
> + - allwinner,sun50i-a64-sram-controller
> deprecated: true
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun5i-a13-system-control
> + - enum:
> + - allwinner,sun4i-a10-system-control
> + - allwinner,sun5i-a13-system-control
> + - allwinner,sun8i-a23-system-control
> + - allwinner,sun8i-h3-system-control
> + - allwinner,sun50i-a64-system-control
> + - allwinner,sun50i-h5-system-control
> + - allwinner,sun50i-h616-system-control
> - items:
> - - const: allwinner,sun7i-a20-system-control
> + - enum:
> + - allwinner,suniv-f1c100s-system-control
> + - allwinner,sun7i-a20-system-control
> + - allwinner,sun8i-r40-system-control
> - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun8i-a23-system-control
> - - const: allwinner,sun8i-h3-system-control
> - items:
> - const: allwinner,sun8i-v3s-system-control
> - const: allwinner,sun8i-h3-system-control
> - - items:
> - - const: allwinner,sun8i-r40-system-control
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun50i-a64-sram-controller
> - deprecated: true
> - - const: allwinner,sun50i-a64-system-control
> - - const: allwinner,sun50i-h5-system-control
> - items:
> - const: allwinner,sun50i-h6-system-control
> - const: allwinner,sun50i-a64-system-control
> - - items:
> - - const: allwinner,suniv-f1c100s-system-control
> - - const: allwinner,sun4i-a10-system-control
> - - const: allwinner,sun50i-h616-system-control
>
> reg:
> maxItems: 1
> @@ -76,43 +74,26 @@ patternProperties:
> - const: allwinner,sun4i-a10-sram-d
> - const: allwinner,sun50i-a64-sram-c
> - items:
> - - const: allwinner,sun5i-a13-sram-a3-a4
> - - const: allwinner,sun4i-a10-sram-a3-a4
> - - items:
> - - const: allwinner,sun7i-a20-sram-a3-a4
> + - enum:
> + - allwinner,sun5i-a13-sram-a3-a4
> + - allwinner,sun7i-a20-sram-a3-a4
> - const: allwinner,sun4i-a10-sram-a3-a4
> - items:
> - - const: allwinner,sun5i-a13-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun7i-a20-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun8i-a23-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun8i-h3-sram-c1
> + - enum:
> + - allwinner,sun5i-a13-sram-c1
> + - allwinner,sun7i-a20-sram-c1
> + - allwinner,sun8i-a23-sram-c1
> + - allwinner,sun8i-h3-sram-c1
> + - allwinner,sun8i-r40-sram-c1
> + - allwinner,sun50i-a64-sram-c1
> + - allwinner,sun50i-h5-sram-c1
> + - allwinner,sun50i-h6-sram-c1
> - const: allwinner,sun4i-a10-sram-c1
> - items:
> - - const: allwinner,sun8i-r40-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-a64-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-h5-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun50i-h6-sram-c1
> - - const: allwinner,sun4i-a10-sram-c1
> - - items:
> - - const: allwinner,sun5i-a13-sram-d
> - - const: allwinner,sun4i-a10-sram-d
> - - items:
> - - const: allwinner,sun7i-a20-sram-d
> - - const: allwinner,sun4i-a10-sram-d
> - - items:
> - - const: allwinner,suniv-f1c100s-sram-d
> + - enum:
> + - allwinner,suniv-f1c100s-sram-d
> + - allwinner,sun5i-a13-sram-d
> + - allwinner,sun7i-a20-sram-d
> - const: allwinner,sun4i-a10-sram-d
> - items:
> - const: allwinner,sun50i-h6-sram-c
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-15 12:15 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 4:12 [PATCH v2 00/10] soc: sunxi: sram: Fixes and D1 support Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 4:12 ` [PATCH v2 01/10] dt-bindings: sram: sunxi-sram: Clean up the compatible lists Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 12:15 ` Andre Przywara [this message]
2022-08-15 12:15 ` Andre Przywara
2022-08-15 13:54 ` Heiko Stübner
2022-08-15 13:54 ` Heiko Stübner
2022-08-16 5:55 ` Krzysztof Kozlowski
2022-08-16 5:55 ` Krzysztof Kozlowski
2022-08-15 4:12 ` [PATCH v2 02/10] dt-bindings: sram: sunxi-sram: Add D1 compatible string Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 13:55 ` Heiko Stübner
2022-08-15 13:55 ` Heiko Stübner
2022-08-16 7:46 ` Krzysztof Kozlowski
2022-08-16 7:46 ` Krzysztof Kozlowski
2022-08-15 4:12 ` [PATCH v2 03/10] soc: sunxi: sram: Actually claim SRAM regions Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 13:56 ` Heiko Stübner
2022-08-15 13:56 ` Heiko Stübner
2022-08-15 4:12 ` [PATCH v2 04/10] soc: sunxi: sram: Prevent the driver from being unbound Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 14:00 ` Heiko Stübner
2022-08-15 14:00 ` Heiko Stübner
2022-08-15 4:12 ` [PATCH v2 05/10] soc: sunxi: sram: Fix probe function ordering issues Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 14:06 ` Heiko Stübner
2022-08-15 14:06 ` Heiko Stübner
2022-08-16 0:05 ` Samuel Holland
2022-08-16 0:05 ` Samuel Holland
2022-08-15 4:12 ` [PATCH v2 06/10] soc: sunxi: sram: Fix debugfs info for A64 SRAM C Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 4:12 ` [PATCH v2 07/10] soc: sunxi: sram: Return void from the release function Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 14:09 ` Heiko Stübner
2022-08-15 14:09 ` Heiko Stübner
2022-08-15 4:12 ` [PATCH v2 08/10] soc: sunxi: sram: Save a pointer to the OF match data Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 14:10 ` Heiko Stübner
2022-08-15 14:10 ` Heiko Stübner
2022-08-15 4:12 ` [PATCH v2 09/10] soc: sunxi: sram: Export the LDO control register Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 14:13 ` Heiko Stübner
2022-08-15 14:13 ` Heiko Stübner
2022-08-15 4:12 ` [PATCH v2 10/10] soc: sunxi: sram: Add support for the D1 system control Samuel Holland
2022-08-15 4:12 ` Samuel Holland
2022-08-15 14:14 ` Heiko Stübner
2022-08-15 14:14 ` Heiko Stübner
2022-08-15 6:58 ` [PATCH v2 00/10] soc: sunxi: sram: Fixes and D1 support Conor.Dooley
2022-08-15 6:58 ` Conor.Dooley
2022-08-15 6:59 ` Conor.Dooley
2022-08-15 6:59 ` Conor.Dooley
2022-09-18 21:49 ` Jernej Škrabec
2022-09-18 21:49 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815131504.65f7b92f@donnerap.cambridge.arm.com \
--to=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.