From: Tomas Winkler <tomas.winkler@intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: intel-gfx@lists.freedesktop.org, Alexander Usyskin <alexander.usyskin@intel.com>, linux-kernel@vger.kernel.org, Rodrigo Vivi <rodrigo.vivi@intel.com>, Tomas Winkler <tomas.winkler@intel.com>, Vitaly Lubart <vitaly.lubart@intel.com> Subject: [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after start Date: Wed, 7 Sep 2022 18:58:10 +0300 [thread overview] Message-ID: <20220907155813.1427526-14-tomas.winkler@intel.com> (raw) In-Reply-To: <20220907155813.1427526-1-tomas.winkler@intel.com> From: Alexander Usyskin <alexander.usyskin@intel.com> The check that hardware and host ready bits are set after start is redundant and may fail and disable driver if there is back-to-back link reset issued right after start. This happens during pxp mode transitions when firmware undergo reset. Remove these checks to eliminate such failures. Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> --- drivers/misc/mei/init.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c index 1b4d5d7870b9..bac8852aad51 100644 --- a/drivers/misc/mei/init.c +++ b/drivers/misc/mei/init.c @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev) goto err; } - if (!mei_host_is_ready(dev)) { - dev_err(dev->dev, "host is not ready.\n"); - goto err; - } - - if (!mei_hw_is_ready(dev)) { - dev_err(dev->dev, "ME is not ready.\n"); - goto err; - } - if (!mei_hbm_version_is_supported(dev)) { dev_dbg(dev->dev, "MEI start failed.\n"); goto err; -- 2.37.2
WARNING: multiple messages have this Message-ID (diff)
From: Tomas Winkler <tomas.winkler@intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomas Winkler <tomas.winkler@intel.com>, Alexander Usyskin <alexander.usyskin@intel.com>, Vitaly Lubart <vitaly.lubart@intel.com> Subject: [PATCH v8 13/16] mei: drop ready bits check after start Date: Wed, 7 Sep 2022 18:58:10 +0300 [thread overview] Message-ID: <20220907155813.1427526-14-tomas.winkler@intel.com> (raw) In-Reply-To: <20220907155813.1427526-1-tomas.winkler@intel.com> From: Alexander Usyskin <alexander.usyskin@intel.com> The check that hardware and host ready bits are set after start is redundant and may fail and disable driver if there is back-to-back link reset issued right after start. This happens during pxp mode transitions when firmware undergo reset. Remove these checks to eliminate such failures. Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> --- drivers/misc/mei/init.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c index 1b4d5d7870b9..bac8852aad51 100644 --- a/drivers/misc/mei/init.c +++ b/drivers/misc/mei/init.c @@ -218,16 +218,6 @@ int mei_start(struct mei_device *dev) goto err; } - if (!mei_host_is_ready(dev)) { - dev_err(dev->dev, "host is not ready.\n"); - goto err; - } - - if (!mei_hw_is_ready(dev)) { - dev_err(dev->dev, "ME is not ready.\n"); - goto err; - } - if (!mei_hbm_version_is_supported(dev)) { dev_dbg(dev->dev, "MEI start failed.\n"); goto err; -- 2.37.2
next prev parent reply other threads:[~2022-09-07 16:00 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-07 15:57 [PATCH v8 00/16] GSC support for XeHP SDV and DG2 Tomas Winkler 2022-09-07 15:57 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:57 ` [PATCH v8 01/16] drm/i915/gsc: skip irq initialization if using polling Tomas Winkler 2022-09-07 15:57 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:57 ` [PATCH v8 02/16] mei: add kdoc for struct mei_aux_device Tomas Winkler 2022-09-07 15:57 ` [Intel-gfx] " Tomas Winkler 2022-09-07 18:58 ` Ceraolo Spurio, Daniele 2022-09-07 18:58 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [PATCH v8 03/16] mei: add slow_firmware flag to the mei auxiliary device Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:58 ` [PATCH v8 04/16] drm/i915/gsc: add slow_firmware flag to the gsc device definition Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:58 ` [PATCH v8 05/16] drm/i915/gsc: add GSC XeHP SDV platform definition Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:02 ` Ceraolo Spurio, Daniele 2022-09-07 19:02 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [PATCH v8 06/16] mei: gsc: use polling instead of interrupts Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:04 ` Ceraolo Spurio, Daniele 2022-09-07 19:04 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [PATCH v8 07/16] mei: gsc: wait for reset thread on stop Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:06 ` Ceraolo Spurio, Daniele 2022-09-07 19:06 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 08/16] mei: extend timeouts on slow devices Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:12 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 19:12 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 09/16] mei: bus: export common mkhi definitions into a separate header Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:19 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 19:19 ` Ceraolo Spurio, Daniele 2022-09-07 19:48 ` Winkler, Tomas 2022-09-07 19:48 ` Winkler, Tomas 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 10/16] mei: mkhi: add memory ready command Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 15:58 ` [PATCH v8 11/16] mei: gsc: setup gsc extended operational memory Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:23 ` Ceraolo Spurio, Daniele 2022-09-07 19:23 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 12/16] mei: gsc: add transition to PXP mode in resume flow Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:23 ` Ceraolo Spurio, Daniele 2022-09-07 19:23 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 15:58 ` Tomas Winkler [this message] 2022-09-07 15:58 ` [PATCH v8 13/16] mei: drop ready bits check after start Tomas Winkler 2022-09-07 21:23 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 21:23 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 14/16] mei: debugfs: add pxp mode to devstate in debugfs Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:26 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 19:26 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 15/16] drm/i915/gsc: allocate extended operational memory in LMEM Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 18:24 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 16/16] HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 16:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev3) Patchwork 2022-09-07 16:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-09-07 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-09-07 18:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev4) Patchwork 2022-09-07 18:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-09-07 19:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220907155813.1427526-14-tomas.winkler@intel.com \ --to=tomas.winkler@intel.com \ --cc=airlied@linux.ie \ --cc=alexander.usyskin@intel.com \ --cc=daniel@ffwll.ch \ --cc=gregkh@linuxfoundation.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rodrigo.vivi@intel.com \ --cc=vitaly.lubart@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.