From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com> To: Tomas Winkler <tomas.winkler@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: Vitaly Lubart <vitaly.lubart@intel.com>, intel-gfx@lists.freedesktop.org, Alexander Usyskin <alexander.usyskin@intel.com>, linux-kernel@vger.kernel.org, Rodrigo Vivi <rodrigo.vivi@intel.com> Subject: Re: [Intel-gfx] [PATCH v8 07/16] mei: gsc: wait for reset thread on stop Date: Wed, 7 Sep 2022 12:06:30 -0700 [thread overview] Message-ID: <cf73d4ca-4e19-aaff-8b45-ccd32f95a496@intel.com> (raw) In-Reply-To: <20220907155813.1427526-8-tomas.winkler@intel.com> On 9/7/2022 8:58 AM, Tomas Winkler wrote: > From: Alexander Usyskin <alexander.usyskin@intel.com> > > Wait for reset work to complete before initiating > stop reset flow sequence. > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> This is unchanged from the previously reviewed rev (apart from the fixed date in the header), so this still applies: Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Daniele > --- > drivers/misc/mei/init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c > index eb052005ca86..bc054baf496c 100644 > --- a/drivers/misc/mei/init.c > +++ b/drivers/misc/mei/init.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Copyright (c) 2012-2019, Intel Corporation. All rights reserved. > + * Copyright (c) 2012-2022, Intel Corporation. All rights reserved. > * Intel Management Engine Interface (Intel MEI) Linux driver > */ > > @@ -320,6 +320,8 @@ void mei_stop(struct mei_device *dev) > > mei_clear_interrupts(dev); > mei_synchronize_irq(dev); > + /* to catch HW-initiated reset */ > + mei_cancel_work(dev); > > mutex_lock(&dev->device_lock); >
WARNING: multiple messages have this Message-ID (diff)
From: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com> To: Tomas Winkler <tomas.winkler@intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch> Cc: <intel-gfx@lists.freedesktop.org>, Alexander Usyskin <alexander.usyskin@intel.com>, <linux-kernel@vger.kernel.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Vitaly Lubart <vitaly.lubart@intel.com> Subject: Re: [Intel-gfx] [PATCH v8 07/16] mei: gsc: wait for reset thread on stop Date: Wed, 7 Sep 2022 12:06:30 -0700 [thread overview] Message-ID: <cf73d4ca-4e19-aaff-8b45-ccd32f95a496@intel.com> (raw) In-Reply-To: <20220907155813.1427526-8-tomas.winkler@intel.com> On 9/7/2022 8:58 AM, Tomas Winkler wrote: > From: Alexander Usyskin <alexander.usyskin@intel.com> > > Wait for reset work to complete before initiating > stop reset flow sequence. > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> This is unchanged from the previously reviewed rev (apart from the fixed date in the header), so this still applies: Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Daniele > --- > drivers/misc/mei/init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c > index eb052005ca86..bc054baf496c 100644 > --- a/drivers/misc/mei/init.c > +++ b/drivers/misc/mei/init.c > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Copyright (c) 2012-2019, Intel Corporation. All rights reserved. > + * Copyright (c) 2012-2022, Intel Corporation. All rights reserved. > * Intel Management Engine Interface (Intel MEI) Linux driver > */ > > @@ -320,6 +320,8 @@ void mei_stop(struct mei_device *dev) > > mei_clear_interrupts(dev); > mei_synchronize_irq(dev); > + /* to catch HW-initiated reset */ > + mei_cancel_work(dev); > > mutex_lock(&dev->device_lock); >
next prev parent reply other threads:[~2022-09-07 19:06 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-07 15:57 [PATCH v8 00/16] GSC support for XeHP SDV and DG2 Tomas Winkler 2022-09-07 15:57 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:57 ` [PATCH v8 01/16] drm/i915/gsc: skip irq initialization if using polling Tomas Winkler 2022-09-07 15:57 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:57 ` [PATCH v8 02/16] mei: add kdoc for struct mei_aux_device Tomas Winkler 2022-09-07 15:57 ` [Intel-gfx] " Tomas Winkler 2022-09-07 18:58 ` Ceraolo Spurio, Daniele 2022-09-07 18:58 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [PATCH v8 03/16] mei: add slow_firmware flag to the mei auxiliary device Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:58 ` [PATCH v8 04/16] drm/i915/gsc: add slow_firmware flag to the gsc device definition Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 15:58 ` [PATCH v8 05/16] drm/i915/gsc: add GSC XeHP SDV platform definition Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:02 ` Ceraolo Spurio, Daniele 2022-09-07 19:02 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [PATCH v8 06/16] mei: gsc: use polling instead of interrupts Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:04 ` Ceraolo Spurio, Daniele 2022-09-07 19:04 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [PATCH v8 07/16] mei: gsc: wait for reset thread on stop Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:06 ` Ceraolo Spurio, Daniele [this message] 2022-09-07 19:06 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 08/16] mei: extend timeouts on slow devices Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:12 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 19:12 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 09/16] mei: bus: export common mkhi definitions into a separate header Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:19 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 19:19 ` Ceraolo Spurio, Daniele 2022-09-07 19:48 ` Winkler, Tomas 2022-09-07 19:48 ` Winkler, Tomas 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 10/16] mei: mkhi: add memory ready command Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 15:58 ` [PATCH v8 11/16] mei: gsc: setup gsc extended operational memory Tomas Winkler 2022-09-07 15:58 ` [Intel-gfx] " Tomas Winkler 2022-09-07 19:23 ` Ceraolo Spurio, Daniele 2022-09-07 19:23 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 12/16] mei: gsc: add transition to PXP mode in resume flow Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:23 ` Ceraolo Spurio, Daniele 2022-09-07 19:23 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 13/16] mei: drop ready bits check after start Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 21:23 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 21:23 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 14/16] mei: debugfs: add pxp mode to devstate in debugfs Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 19:26 ` [Intel-gfx] " Ceraolo Spurio, Daniele 2022-09-07 19:26 ` Ceraolo Spurio, Daniele 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 15/16] drm/i915/gsc: allocate extended operational memory in LMEM Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 18:24 ` [Intel-gfx] [PATCH] " Daniele Ceraolo Spurio 2022-09-07 15:58 ` [Intel-gfx] [PATCH v8 16/16] HAX: drm/i915: force INTEL_MEI_GSC on for CI Tomas Winkler 2022-09-07 15:58 ` Tomas Winkler 2022-09-07 16:26 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev3) Patchwork 2022-09-07 16:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-09-07 16:41 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2022-09-07 18:47 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 (rev4) Patchwork 2022-09-07 18:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-09-07 19:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cf73d4ca-4e19-aaff-8b45-ccd32f95a496@intel.com \ --to=daniele.ceraolospurio@intel.com \ --cc=airlied@linux.ie \ --cc=alexander.usyskin@intel.com \ --cc=daniel@ffwll.ch \ --cc=gregkh@linuxfoundation.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rodrigo.vivi@intel.com \ --cc=tomas.winkler@intel.com \ --cc=vitaly.lubart@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.