From: Maxime Ripard <maxime@cerno.tech> To: Maxime Ripard <mripard@kernel.org>, Eric Anholt <eric@anholt.net>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Rob Herring <robh@kernel.org>, Emma Anholt <emma@anholt.net> Cc: dri-devel@lists.freedesktop.org, Joerg Quinten <aBUGSworstnightmare@gmail.com>, Chris Morgan <macromorgan@hotmail.com>, Maxime Ripard <maxime@cerno.tech>, Dave Stevenson <dave.stevenson@raspberrypi.com>, linux-kernel@vger.kernel.org, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: [PATCH 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. Date: Thu, 13 Oct 2022 11:56:50 +0200 [thread overview] Message-ID: <20221013-rpi-dpi-improvements-v1-6-8a7a96949cb0@cerno.tech> (raw) In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> From: Dave Stevenson <dave.stevenson@raspberrypi.com> DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) { -- b4 0.11.0-dev-7da52
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Maxime Ripard <mripard@kernel.org>, Eric Anholt <eric@anholt.net>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Rob Herring <robh@kernel.org>, Emma Anholt <emma@anholt.net> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten <aBUGSworstnightmare@gmail.com>, Maxime Ripard <maxime@cerno.tech>, Chris Morgan <macromorgan@hotmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: [PATCH 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. Date: Thu, 13 Oct 2022 11:56:50 +0200 [thread overview] Message-ID: <20221013-rpi-dpi-improvements-v1-6-8a7a96949cb0@cerno.tech> (raw) In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> From: Dave Stevenson <dave.stevenson@raspberrypi.com> DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) { -- b4 0.11.0-dev-7da52
next prev parent reply other threads:[~2022-10-13 9:57 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-13 9:56 [PATCH 0/7] drm/vc4: dpi: Various improvements Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-13 9:56 ` [PATCH 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-13 9:56 ` [PATCH 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18 Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-15 17:07 ` Laurent Pinchart 2022-10-15 17:07 ` Laurent Pinchart 2022-10-13 9:56 ` [PATCH 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-13 9:56 ` [PATCH 4/7] drm/vc4: dpi: Support RGB565 format Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-15 17:29 ` Laurent Pinchart 2022-10-15 17:29 ` Laurent Pinchart 2022-10-17 17:12 ` Dave Stevenson 2022-10-17 17:12 ` Dave Stevenson 2022-10-13 9:56 ` [PATCH 5/7] drm/vc4: dpi: Support BGR666 formats Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-15 17:26 ` Laurent Pinchart 2022-10-15 17:26 ` Laurent Pinchart 2022-10-15 17:30 ` Laurent Pinchart 2022-10-15 17:30 ` Laurent Pinchart 2022-10-17 17:26 ` Dave Stevenson 2022-10-17 17:26 ` Dave Stevenson 2022-10-13 9:56 ` Maxime Ripard [this message] 2022-10-13 9:56 ` [PATCH 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24 Maxime Ripard 2022-10-15 17:13 ` Laurent Pinchart 2022-10-15 17:13 ` Laurent Pinchart 2022-10-17 17:03 ` Dave Stevenson 2022-10-17 17:03 ` Dave Stevenson 2022-10-13 9:56 ` [PATCH 7/7] drm/vc4: dpi: Fix format mapping for RGB565 Maxime Ripard 2022-10-13 9:56 ` Maxime Ripard 2022-10-15 17:19 ` Laurent Pinchart 2022-10-15 17:19 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221013-rpi-dpi-improvements-v1-6-8a7a96949cb0@cerno.tech \ --to=maxime@cerno.tech \ --cc=aBUGSworstnightmare@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dave.stevenson@raspberrypi.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=emma@anholt.net \ --cc=eric@anholt.net \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=macromorgan@hotmail.com \ --cc=mripard@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.