From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Maxime Ripard <mripard@kernel.org>, Eric Anholt <eric@anholt.net>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rob Herring <robh@kernel.org>, Emma Anholt <emma@anholt.net>,
dri-devel@lists.freedesktop.org,
Joerg Quinten <aBUGSworstnightmare@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18
Date: Sat, 15 Oct 2022 20:07:31 +0300 [thread overview]
Message-ID: <Y0ro08TTmavkf0Ca@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221013-rpi-dpi-improvements-v1-2-8a7a96949cb0@cerno.tech>
Hi Maxime,
Thank you for the patch.
On Thu, Oct 13, 2022 at 11:56:46AM +0200, Maxime Ripard wrote:
> From: Joerg Quinten <aBUGSworstnightmare@gmail.com>
>
> Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the
> RaspberryPi.
>
> Signed-off-by: Joerg Quinten <aBUGSworstnightmare@gmail.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> include/uapi/linux/media-bus-format.h | 3 ++-
New formats need documentation in
Documentation/userspace-api/media/v4l/subdev-formats.rst. Same for
patches 1/7 and 3/7.
Apart from that, the patch looks good to me.
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index b0a945eb7040..2ee0b38c0a71 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x1023 */
> +/* RGB - next is 0x1024 */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -46,6 +46,7 @@
> #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006
> #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
> #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
> +#define MEDIA_BUS_FMT_BGR666_1X18 0x1023
> #define MEDIA_BUS_FMT_RGB666_1X18 0x1009
> #define MEDIA_BUS_FMT_RBG888_1X24 0x100e
> #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
>
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Chris Morgan <macromorgan@hotmail.com>,
Emma Anholt <emma@anholt.net>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Joerg Quinten <aBUGSworstnightmare@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18
Date: Sat, 15 Oct 2022 20:07:31 +0300 [thread overview]
Message-ID: <Y0ro08TTmavkf0Ca@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20221013-rpi-dpi-improvements-v1-2-8a7a96949cb0@cerno.tech>
Hi Maxime,
Thank you for the patch.
On Thu, Oct 13, 2022 at 11:56:46AM +0200, Maxime Ripard wrote:
> From: Joerg Quinten <aBUGSworstnightmare@gmail.com>
>
> Add the BGR666 format MEDIA_BUS_FMT_BGR666_1X18 supported by the
> RaspberryPi.
>
> Signed-off-by: Joerg Quinten <aBUGSworstnightmare@gmail.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
> include/uapi/linux/media-bus-format.h | 3 ++-
New formats need documentation in
Documentation/userspace-api/media/v4l/subdev-formats.rst. Same for
patches 1/7 and 3/7.
Apart from that, the patch looks good to me.
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> index b0a945eb7040..2ee0b38c0a71 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x1023 */
> +/* RGB - next is 0x1024 */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -46,6 +46,7 @@
> #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006
> #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
> #define MEDIA_BUS_FMT_RGB565_2X8_LE 0x1008
> +#define MEDIA_BUS_FMT_BGR666_1X18 0x1023
> #define MEDIA_BUS_FMT_RGB666_1X18 0x1009
> #define MEDIA_BUS_FMT_RBG888_1X24 0x100e
> #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-10-15 17:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 9:56 [PATCH 0/7] drm/vc4: dpi: Various improvements Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-13 9:56 ` [PATCH 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-13 9:56 ` [PATCH 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18 Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-15 17:07 ` Laurent Pinchart [this message]
2022-10-15 17:07 ` Laurent Pinchart
2022-10-13 9:56 ` [PATCH 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-13 9:56 ` [PATCH 4/7] drm/vc4: dpi: Support RGB565 format Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-15 17:29 ` Laurent Pinchart
2022-10-15 17:29 ` Laurent Pinchart
2022-10-17 17:12 ` Dave Stevenson
2022-10-17 17:12 ` Dave Stevenson
2022-10-13 9:56 ` [PATCH 5/7] drm/vc4: dpi: Support BGR666 formats Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-15 17:26 ` Laurent Pinchart
2022-10-15 17:26 ` Laurent Pinchart
2022-10-15 17:30 ` Laurent Pinchart
2022-10-15 17:30 ` Laurent Pinchart
2022-10-17 17:26 ` Dave Stevenson
2022-10-17 17:26 ` Dave Stevenson
2022-10-13 9:56 ` [PATCH 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24 Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-15 17:13 ` Laurent Pinchart
2022-10-15 17:13 ` Laurent Pinchart
2022-10-17 17:03 ` Dave Stevenson
2022-10-17 17:03 ` Dave Stevenson
2022-10-13 9:56 ` [PATCH 7/7] drm/vc4: dpi: Fix format mapping for RGB565 Maxime Ripard
2022-10-13 9:56 ` Maxime Ripard
2022-10-15 17:19 ` Laurent Pinchart
2022-10-15 17:19 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0ro08TTmavkf0Ca@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=aBUGSworstnightmare@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.