From: Maxime Ripard <maxime@cerno.tech> To: Emma Anholt <emma@anholt.net>, Maxime Ripard <mripard@kernel.org>, Rob Herring <robh@kernel.org>, Daniel Vetter <daniel@ffwll.ch>, Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Joerg Quinten <aBUGSworstnightmare@gmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Chris Morgan <macromorgan@hotmail.com>, Maxime Ripard <maxime@cerno.tech> Subject: [PATCH v2 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. Date: Thu, 20 Oct 2022 10:30:50 +0200 [thread overview] Message-ID: <20221013-rpi-dpi-improvements-v2-6-7691903fb9c8@cerno.tech> (raw) In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> From: Dave Stevenson <dave.stevenson@raspberrypi.com> DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) { -- b4 0.10.1
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime@cerno.tech> To: Emma Anholt <emma@anholt.net>, Maxime Ripard <mripard@kernel.org>, Rob Herring <robh@kernel.org>, Daniel Vetter <daniel@ffwll.ch>, Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joerg Quinten <aBUGSworstnightmare@gmail.com>, Chris Morgan <macromorgan@hotmail.com>, Dave Stevenson <dave.stevenson@raspberrypi.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Maxime Ripard <maxime@cerno.tech> Subject: [PATCH v2 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. Date: Thu, 20 Oct 2022 10:30:50 +0200 [thread overview] Message-ID: <20221013-rpi-dpi-improvements-v2-6-7691903fb9c8@cerno.tech> (raw) In-Reply-To: <20221013-rpi-dpi-improvements-v2-0-7691903fb9c8@cerno.tech> From: Dave Stevenson <dave.stevenson@raspberrypi.com> DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) { -- b4 0.10.1
next prev parent reply other threads:[~2022-10-20 8:51 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-20 8:30 [PATCH v2 0/7] drm/vc4: dpi: Various improvements Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard 2022-10-20 8:30 ` [PATCH v2 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard 2022-11-29 12:22 ` Laurent Pinchart 2022-11-29 12:22 ` Laurent Pinchart 2022-11-29 12:39 ` Laurent Pinchart 2022-11-29 12:39 ` Laurent Pinchart 2022-10-20 8:30 ` [PATCH v2 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18 Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard 2022-11-29 12:26 ` Laurent Pinchart 2022-11-29 12:26 ` Laurent Pinchart 2022-10-20 8:30 ` [PATCH v2 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard 2022-11-29 12:38 ` Laurent Pinchart 2022-11-29 12:38 ` Laurent Pinchart 2022-11-29 14:52 ` Jörg Quinten 2022-11-29 18:37 ` Laurent Pinchart 2022-11-29 18:37 ` Laurent Pinchart 2022-10-20 8:30 ` [PATCH v2 4/7] drm/vc4: dpi: Support RGB565 format Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard 2022-10-20 8:30 ` [PATCH v2 5/7] drm/vc4: dpi: Support BGR666 formats Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard [this message] 2022-10-20 8:30 ` [PATCH v2 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24 Maxime Ripard 2022-10-20 8:30 ` [PATCH v2 7/7] drm/vc4: dpi: Fix format mapping for RGB565 Maxime Ripard 2022-10-20 8:30 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221013-rpi-dpi-improvements-v2-6-7691903fb9c8@cerno.tech \ --to=maxime@cerno.tech \ --cc=aBUGSworstnightmare@gmail.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dave.stevenson@raspberrypi.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=emma@anholt.net \ --cc=eric@anholt.net \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=macromorgan@hotmail.com \ --cc=mripard@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.