Re: [PATCH v2 2/2] xfs_admin: get/set label of mounted filesystem

From: Carlos Maiolino <cem@kernel.org>
To: Catherine Hoang <catherine.hoang@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] xfs_admin: get/set label of mounted filesystem
Date: Fri, 3 Feb 2023 13:48:33 +0100	[thread overview]
Message-ID: <20230203124833.jpxggxui6ckfi6qn@andromeda> (raw)
In-Reply-To: <20230126003311.7736-3-catherine.hoang@oracle.com>

On Wed, Jan 25, 2023 at 04:33:11PM -0800, Catherine Hoang wrote:
> Adapt this tool to call xfs_io to get/set the label of a mounted filesystem.
> 
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>

Looks good, thanks!
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  db/xfs_admin.sh | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
> index 3a7f44ea..cc650c42 100755
> --- a/db/xfs_admin.sh
> +++ b/db/xfs_admin.sh
> @@ -29,9 +29,11 @@ do
>  	j)	DB_OPTS=$DB_OPTS" -c 'version log2'"
>  		require_offline=1
>  		;;
> -	l)	DB_OPTS=$DB_OPTS" -r -c label";;
> +	l)	DB_OPTS=$DB_OPTS" -r -c label"
> +		IO_OPTS=$IO_OPTS" -r -c label"
> +		;;
>  	L)	DB_OPTS=$DB_OPTS" -c 'label "$OPTARG"'"
> -		require_offline=1
> +		IO_OPTS=$IO_OPTS" -c 'label -s "$OPTARG"'"
>  		;;
>  	O)	REPAIR_OPTS=$REPAIR_OPTS" -c $OPTARG"
>  		require_offline=1
> --
> 2.34.1
> 

-- 
Carlos Maiolino