From: Allison Henderson <allison.henderson@oracle.com>
To: Catherine Hoang <catherine.hoang@oracle.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] xfs_admin: get/set label of mounted filesystem
Date: Thu, 26 Jan 2023 18:03:04 +0000 [thread overview]
Message-ID: <5bfc1067a192376fe0e55fc9af1450e9d7761aaa.camel@oracle.com> (raw)
In-Reply-To: <20230126003311.7736-3-catherine.hoang@oracle.com>
On Wed, 2023-01-25 at 16:33 -0800, Catherine Hoang wrote:
> Adapt this tool to call xfs_io to get/set the label of a mounted
> filesystem.
>
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
Looks good. Thanks Catherine!
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> db/xfs_admin.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
> index 3a7f44ea..cc650c42 100755
> --- a/db/xfs_admin.sh
> +++ b/db/xfs_admin.sh
> @@ -29,9 +29,11 @@ do
> j) DB_OPTS=$DB_OPTS" -c 'version log2'"
> require_offline=1
> ;;
> - l) DB_OPTS=$DB_OPTS" -r -c label";;
> + l) DB_OPTS=$DB_OPTS" -r -c label"
> + IO_OPTS=$IO_OPTS" -r -c label"
> + ;;
> L) DB_OPTS=$DB_OPTS" -c 'label "$OPTARG"'"
> - require_offline=1
> + IO_OPTS=$IO_OPTS" -c 'label -s "$OPTARG"'"
> ;;
> O) REPAIR_OPTS=$REPAIR_OPTS" -c $OPTARG"
> require_offline=1
next prev parent reply other threads:[~2023-01-26 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:33 [PATCH v2 0/2] xfs_admin: get/set label of mounted filesystems Catherine Hoang
2023-01-26 0:33 ` [PATCH v2 1/2] xfs_admin: correctly parse IO_OPTS parameters Catherine Hoang
2023-01-26 18:02 ` Allison Henderson
2023-02-03 12:44 ` Carlos Maiolino
2023-01-26 0:33 ` [PATCH v2 2/2] xfs_admin: get/set label of mounted filesystem Catherine Hoang
2023-01-26 18:03 ` Allison Henderson [this message]
2023-02-03 12:48 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bfc1067a192376fe0e55fc9af1450e9d7761aaa.camel@oracle.com \
--to=allison.henderson@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.