From: Allison Henderson <allison.henderson@oracle.com>
To: Catherine Hoang <catherine.hoang@oracle.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] xfs_admin: correctly parse IO_OPTS parameters
Date: Thu, 26 Jan 2023 18:02:25 +0000 [thread overview]
Message-ID: <29ffd634da719aa10985f6bfd6506679ee464dbc.camel@oracle.com> (raw)
In-Reply-To: <20230126003311.7736-2-catherine.hoang@oracle.com>
On Wed, 2023-01-25 at 16:33 -0800, Catherine Hoang wrote:
> Change exec to eval so that the IO_OPTS parameters are parsed
> correctly
> when the parameters contain quotations.
>
> Fixes: e7cd89b2da72 ("xfs_admin: get UUID of mounted filesystem")
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
Looks good to me
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> db/xfs_admin.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
> index b73fb3ad..3a7f44ea 100755
> --- a/db/xfs_admin.sh
> +++ b/db/xfs_admin.sh
> @@ -69,7 +69,8 @@ case $# in
> fi
>
> if [ -n "$IO_OPTS" ]; then
> - exec xfs_io -p xfs_admin $IO_OPTS
> "$mntpt"
> + eval xfs_io -p xfs_admin $IO_OPTS
> "$mntpt"
> + exit $?
> fi
> fi
>
next prev parent reply other threads:[~2023-01-26 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:33 [PATCH v2 0/2] xfs_admin: get/set label of mounted filesystems Catherine Hoang
2023-01-26 0:33 ` [PATCH v2 1/2] xfs_admin: correctly parse IO_OPTS parameters Catherine Hoang
2023-01-26 18:02 ` Allison Henderson [this message]
2023-02-03 12:44 ` Carlos Maiolino
2023-01-26 0:33 ` [PATCH v2 2/2] xfs_admin: get/set label of mounted filesystem Catherine Hoang
2023-01-26 18:03 ` Allison Henderson
2023-02-03 12:48 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ffd634da719aa10985f6bfd6506679ee464dbc.camel@oracle.com \
--to=allison.henderson@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.