From: Nick Alcock <nick.alcock@oracle.com> To: mcgrof@kernel.org Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules Date: Fri, 10 Feb 2023 16:47:42 +0000 [thread overview] Message-ID: <20230210164749.368998-2-nick.alcock@oracle.com> (raw) In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com> Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message. So comment out all uses of MODULE_LICENSE that are not in real modules (the license declaration is left in as documentation). Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Rob Herring <robh@kernel.org> Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/pci/controller/pci-versatile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-versatile.c b/drivers/pci/controller/pci-versatile.c index 7991d334e0f1..afa9d4694501 100644 --- a/drivers/pci/controller/pci-versatile.c +++ b/drivers/pci/controller/pci-versatile.c @@ -169,4 +169,4 @@ static struct platform_driver versatile_pci_driver = { module_platform_driver(versatile_pci_driver); MODULE_DESCRIPTION("Versatile PCI driver"); -MODULE_LICENSE("GPL v2"); +/* MODULE_LICENSE("GPL v2"); */ -- 2.39.1.268.g9de2f9a303
WARNING: multiple messages have this Message-ID (diff)
From: Nick Alcock <nick.alcock@oracle.com> To: mcgrof@kernel.org Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules Date: Fri, 10 Feb 2023 16:47:42 +0000 [thread overview] Message-ID: <20230210164749.368998-2-nick.alcock@oracle.com> (raw) In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com> Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message. So comment out all uses of MODULE_LICENSE that are not in real modules (the license declaration is left in as documentation). Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Rob Herring <robh@kernel.org> Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/pci/controller/pci-versatile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-versatile.c b/drivers/pci/controller/pci-versatile.c index 7991d334e0f1..afa9d4694501 100644 --- a/drivers/pci/controller/pci-versatile.c +++ b/drivers/pci/controller/pci-versatile.c @@ -169,4 +169,4 @@ static struct platform_driver versatile_pci_driver = { module_platform_driver(versatile_pci_driver); MODULE_DESCRIPTION("Versatile PCI driver"); -MODULE_LICENSE("GPL v2"); +/* MODULE_LICENSE("GPL v2"); */ -- 2.39.1.268.g9de2f9a303 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-10 17:06 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-10 16:47 [PATCH 0/8] MODULE_LICENSE removals, first tranche Nick Alcock 2023-02-10 16:47 ` Nick Alcock [this message] 2023-02-10 16:47 ` [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules Nick Alcock 2023-02-10 17:36 ` Rob Herring 2023-02-10 17:36 ` Rob Herring 2023-02-10 18:43 ` Nick Alcock 2023-02-10 18:43 ` Nick Alcock 2023-02-13 22:57 ` Bjorn Helgaas 2023-02-13 22:57 ` Bjorn Helgaas 2023-02-14 15:41 ` Nick Alcock 2023-02-14 15:41 ` Nick Alcock 2023-02-14 17:20 ` Bjorn Helgaas 2023-02-14 17:20 ` Bjorn Helgaas 2023-02-16 13:34 ` Nick Alcock 2023-02-16 13:34 ` Nick Alcock 2023-02-10 16:47 ` [PATCH 2/8] kbuild, PCI: mobiveil: " Nick Alcock 2023-02-10 16:47 ` [PATCH 3/8] kbuild, ARM: tegra: " Nick Alcock 2023-02-10 16:47 ` [PATCH 4/8] kbuild, PCI: endpoint: " Nick Alcock 2023-02-10 16:47 ` [PATCH 5/8] kbuild, PCI: hip: " Nick Alcock 2023-02-10 16:47 ` [PATCH 6/8] kbuild, shpchp: " Nick Alcock 2023-02-10 16:47 ` [PATCH 7/8] kbuild, PCI: dwc: histb: " Nick Alcock 2023-02-10 16:47 ` [PATCH 8/8] kbuild, PCI: microchip: " Nick Alcock 2023-02-10 16:47 ` Nick Alcock 2023-02-10 18:27 ` Conor Dooley 2023-02-10 18:27 ` Conor Dooley 2023-02-10 19:26 ` Nick Alcock 2023-02-10 19:26 ` Nick Alcock 2023-02-10 20:10 ` Conor Dooley 2023-02-10 20:10 ` Conor Dooley 2023-02-12 18:37 ` Leon Romanovsky 2023-02-12 18:37 ` Leon Romanovsky 2023-02-12 19:52 ` Nick Alcock 2023-02-12 19:52 ` Nick Alcock 2023-02-13 15:53 ` Nick Alcock 2023-02-13 15:53 ` Nick Alcock 2023-02-13 16:13 ` Nick Alcock 2023-02-13 16:13 ` Nick Alcock 2023-02-13 16:51 ` Conor Dooley 2023-02-13 16:51 ` Conor Dooley 2023-02-13 17:06 ` Leon Romanovsky 2023-02-13 17:06 ` Leon Romanovsky 2023-02-15 19:06 ` Nick Alcock 2023-02-15 19:06 ` Nick Alcock 2023-02-13 17:30 ` Jonathan Corbet 2023-02-13 17:30 ` Jonathan Corbet 2023-02-13 19:23 ` Leon Romanovsky 2023-02-13 19:23 ` Leon Romanovsky 2023-02-16 12:05 ` Nick Alcock 2023-02-16 12:05 ` Nick Alcock
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230210164749.368998-2-nick.alcock@oracle.com \ --to=nick.alcock@oracle.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-modules@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mcgrof@kernel.org \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.