From: Jonathan Corbet <corbet@lwn.net>
To: Leon Romanovsky <leon@kernel.org>, Nick Alcock <nick.alcock@oracle.com>
Cc: Conor Dooley <conor@kernel.org>,
mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules
Date: Mon, 13 Feb 2023 10:30:44 -0700 [thread overview]
Message-ID: <87ilg5mq0r.fsf@meer.lwn.net> (raw)
In-Reply-To: <Y+kx3fb2Lzlg+u5+@unreal>
Leon Romanovsky <leon@kernel.org> writes:
> It looks odd to me too. Please add SPDX tag in modules which don't have
> it already, instead of commenting code.
So I'm just a bystander here and should probably be ignored, but ...
From what I can see, Nick is attempting one of those cross-tree cleanups
that's painful enough to do on its own. This request is asking him to
perform a different, unrelated, and potentially fraught cleanup that the
maintainers of the code in question have not yet managed to get around
to taking care of. This will impede an already prolonged process and,
IMO, unnecessarily so.
Wouldn't it be better to let this work proceed while making a note
of the files still needing SPDX tags?
I'll shut up now :)
Thanks,
jon
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Leon Romanovsky <leon@kernel.org>, Nick Alcock <nick.alcock@oracle.com>
Cc: Conor Dooley <conor@kernel.org>,
mcgrof@kernel.org, linux-modules@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules
Date: Mon, 13 Feb 2023 10:30:44 -0700 [thread overview]
Message-ID: <87ilg5mq0r.fsf@meer.lwn.net> (raw)
In-Reply-To: <Y+kx3fb2Lzlg+u5+@unreal>
Leon Romanovsky <leon@kernel.org> writes:
> It looks odd to me too. Please add SPDX tag in modules which don't have
> it already, instead of commenting code.
So I'm just a bystander here and should probably be ignored, but ...
From what I can see, Nick is attempting one of those cross-tree cleanups
that's painful enough to do on its own. This request is asking him to
perform a different, unrelated, and potentially fraught cleanup that the
maintainers of the code in question have not yet managed to get around
to taking care of. This will impede an already prolonged process and,
IMO, unnecessarily so.
Wouldn't it be better to let this work proceed while making a note
of the files still needing SPDX tags?
I'll shut up now :)
Thanks,
jon
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-02-13 17:30 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 16:47 [PATCH 0/8] MODULE_LICENSE removals, first tranche Nick Alcock
2023-02-10 16:47 ` [PATCH 1/8] kbuild, PCI: generic,versatile: comment out MODULE_LICENSE in non-modules Nick Alcock
2023-02-10 16:47 ` Nick Alcock
2023-02-10 17:36 ` Rob Herring
2023-02-10 17:36 ` Rob Herring
2023-02-10 18:43 ` Nick Alcock
2023-02-10 18:43 ` Nick Alcock
2023-02-13 22:57 ` Bjorn Helgaas
2023-02-13 22:57 ` Bjorn Helgaas
2023-02-14 15:41 ` Nick Alcock
2023-02-14 15:41 ` Nick Alcock
2023-02-14 17:20 ` Bjorn Helgaas
2023-02-14 17:20 ` Bjorn Helgaas
2023-02-16 13:34 ` Nick Alcock
2023-02-16 13:34 ` Nick Alcock
2023-02-10 16:47 ` [PATCH 2/8] kbuild, PCI: mobiveil: " Nick Alcock
2023-02-10 16:47 ` [PATCH 3/8] kbuild, ARM: tegra: " Nick Alcock
2023-02-10 16:47 ` [PATCH 4/8] kbuild, PCI: endpoint: " Nick Alcock
2023-02-10 16:47 ` [PATCH 5/8] kbuild, PCI: hip: " Nick Alcock
2023-02-10 16:47 ` [PATCH 6/8] kbuild, shpchp: " Nick Alcock
2023-02-10 16:47 ` [PATCH 7/8] kbuild, PCI: dwc: histb: " Nick Alcock
2023-02-10 16:47 ` [PATCH 8/8] kbuild, PCI: microchip: " Nick Alcock
2023-02-10 16:47 ` Nick Alcock
2023-02-10 18:27 ` Conor Dooley
2023-02-10 18:27 ` Conor Dooley
2023-02-10 19:26 ` Nick Alcock
2023-02-10 19:26 ` Nick Alcock
2023-02-10 20:10 ` Conor Dooley
2023-02-10 20:10 ` Conor Dooley
2023-02-12 18:37 ` Leon Romanovsky
2023-02-12 18:37 ` Leon Romanovsky
2023-02-12 19:52 ` Nick Alcock
2023-02-12 19:52 ` Nick Alcock
2023-02-13 15:53 ` Nick Alcock
2023-02-13 15:53 ` Nick Alcock
2023-02-13 16:13 ` Nick Alcock
2023-02-13 16:13 ` Nick Alcock
2023-02-13 16:51 ` Conor Dooley
2023-02-13 16:51 ` Conor Dooley
2023-02-13 17:06 ` Leon Romanovsky
2023-02-13 17:06 ` Leon Romanovsky
2023-02-15 19:06 ` Nick Alcock
2023-02-15 19:06 ` Nick Alcock
2023-02-13 17:30 ` Jonathan Corbet [this message]
2023-02-13 17:30 ` Jonathan Corbet
2023-02-13 19:23 ` Leon Romanovsky
2023-02-13 19:23 ` Leon Romanovsky
2023-02-16 12:05 ` Nick Alcock
2023-02-16 12:05 ` Nick Alcock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilg5mq0r.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=conor@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=nick.alcock@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.